Skip to content

[fix](view)Fix show create view not display column_definition #55819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
starocean999 merged 5 commits into from
Sep 16, 2025
Merged

[fix](view)Fix show create view not display column_definition #55819

starocean999 merged 5 commits into from
Sep 16, 2025

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented Sep 9, 2025 •
edited
Loading

What problem does this PR solve?

CREATE VIEW v2
(
k11,
v1 comment "v1_comment"
)
COMMENT "my first view"
AS
SELECT k1,SUM(k2) FROM user group by k1;

mysql> show create view v2\G
*************************** 1. row ***************************
                View: v2
         Create View: CREATE VIEW `v2`
(k11,v1 comment 'v1_comment')
 COMMENT 'my first view' AS SELECT `internal`.`zd`.`user`.`k1` AS `k11`, SUM(`internal`.`zd`.`user`.`k2`) AS `v1` FROM `internal`.`zd`.`user` group by `internal`.`zd`.`user`.`k1`;
character_set_client: utf8mb4
collation_connection: utf8mb4_0900_bin
1 row in set (0.01 sec)

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Sep 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr
Copy link
Contributor Author

zddr commented Sep 9, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 9, 2025

FE UT Coverage Report

Increment line coverage 75.00% (3/4) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

doris-robot commented Sep 9, 2025

TPC-H: Total hot run time: 34841 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5fe99e5cfcbb3e7e92aff39ef1e3bc90b1abd834, data reload: false

------ Round 1 ----------------------------------
q1	17605	5184	5040	5040
q2	1994	379	226	226
q3	10179	1333	745	745
q4	10239	1058	536	536
q5	7550	2497	2329	2329
q6	189	172	136	136
q7	966	783	636	636
q8	9344	1328	1126	1126
q9	7056	5168	5182	5168
q10	6910	2422	2005	2005
q11	502	305	284	284
q12	368	374	225	225
q13	17786	3708	3066	3066
q14	231	236	213	213
q15	569	503	494	494
q16	1004	1006	925	925
q17	628	869	372	372
q18	7879	7254	7124	7124
q19	1095	970	548	548
q20	345	344	225	225
q21	4094	2601	2410	2410
q22	1069	1043	1008	1008
Total cold run time: 107602 ms
Total hot run time: 34841 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5133	5062	5074	5062
q2	244	331	230	230
q3	2249	2653	2303	2303
q4	1395	1823	1303	1303
q5	4248	4609	4609	4609
q6	218	177	132	132
q7	2063	1971	1851	1851
q8	2652	2723	2660	2660
q9	7325	7441	7461	7441
q10	3155	3347	2895	2895
q11	617	523	498	498
q12	692	790	638	638
q13	3649	3947	3574	3574
q14	299	322	289	289
q15	534	521	480	480
q16	1083	1124	1083	1083
q17	1202	1590	1364	1364
q18	7893	7702	7693	7693
q19	855	836	946	836
q20	2086	2119	1876	1876
q21	5109	4388	4332	4332
q22	1080	1072	998	998
Total cold run time: 53781 ms
Total hot run time: 52147 ms

@doris-robot
Copy link

doris-robot commented Sep 9, 2025

TPC-DS: Total hot run time: 188572 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5fe99e5cfcbb3e7e92aff39ef1e3bc90b1abd834, data reload: false

query1	1073	429	409	409
query2	6564	1673	1714	1673
query3	6757	229	228	228
query4	26005	23389	22895	22895
query5	4434	650	536	536
query6	356	252	240	240
query7	4657	517	303	303
query8	331	274	272	272
query9	8683	2943	2929	2929
query10	503	360	308	308
query11	16007	15027	14754	14754
query12	187	126	121	121
query13	1678	561	445	445
query14	11254	9087	9139	9087
query15	204	189	173	173
query16	7672	668	490	490
query17	1317	825	613	613
query18	2041	436	329	329
query19	207	195	169	169
query20	133	122	120	120
query21	213	137	121	121
query22	4051	4145	4055	4055
query23	34020	32961	32909	32909
query24	8140	2362	2348	2348
query25	569	498	453	453
query26	1231	276	176	176
query27	2726	509	349	349
query28	4405	2275	2237	2237
query29	836	617	503	503
query30	289	231	201	201
query31	944	825	716	716
query32	93	83	82	82
query33	599	396	355	355
query34	810	881	537	537
query35	838	850	795	795
query36	975	1021	959	959
query37	130	112	93	93
query38	3492	3530	3455	3455
query39	1465	1439	1412	1412
query40	225	142	123	123
query41	62	65	66	65
query42	133	124	127	124
query43	512	498	459	459
query44	1360	862	861	861
query45	185	178	174	174
query46	858	1034	662	662
query47	1804	1829	1734	1734
query48	403	424	320	320
query49	774	508	413	413
query50	657	694	397	397
query51	3876	3994	3810	3810
query52	113	117	110	110
query53	239	283	201	201
query54	627	609	564	564
query55	97	93	97	93
query56	347	345	308	308
query57	1181	1204	1137	1137
query58	294	308	280	280
query59	2580	2624	2552	2552
query60	392	359	348	348
query61	163	156	193	156
query62	823	746	660	660
query63	232	206	191	191
query64	4536	1135	827	827
query65	4056	3930	3978	3930
query66	1094	435	352	352
query67	15442	15388	15147	15147
query68	7688	938	585	585
query69	504	329	292	292
query70	1364	1257	1242	1242
query71	582	353	323	323
query72	5949	5060	4924	4924
query73	663	587	365	365
query74	8986	9321	9044	9044
query75	3313	3364	2779	2779
query76	3221	1168	752	752
query77	494	426	334	334
query78	9462	9502	8924	8924
query79	2619	836	599	599
query80	765	572	527	527
query81	504	264	222	222
query82	482	169	134	134
query83	262	254	253	253
query84	264	115	97	97
query85	893	463	417	417
query86	390	315	327	315
query87	3731	3703	3650	3650
query88	3815	2203	2236	2203
query89	423	340	297	297
query90	1907	233	227	227
query91	157	157	135	135
query92	93	80	72	72
query93	2092	989	654	654
query94	761	421	327	327
query95	415	337	328	328
query96	480	586	277	277
query97	2941	2970	2876	2876
query98	255	230	224	224
query99	1534	1420	1326	1326
Total cold run time: 275963 ms
Total hot run time: 188572 ms

@doris-robot
Copy link

doris-robot commented Sep 9, 2025

ClickBench: Total hot run time: 30.19 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5fe99e5cfcbb3e7e92aff39ef1e3bc90b1abd834, data reload: false

query1	0.05	0.06	0.05
query2	0.08	0.05	0.06
query3	0.24	0.09	0.10
query4	1.61	0.11	0.11
query5	0.28	0.27	0.26
query6	1.19	0.65	0.63
query7	0.03	0.02	0.03
query8	0.06	0.04	0.05
query9	0.60	0.54	0.53
query10	0.58	0.58	0.58
query11	0.16	0.11	0.12
query12	0.15	0.13	0.12
query13	0.62	0.62	0.62
query14	1.05	1.04	1.04
query15	0.87	0.86	0.89
query16	0.42	0.40	0.39
query17	1.08	1.06	1.03
query18	0.22	0.24	0.21
query19	1.93	1.86	1.81
query20	0.01	0.01	0.02
query21	15.41	0.96	0.60
query22	0.76	1.28	0.86
query23	14.73	1.36	0.65
query24	7.11	0.87	0.89
query25	0.54	0.23	0.09
query26	0.54	0.18	0.15
query27	0.07	0.05	0.06
query28	9.91	0.93	0.42
query29	12.54	3.92	3.28
query30	0.29	0.13	0.11
query31	2.82	0.59	0.40
query32	3.24	0.56	0.47
query33	3.03	3.03	3.10
query34	16.19	5.49	4.87
query35	4.94	4.94	4.91
query36	0.70	0.50	0.50
query37	0.11	0.08	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.19	0.16	0.14
query41	0.10	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 104.63 s
Total hot run time: 30.19 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 9, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (4/4) 🎉
Increment coverage report
Complete coverage report

@zddr
Copy link
Contributor Author

zddr commented Sep 10, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 10, 2025

TPC-H: Total hot run time: 34903 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e88010847135516e7852a9d964aa42e8a5ef0ff9, data reload: false

------ Round 1 ----------------------------------
q1	17623	5284	5163	5163
q2	1979	366	218	218
q3	10207	1340	744	744
q4	10232	1056	540	540
q5	7562	2484	2348	2348
q6	190	171	141	141
q7	957	793	640	640
q8	9353	1493	1149	1149
q9	6979	5171	5164	5164
q10	6945	2412	1975	1975
q11	499	310	274	274
q12	372	367	234	234
q13	17782	3746	3032	3032
q14	242	237	212	212
q15	571	504	492	492
q16	1022	1028	956	956
q17	634	890	362	362
q18	7827	7184	6983	6983
q19	1237	968	591	591
q20	348	343	241	241
q21	4096	3314	2432	2432
q22	1085	1040	1012	1012
Total cold run time: 107742 ms
Total hot run time: 34903 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5254	5250	5174	5174
q2	257	345	232	232
q3	2234	2700	2323	2323
q4	1350	1796	1320	1320
q5	4251	4114	4149	4114
q6	207	168	132	132
q7	1912	1850	1705	1705
q8	2564	2616	2449	2449
q9	6879	6709	6764	6709
q10	2938	3181	2725	2725
q11	570	517	494	494
q12	686	753	622	622
q13	3286	3727	3043	3043
q14	302	298	259	259
q15	540	474	479	474
q16	1052	1057	1002	1002
q17	1118	1529	1329	1329
q18	7241	7134	7047	7047
q19	835	805	837	805
q20	1926	2006	1815	1815
q21	4755	4488	4272	4272
q22	1088	1043	1011	1011
Total cold run time: 51245 ms
Total hot run time: 49056 ms

@doris-robot
Copy link

doris-robot commented Sep 10, 2025

TPC-DS: Total hot run time: 189560 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e88010847135516e7852a9d964aa42e8a5ef0ff9, data reload: false

query1	1061	435	418	418
query2	6553	1687	1696	1687
query3	6762	226	234	226
query4	26249	23661	22924	22924
query5	4804	701	510	510
query6	333	247	252	247
query7	4681	552	309	309
query8	311	274	268	268
query9	8648	2925	2943	2925
query10	503	389	317	317
query11	15981	15164	14837	14837
query12	193	130	120	120
query13	1701	579	458	458
query14	11731	9498	9443	9443
query15	219	203	178	178
query16	7693	686	515	515
query17	1630	809	652	652
query18	2052	451	357	357
query19	296	199	173	173
query20	130	133	122	122
query21	215	130	116	116
query22	4146	4323	4159	4159
query23	34157	33012	33020	33012
query24	8089	2407	2470	2407
query25	601	541	447	447
query26	1248	289	170	170
query27	2674	508	367	367
query28	4460	2275	2243	2243
query29	799	619	527	527
query30	299	231	197	197
query31	956	853	753	753
query32	88	83	85	83
query33	571	405	365	365
query34	846	875	525	525
query35	855	837	767	767
query36	975	1034	912	912
query37	128	118	99	99
query38	3589	3580	3475	3475
query39	1478	1438	1415	1415
query40	230	142	131	131
query41	70	62	61	61
query42	130	120	120	120
query43	503	495	483	483
query44	1419	904	874	874
query45	188	183	172	172
query46	879	1039	663	663
query47	1748	1807	1699	1699
query48	403	435	331	331
query49	752	544	414	414
query50	676	699	423	423
query51	3989	3901	3916	3901
query52	123	121	113	113
query53	256	282	217	217
query54	651	620	549	549
query55	99	95	96	95
query56	366	373	339	339
query57	1207	1205	1135	1135
query58	308	284	294	284
query59	2594	2695	2560	2560
query60	364	371	352	352
query61	163	161	166	161
query62	819	746	668	668
query63	232	198	208	198
query64	4479	1186	886	886
query65	4067	4059	3985	3985
query66	1139	445	361	361
query67	15419	15351	15080	15080
query68	9830	962	586	586
query69	512	345	304	304
query70	1422	1251	1272	1251
query71	579	359	347	347
query72	5841	5050	5293	5050
query73	780	667	362	362
query74	9273	9127	8738	8738
query75	4554	3271	2766	2766
query76	4141	1187	802	802
query77	1008	469	337	337
query78	9556	9885	8913	8913
query79	2446	852	589	589
query80	693	581	538	538
query81	486	267	228	228
query82	464	173	138	138
query83	298	262	256	256
query84	311	116	96	96
query85	873	473	432	432
query86	352	329	291	291
query87	3757	3775	3670	3670
query88	2827	2188	2187	2187
query89	445	323	294	294
query90	1945	232	224	224
query91	164	163	134	134
query92	88	84	73	73
query93	1791	994	642	642
query94	699	427	335	335
query95	421	339	338	338
query96	480	591	277	277
query97	2981	3019	2880	2880
query98	270	238	229	229
query99	1471	1420	1273	1273
Total cold run time: 281736 ms
Total hot run time: 189560 ms

@doris-robot
Copy link

doris-robot commented Sep 10, 2025

ClickBench: Total hot run time: 29.4 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e88010847135516e7852a9d964aa42e8a5ef0ff9, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.05	0.06
query3	0.26	0.08	0.09
query4	1.60	0.12	0.11
query5	0.28	0.27	0.25
query6	1.22	0.66	0.65
query7	0.04	0.03	0.03
query8	0.05	0.04	0.04
query9	0.62	0.52	0.52
query10	0.58	0.58	0.58
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.65	0.62	0.60
query14	1.04	1.03	1.02
query15	0.88	0.87	0.87
query16	0.41	0.38	0.39
query17	1.03	1.06	1.04
query18	0.22	0.20	0.20
query19	1.93	1.82	1.81
query20	0.01	0.02	0.01
query21	15.41	0.98	0.58
query22	0.80	1.17	0.76
query23	14.89	1.37	0.63
query24	7.17	1.17	0.34
query25	0.33	0.18	0.06
query26	0.60	0.16	0.13
query27	0.06	0.05	0.06
query28	9.49	0.93	0.46
query29	12.59	3.86	3.25
query30	0.29	0.14	0.11
query31	2.82	0.59	0.38
query32	3.25	0.59	0.48
query33	3.11	3.07	3.06
query34	16.18	5.48	4.83
query35	4.93	4.93	4.87
query36	0.70	0.51	0.50
query37	0.11	0.08	0.08
query38	0.07	0.05	0.05
query39	0.03	0.03	0.03
query40	0.20	0.16	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.02
query43	0.04	0.04	0.04
Total cold run time: 104.47 s
Total hot run time: 29.4 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 10, 2025

FE UT Coverage Report

Increment line coverage 75.00% (3/4) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 10, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (4/4) 🎉
Increment coverage report
Complete coverage report

@zddr
Copy link
Contributor Author

zddr commented Sep 10, 2025

run cloud_p0

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 10, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (4/4) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow added dev/3.1.x usercase Important user case type label dev/3.0.x labels Sep 16, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2025

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit 54f60de into apache:master Sep 16, 2025
32 of 33 checks passed
@zddr zddr mentioned this pull request Oct 16, 2025
Merged
morrySnow pushed a commit that referenced this pull request Oct 17, 2025
@zddr
branch-3.1: [fix](view)Fix show create view not display column_defini…
5dab87a 
…tion #55819 (#57045)

pick: #55819
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Nov 12, 2025
@zddr
branch-3.0:[fix](view)Fix show create view not display column_definit…
bf6d8b7 
…ion (apache#55819) (apache#5145)

pick: apache#55819
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Dec 19, 2025
@zddr
branch-2.1:[fix](view)Fix show create view not display column_definit…
b30530d 
…ion (apache#55819) (apache#5147)

pick:apache#55819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@morrySnow morrySnow morrySnow approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

@morningman morningman Awaiting requested review from morningman morningman is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.x dev/2.1.x-conflict dev/3.1.2-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zddr @Thearas @hello-stephen @doris-robot @CalvinKirs @morrySnow @starocean999