Skip to content

branch-3.1: [fix](view)Fix show create view not display column_definition #55819 #57045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 2 commits into from
Oct 17, 2025
Merged

branch-3.1: [fix](view)Fix show create view not display column_definition #55819 #57045

morrySnow merged 2 commits into from
Oct 17, 2025

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented Oct 16, 2025 •
edited by morrySnow
Loading

pick: #55819

zddr and others added 2 commits October 16, 2025 14:25
@zddr zddr requested a review from morrySnow as a code owner October 16, 2025 06:56
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr
Copy link
Contributor Author

zddr commented Oct 16, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 16, 2025

TPC-H: Total hot run time: 32566 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dbe29cd2b71a5503e63165b0ebb0a9fd26f7f400, data reload: false

------ Round 1 ----------------------------------
q1	17625	5459	5413	5413
q2	2019	394	305	305
q3	12312	1226	747	747
q4	10568	870	458	458
q5	9623	2377	2131	2131
q6	199	160	130	130
q7	884	741	603	603
q8	9349	1402	1148	1148
q9	5178	4913	5201	4913
q10	6754	2254	1797	1797
q11	462	284	271	271
q12	334	353	220	220
q13	17798	3609	2990	2990
q14	227	226	211	211
q15	536	462	457	457
q16	414	431	373	373
q17	603	853	364	364
q18	7008	6370	6305	6305
q19	1219	953	527	527
q20	324	338	226	226
q21	2771	2210	1974	1974
q22	1068	1039	1003	1003
Total cold run time: 107275 ms
Total hot run time: 32566 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5619	5513	5465	5465
q2	249	336	243	243
q3	2377	2710	2409	2409
q4	1471	1854	1418	1418
q5	4503	5136	5075	5075
q6	171	168	130	130
q7	2134	2007	1846	1846
q8	2698	2848	2659	2659
q9	7257	7217	7236	7217
q10	3057	3230	2747	2747
q11	581	543	507	507
q12	702	774	623	623
q13	3345	3764	3123	3123
q14	279	301	278	278
q15	532	465	465	465
q16	434	497	450	450
q17	1212	1735	1270	1270
q18	7655	7455	7342	7342
q19	790	1173	1014	1014
q20	2042	2038	1915	1915
q21	5372	4888	4558	4558
q22	1086	1059	1062	1059
Total cold run time: 53566 ms
Total hot run time: 51813 ms

@doris-robot
Copy link

doris-robot commented Oct 16, 2025

TPC-DS: Total hot run time: 192232 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dbe29cd2b71a5503e63165b0ebb0a9fd26f7f400, data reload: false

query1	940	410	398	398
query2	6197	1973	1931	1931
query3	8689	204	200	200
query4	33636	23729	23535	23535
query5	3569	615	477	477
query6	282	193	207	193
query7	4210	499	320	320
query8	317	256	249	249
query9	9466	2633	2599	2599
query10	483	325	268	268
query11	18570	15386	15232	15232
query12	157	112	109	109
query13	1539	542	401	401
query14	9654	6682	6410	6410
query15	236	185	179	179
query16	7884	660	511	511
query17	1534	751	577	577
query18	2189	420	328	328
query19	203	194	165	165
query20	122	120	125	120
query21	216	138	110	110
query22	4601	4710	4562	4562
query23	34911	34287	34267	34267
query24	8327	2698	2705	2698
query25	563	496	474	474
query26	1180	291	178	178
query27	2678	488	357	357
query28	5655	2263	2212	2212
query29	791	610	455	455
query30	245	190	168	168
query31	1011	949	832	832
query32	90	63	60	60
query33	511	386	326	326
query34	743	843	520	520
query35	803	832	723	723
query36	1033	1042	983	983
query37	104	92	70	70
query38	3984	4048	3943	3943
query39	1514	1472	1487	1472
query40	204	116	103	103
query41	47	49	48	48
query42	123	112	105	105
query43	520	520	494	494
query44	1298	829	819	819
query45	186	179	167	167
query46	902	1064	677	677
query47	2042	2040	1942	1942
query48	408	425	349	349
query49	784	486	423	423
query50	686	688	426	426
query51	7300	7250	7268	7250
query52	100	97	95	95
query53	222	260	202	202
query54	538	552	481	481
query55	84	81	82	81
query56	271	271	265	265
query57	1299	1290	1251	1251
query58	248	238	218	218
query59	3215	3132	3216	3132
query60	296	282	262	262
query61	111	116	111	111
query62	810	787	715	715
query63	231	192	194	192
query64	4656	1006	637	637
query65	3357	3278	3303	3278
query66	1104	430	312	312
query67	16263	15701	15620	15620
query68	7474	817	547	547
query69	488	329	271	271
query70	1188	1186	1135	1135
query71	382	304	257	257
query72	5613	3738	3834	3738
query73	641	745	350	350
query74	10450	9483	8831	8831
query75	3285	3177	2709	2709
query76	3296	1156	762	762
query77	602	375	277	277
query78	10219	10534	9685	9685
query79	2999	898	618	618
query80	605	524	448	448
query81	496	259	219	219
query82	407	120	86	86
query83	176	167	146	146
query84	289	111	77	77
query85	793	389	298	298
query86	393	317	291	291
query87	4260	4300	4165	4165
query88	5068	2389	2410	2389
query89	401	326	301	301
query90	1842	186	185	185
query91	135	138	109	109
query92	67	56	52	52
query93	2185	895	553	553
query94	686	418	293	293
query95	352	273	291	273
query96	481	605	283	283
query97	3201	3225	3114	3114
query98	218	204	196	196
query99	1586	1423	1307	1307
Total cold run time: 296420 ms
Total hot run time: 192232 ms

@doris-robot
Copy link

doris-robot commented Oct 16, 2025

ClickBench: Total hot run time: 28.69 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dbe29cd2b71a5503e63165b0ebb0a9fd26f7f400, data reload: false

query1	0.03	0.02	0.03
query2	0.06	0.04	0.03
query3	0.24	0.07	0.06
query4	1.62	0.10	0.10
query5	0.51	0.51	0.52
query6	1.14	0.73	0.73
query7	0.03	0.02	0.01
query8	0.04	0.02	0.03
query9	0.59	0.51	0.51
query10	0.55	0.55	0.56
query11	0.14	0.11	0.10
query12	0.14	0.10	0.11
query13	0.62	0.59	0.59
query14	0.77	0.80	0.80
query15	0.84	0.83	0.83
query16	0.40	0.38	0.38
query17	1.01	1.01	1.01
query18	0.24	0.22	0.21
query19	1.95	1.90	1.86
query20	0.01	0.01	0.01
query21	15.39	0.89	0.58
query22	0.73	0.68	0.67
query23	15.20	1.42	0.51
query24	3.50	0.75	1.19
query25	0.16	0.22	0.06
query26	0.33	0.16	0.14
query27	0.05	0.05	0.04
query28	13.07	1.03	0.44
query29	12.58	3.98	3.30
query30	0.27	0.09	0.07
query31	2.81	0.58	0.37
query32	3.23	0.54	0.46
query33	3.06	3.04	3.02
query34	16.76	5.16	4.55
query35	4.59	4.62	4.53
query36	0.65	0.50	0.47
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.03	0.02
query40	0.16	0.12	0.12
query41	0.07	0.02	0.03
query42	0.03	0.03	0.02
query43	0.04	0.03	0.04
Total cold run time: 103.77 s
Total hot run time: 28.69 s

@morrySnow morrySnow changed the title branch-3.1:[fix](view)Fix show create view not display column_definition branch-3.1:[fix](view)Fix show create view not display column_definition #55819 Oct 17, 2025
@morrySnow morrySnow changed the title branch-3.1:[fix](view)Fix show create view not display column_definition #55819 branch-3.1: [fix](view)Fix show create view not display column_definition #55819 Oct 17, 2025
@morrySnow morrySnow merged commit 5dab87a into apache:branch-3.1 Oct 17, 2025
23 checks passed
@morrySnow morrySnow mentioned this pull request Oct 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zddr @hello-stephen @doris-robot @morrySnow