[Bug-Fix] Bucket shuffle join executes failed when two tables have no data #5145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 13, 2020 22:09
added 11 commits
November 17, 2020 11:43
HappenLee
requested changes
Dec 28, 2020
Contributor
HappenLee
left a comment
There was a problem hiding this comment.
I think it's little tricky here. It's the problem of left olap scan node with no data cause there is no tablet to decide where to sender the data. when left table is no data, FE should not chose the bucket shuffle join is better.
//1 the left table must be only one partition
if (leftScanNode.getSelectedPartitionIds().size() != 1) {
return false;
}
Contributor
Author
good ideal. I will modify it. |
HappenLee
approved these changes
Dec 29, 2020
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Jan 26, 2021
… data (apache#5145) Bucket shuffle join is an algorithm of joining two tables. Left table is distributed by a column. Right table sends the data to the left table for joining operation. It reduces the network cost. But when two table is without any data. Bucket shuffle join will fail. Related Issue: apache#5144
Closed
levy5307
pushed a commit
to levy5307/incubator-doris
that referenced
this pull request
Nov 14, 2022
… data (apache#5145) Bucket shuffle join is an algorithm of joining two tables. Left table is distributed by a column. Right table sends the data to the left table for joining operation. It reduces the network cost. But when two table is without any data. Bucket shuffle join will fail. Related Issue: apache#5144
Hastyshell
pushed a commit
to Hastyshell/doris
that referenced
this pull request
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Bucket shuffle join is a algorithm of joining two tables. Left table is distrubuted by a column. Right table sends the data to the left table for joining operation. It reduces the network cost. But when two table is withou any data. Bucket shuffle join will fail.
Related Issue: #5144
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...