Skip to content

[fix](test)(jdbc) fix some external regression test cases and jdbc bug #52817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 4 commits into from
Jul 6, 2025
Merged

[fix](test)(jdbc) fix some external regression test cases and jdbc bug #52817

morningman merged 4 commits into from
Jul 6, 2025

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Jul 5, 2025 •
edited
Loading

Followup #52561
Also fix a bug introduced by #51471, which lost the function rules in jdbc external table.

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 5, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

morningman commented Jul 5, 2025

run buildall

@morningman
Copy link
Contributor Author

morningman commented Jul 5, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 5, 2025

TPC-H: Total hot run time: 33581 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ecd16341a4eab6ef7ce5fae61aeacd3c5e95cd59, data reload: false

------ Round 1 ----------------------------------
q1	17578	5213	5046	5046
q2	1934	267	193	193
q3	10379	1280	718	718
q4	10300	1007	530	530
q5	8235	2333	2330	2330
q6	175	165	129	129
q7	860	734	617	617
q8	9295	1227	1068	1068
q9	6776	5018	5076	5018
q10	6880	2380	1945	1945
q11	475	296	261	261
q12	338	345	208	208
q13	17762	3630	3086	3086
q14	231	226	203	203
q15	569	473	492	473
q16	429	425	383	383
q17	583	848	362	362
q18	7524	7253	6936	6936
q19	1425	929	548	548
q20	326	341	213	213
q21	3776	3137	2344	2344
q22	1050	992	970	970
Total cold run time: 106900 ms
Total hot run time: 33581 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5176	5104	5107	5104
q2	241	324	221	221
q3	2124	2666	2268	2268
q4	1335	1718	1328	1328
q5	4208	4456	4673	4456
q6	206	166	126	126
q7	1951	2016	1857	1857
q8	2622	2619	2577	2577
q9	7244	7180	7294	7180
q10	3123	3306	2893	2893
q11	582	548	494	494
q12	681	829	647	647
q13	3554	3949	3505	3505
q14	276	281	266	266
q15	511	463	476	463
q16	440	503	450	450
q17	1153	1557	1388	1388
q18	7872	7573	7590	7573
q19	784	755	747	747
q20	1901	2012	1850	1850
q21	4809	4503	4457	4457
q22	1098	1070	1068	1068
Total cold run time: 51891 ms
Total hot run time: 50918 ms

@doris-robot
Copy link

doris-robot commented Jul 5, 2025

TPC-DS: Total hot run time: 184169 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ecd16341a4eab6ef7ce5fae61aeacd3c5e95cd59, data reload: false

query1	990	391	380	380
query2	6519	1615	1612	1612
query3	6741	206	210	206
query4	26707	23721	23368	23368
query5	4353	578	439	439
query6	305	216	197	197
query7	4621	477	296	296
query8	277	213	210	210
query9	8574	2626	2623	2623
query10	487	355	274	274
query11	15513	14956	14756	14756
query12	160	106	104	104
query13	1675	519	410	410
query14	8535	5741	5735	5735
query15	217	197	183	183
query16	7613	619	444	444
query17	1225	707	599	599
query18	2009	400	309	309
query19	196	197	154	154
query20	124	118	113	113
query21	207	131	104	104
query22	3935	4192	3898	3898
query23	33919	33089	33058	33058
query24	8517	2315	2364	2315
query25	535	473	397	397
query26	1232	274	146	146
query27	2756	514	330	330
query28	4322	2111	2090	2090
query29	742	544	435	435
query30	282	209	188	188
query31	901	838	744	744
query32	68	60	67	60
query33	543	347	315	315
query34	788	843	520	520
query35	796	791	763	763
query36	982	987	897	897
query37	111	98	73	73
query38	4096	4173	4110	4110
query39	1497	1413	1398	1398
query40	211	114	103	103
query41	54	54	52	52
query42	132	113	103	103
query43	495	503	472	472
query44	1318	822	806	806
query45	175	165	158	158
query46	830	1018	625	625
query47	1742	1786	1702	1702
query48	389	420	305	305
query49	747	476	382	382
query50	669	676	404	404
query51	4131	4122	4100	4100
query52	118	104	102	102
query53	220	255	189	189
query54	581	571	493	493
query55	81	76	78	76
query56	283	295	284	284
query57	1168	1164	1149	1149
query58	265	249	270	249
query59	2519	2735	2534	2534
query60	316	308	320	308
query61	120	119	114	114
query62	851	696	678	678
query63	218	181	182	181
query64	4235	995	644	644
query65	4256	4158	4174	4158
query66	1105	390	312	312
query67	15506	15610	15260	15260
query68	7986	878	531	531
query69	485	287	264	264
query70	1231	1131	1070	1070
query71	482	310	285	285
query72	5396	4681	4759	4681
query73	714	636	346	346
query74	9175	9184	8737	8737
query75	3777	3169	2688	2688
query76	3635	1135	705	705
query77	793	388	282	282
query78	10083	10272	9278	9278
query79	2195	811	599	599
query80	560	507	448	448
query81	483	255	226	226
query82	454	125	94	94
query83	247	257	232	232
query84	249	100	79	79
query85	806	340	302	302
query86	384	295	291	291
query87	4361	4464	4290	4290
query88	3610	2282	2307	2282
query89	383	320	281	281
query90	1814	200	203	200
query91	136	155	103	103
query92	74	56	57	56
query93	1606	943	589	589
query94	671	396	292	292
query95	368	284	286	284
query96	491	573	282	282
query97	2695	2738	2687	2687
query98	223	204	208	204
query99	1533	1386	1285	1285
Total cold run time: 272905 ms
Total hot run time: 184169 ms

@doris-robot
Copy link

doris-robot commented Jul 5, 2025

ClickBench: Total hot run time: 29.44 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ecd16341a4eab6ef7ce5fae61aeacd3c5e95cd59, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.25	0.08	0.07
query4	1.62	0.11	0.11
query5	0.44	0.42	0.40
query6	1.18	0.65	0.66
query7	0.03	0.02	0.02
query8	0.04	0.04	0.04
query9	0.62	0.51	0.53
query10	0.57	0.57	0.57
query11	0.15	0.11	0.11
query12	0.15	0.12	0.11
query13	0.62	0.62	0.60
query14	0.78	0.83	0.82
query15	0.92	0.88	0.87
query16	0.38	0.38	0.39
query17	1.05	1.06	1.09
query18	0.23	0.22	0.21
query19	1.92	1.88	1.82
query20	0.01	0.02	0.02
query21	15.42	0.87	0.54
query22	0.74	1.09	0.71
query23	14.96	1.35	0.65
query24	7.26	1.77	0.62
query25	0.47	0.24	0.07
query26	0.67	0.16	0.13
query27	0.06	0.05	0.05
query28	9.70	0.89	0.44
query29	12.57	3.90	3.30
query30	0.26	0.09	0.06
query31	2.84	0.59	0.38
query32	3.24	0.54	0.48
query33	3.05	3.20	3.12
query34	16.10	5.50	4.78
query35	4.80	4.88	4.87
query36	0.69	0.50	0.48
query37	0.09	0.06	0.07
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.09	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 104.41 s
Total hot run time: 29.44 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 5, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/9) 🎉
Increment coverage report
Complete coverage report

@morningman morningman changed the title [fix](test) fix some external regression test cases [fix](test)(jdbc) fix some external regression test cases and jdbc bug Jul 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2025

PR approved by anyone and no changes requested.

@morningman morningman merged commit ebc63ea into apache:master Jul 6, 2025
28 of 30 checks passed
morningman added a commit to morningman/doris that referenced this pull request Jul 10, 2025
@morningman
[fix](test)(jdbc) fix some external regression test cases and jdbc bug (
cba2d4e 
apache#52817)

Followup apache#52561
Also fix a bug introduced by apache#51471, which lost the function rules in
jdbc external table.
@morningman morningman mentioned this pull request Jul 10, 2025
Merged
morningman added a commit to morningman/doris that referenced this pull request Jul 10, 2025
@morningman
[fix](test)(jdbc) fix some external regression test cases and jdbc bug (
8c5a0af 
apache#52817)

Followup apache#52561
Also fix a bug introduced by apache#51471, which lost the function rules in
jdbc external table.
morningman added a commit to morningman/doris that referenced this pull request Jul 10, 2025
@morningman
[fix](test)(jdbc) fix some external regression test cases and jdbc bug (
a4f9436 
apache#52817)

Followup apache#52561
Also fix a bug introduced by apache#51471, which lost the function rules in
jdbc external table.
morningman added a commit to morningman/doris that referenced this pull request Jul 11, 2025
@morningman
[fix](test)(jdbc) fix some external regression test cases and jdbc bug (
599290e 
apache#52817)

Followup apache#52561
Also fix a bug introduced by apache#51471, which lost the function rules in
jdbc external table.
morrySnow pushed a commit that referenced this pull request Jul 11, 2025
@morningman @suxiaogang223
branch-3.1: [fix](hive) use the remote name when get meta from hive s…
250e3d7 
…ystem. #52561 #52817 #52881 #52989 (#53030)

bp (#52561)(#52817)(#52881)(#52989)

---------

Co-authored-by: Socrates <suyiteng@selectdb.com>
@morningman morningman mentioned this pull request Jul 15, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jul 16, 2025
@morningman
[branch-3.0](fix) fix function rules are not persisted (#52817) (#53263)
fef6f7c 
pick part of #52817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@CalvinKirs CalvinKirs CalvinKirs approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@morningman @hello-stephen @doris-robot @gavinchou @CalvinKirs @dataroaring @morrySnow