Skip to content

[branch-3.0](fix) fix function rules are not persisted (#52817) #53263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jul 16, 2025
Merged

[branch-3.0](fix) fix function rules are not persisted (#52817) #53263

dataroaring merged 1 commit into from
Jul 16, 2025

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Jul 15, 2025

pick part of #52817

@morningman morningman requested a review from dataroaring as a code owner July 15, 2025 04:21
@Thearas
Copy link
Contributor

Thearas commented Jul 15, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

morningman commented Jul 15, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 15, 2025

TPC-H: Total hot run time: 40270 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cb4b8a57ecb7c9ee4c617376d64b3fad02b0c497, data reload: false

------ Round 1 ----------------------------------
q1	17605	6758	6643	6643
q2	2074	182	166	166
q3	10711	1158	1166	1158
q4	10509	801	702	702
q5	7729	2910	2841	2841
q6	216	137	133	133
q7	997	630	643	630
q8	9357	1963	2066	1963
q9	6666	6417	6447	6417
q10	6996	2235	2240	2235
q11	461	268	277	268
q12	407	226	226	226
q13	17775	3015	3021	3015
q14	234	213	219	213
q15	529	485	466	466
q16	485	382	371	371
q17	991	631	517	517
q18	7457	6730	6709	6709
q19	1389	1090	1066	1066
q20	502	206	203	203
q21	3954	3338	3318	3318
q22	1130	1010	1017	1010
Total cold run time: 108174 ms
Total hot run time: 40270 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6572	6582	6602	6582
q2	332	240	234	234
q3	2960	3056	3064	3056
q4	2062	1755	1808	1755
q5	5778	5818	5659	5659
q6	207	126	125	125
q7	2208	1789	1812	1789
q8	3357	3537	3556	3537
q9	8851	8851	8888	8851
q10	3581	3517	3563	3517
q11	578	502	497	497
q12	793	637	587	587
q13	8741	3229	3164	3164
q14	291	257	271	257
q15	505	484	466	466
q16	502	438	460	438
q17	1832	1620	1587	1587
q18	8213	7860	7737	7737
q19	1692	1611	1483	1483
q20	2118	1897	1809	1809
q21	5129	4905	5046	4905
q22	1119	995	1032	995
Total cold run time: 67421 ms
Total hot run time: 59030 ms

@doris-robot
Copy link

doris-robot commented Jul 15, 2025

TPC-DS: Total hot run time: 190764 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cb4b8a57ecb7c9ee4c617376d64b3fad02b0c497, data reload: false

query1	952	369	384	369
query2	6524	1890	1866	1866
query3	6705	217	212	212
query4	34135	23467	23715	23467
query5	4329	481	450	450
query6	282	181	197	181
query7	4627	328	335	328
query8	275	226	214	214
query9	9633	2582	2576	2576
query10	485	263	266	263
query11	18257	15225	15393	15225
query12	165	101	108	101
query13	1635	444	426	426
query14	10196	7113	6966	6966
query15	237	173	185	173
query16	8087	492	465	465
query17	1630	589	561	561
query18	2128	341	313	313
query19	248	160	160	160
query20	119	111	111	111
query21	212	105	106	105
query22	4370	4357	4185	4185
query23	34279	33553	33415	33415
query24	11244	2915	2889	2889
query25	715	391	395	391
query26	1578	171	168	168
query27	2905	337	347	337
query28	7712	2099	2103	2099
query29	971	434	422	422
query30	325	164	163	163
query31	1035	784	800	784
query32	101	62	59	59
query33	779	303	292	292
query34	949	511	538	511
query35	949	698	707	698
query36	1109	908	917	908
query37	130	66	68	66
query38	3956	3828	3914	3828
query39	1473	1437	1449	1437
query40	283	101	101	101
query41	53	49	51	49
query42	115	102	101	101
query43	497	479	466	466
query44	1240	795	791	791
query45	187	167	172	167
query46	1140	727	715	715
query47	1915	1830	1824	1824
query48	467	368	403	368
query49	1276	385	399	385
query50	833	414	412	412
query51	7414	7219	7199	7199
query52	106	95	92	92
query53	260	188	186	186
query54	1275	472	475	472
query55	79	77	76	76
query56	256	234	251	234
query57	1284	1179	1151	1151
query58	240	208	214	208
query59	3189	2804	2802	2802
query60	289	250	257	250
query61	115	107	108	107
query62	873	656	653	653
query63	217	190	198	190
query64	5244	671	629	629
query65	3320	3188	3215	3188
query66	1423	315	329	315
query67	15949	15589	15538	15538
query68	3224	608	596	596
query69	411	268	260	260
query70	1173	1081	1090	1081
query71	325	253	253	253
query72	6201	4302	4243	4243
query73	758	352	357	352
query74	10047	9333	9049	9049
query75	3343	2648	2666	2648
query76	1993	1107	1056	1056
query77	409	294	288	288
query78	10511	9687	9605	9605
query79	2006	609	615	609
query80	1235	466	477	466
query81	556	224	220	220
query82	873	94	87	87
query83	224	147	155	147
query84	237	85	76	76
query85	1349	306	292	292
query86	447	290	284	284
query87	4379	4238	4226	4226
query88	3863	2418	2362	2362
query89	410	295	300	295
query90	2078	190	184	184
query91	185	149	152	149
query92	72	54	59	54
query93	1599	576	556	556
query94	986	304	300	300
query95	369	270	262	262
query96	621	281	298	281
query97	3275	3140	3156	3140
query98	215	203	199	199
query99	1500	1291	1314	1291
Total cold run time: 299854 ms
Total hot run time: 190764 ms

@doris-robot
Copy link

doris-robot commented Jul 15, 2025

ClickBench: Total hot run time: 29.92 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cb4b8a57ecb7c9ee4c617376d64b3fad02b0c497, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.63	0.11	0.10
query5	0.52	0.51	0.51
query6	1.14	0.74	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.57	0.50	0.51
query10	0.57	0.56	0.58
query11	0.15	0.10	0.11
query12	0.14	0.11	0.11
query13	0.60	0.59	0.60
query14	0.77	0.78	0.79
query15	0.84	0.81	0.83
query16	0.38	0.37	0.38
query17	1.03	1.07	1.07
query18	0.25	0.23	0.23
query19	2.00	1.80	1.90
query20	0.02	0.01	0.01
query21	15.42	0.60	0.62
query22	2.47	3.24	1.59
query23	17.00	0.95	0.71
query24	3.18	0.97	1.34
query25	0.38	0.20	0.09
query26	0.37	0.14	0.14
query27	0.05	0.05	0.04
query28	10.21	0.56	0.45
query29	12.62	3.24	3.26
query30	0.24	0.06	0.06
query31	2.85	0.39	0.37
query32	3.24	0.47	0.46
query33	2.96	3.03	3.00
query34	16.88	4.46	4.48
query35	4.58	4.54	4.52
query36	0.68	0.47	0.48
query37	0.10	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.03
query40	0.17	0.12	0.12
query41	0.08	0.02	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.64 s
Total hot run time: 29.92 s

dataroaring
dataroaring approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit fef6f7c into apache:branch-3.0 Jul 16, 2025
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morningman @Thearas @doris-robot @dataroaring