Skip to content

[fix](paimon) fix CacheException msg in loadSnapshot #52881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 2 commits into from
Jul 8, 2025
Merged

[fix](paimon) fix CacheException msg in loadSnapshot #52881

morningman merged 2 commits into from
Jul 8, 2025

Conversation

@suxiaogang223
Copy link
Contributor

@suxiaogang223 suxiaogang223 commented Jul 7, 2025 •
edited
Loading

What problem does this PR solve?

relate pr: #52561
Fix CacheException msg in loadSnapshot to make test_paimon_catalog.groovy happy

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Jul 7, 2025

run buildall

@suxiaogang223 suxiaogang223 changed the title [fix](paimon) fix CacheException in loadSnapshot [fix](paimon) fix CacheException msg in loadSnapshot Jul 7, 2025
@doris-robot
Copy link

doris-robot commented Jul 7, 2025

TPC-H: Total hot run time: 33182 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 82c9982d06fd08b718a3c2edd51ab0610533a2c6, data reload: false

------ Round 1 ----------------------------------
q1	17586	5148	5010	5010
q2	1928	278	182	182
q3	10330	1288	712	712
q4	10229	1005	511	511
q5	7675	2369	2310	2310
q6	180	161	126	126
q7	873	737	596	596
q8	9302	1290	1024	1024
q9	6724	5120	5110	5110
q10	6859	2362	1981	1981
q11	491	281	278	278
q12	331	347	207	207
q13	17774	3621	3146	3146
q14	220	227	219	219
q15	560	476	479	476
q16	415	418	379	379
q17	590	855	343	343
q18	7467	7084	7212	7084
q19	1431	949	577	577
q20	337	347	227	227
q21	4031	3210	2388	2388
q22	376	317	296	296
Total cold run time: 105709 ms
Total hot run time: 33182 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5049	5047	5037	5037
q2	244	320	222	222
q3	2196	2637	2304	2304
q4	1362	1767	1315	1315
q5	4182	4230	4465	4230
q6	209	173	133	133
q7	2019	1945	1799	1799
q8	2669	2625	2569	2569
q9	7302	7332	7333	7332
q10	3114	3300	2840	2840
q11	575	513	529	513
q12	683	791	611	611
q13	3575	4074	3426	3426
q14	300	317	287	287
q15	527	482	464	464
q16	459	494	448	448
q17	1173	1589	1344	1344
q18	7867	7746	7406	7406
q19	769	736	767	736
q20	1894	1983	1821	1821
q21	4744	4313	4293	4293
q22	589	609	540	540
Total cold run time: 51501 ms
Total hot run time: 49670 ms

@doris-robot
Copy link

doris-robot commented Jul 7, 2025

TPC-DS: Total hot run time: 184478 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 82c9982d06fd08b718a3c2edd51ab0610533a2c6, data reload: false

query1	1007	380	392	380
query2	6556	1629	1620	1620
query3	6741	211	207	207
query4	26076	23253	23227	23227
query5	4404	575	408	408
query6	336	210	203	203
query7	4624	487	286	286
query8	281	219	208	208
query9	8622	2610	2621	2610
query10	475	320	273	273
query11	15705	15029	14904	14904
query12	155	102	103	102
query13	1665	516	408	408
query14	9360	5632	5625	5625
query15	209	191	175	175
query16	7475	621	461	461
query17	1200	718	578	578
query18	2005	418	306	306
query19	202	197	165	165
query20	123	116	115	115
query21	213	129	111	111
query22	4138	4063	3991	3991
query23	34002	32792	33224	32792
query24	8463	2347	2363	2347
query25	512	472	394	394
query26	1231	308	148	148
query27	2711	500	351	351
query28	4286	2109	2118	2109
query29	714	555	425	425
query30	279	219	188	188
query31	921	866	761	761
query32	69	60	59	59
query33	577	371	331	331
query34	787	836	503	503
query35	776	831	756	756
query36	911	962	852	852
query37	116	95	80	80
query38	4171	4177	4033	4033
query39	1521	1392	1427	1392
query40	209	121	101	101
query41	57	56	50	50
query42	120	106	103	103
query43	490	517	473	473
query44	1283	837	813	813
query45	176	170	164	164
query46	825	1002	624	624
query47	1745	1805	1741	1741
query48	381	405	301	301
query49	732	480	392	392
query50	645	678	411	411
query51	4187	4137	4057	4057
query52	113	106	105	105
query53	217	256	182	182
query54	591	563	491	491
query55	81	78	80	78
query56	286	292	282	282
query57	1180	1197	1115	1115
query58	263	255	263	255
query59	2530	2730	2532	2532
query60	325	315	297	297
query61	132	128	127	127
query62	793	702	647	647
query63	218	184	187	184
query64	4269	1003	670	670
query65	4238	4164	4158	4158
query66	1107	408	319	319
query67	15646	15365	15231	15231
query68	8075	880	565	565
query69	464	306	282	282
query70	1205	1105	1128	1105
query71	455	324	285	285
query72	5772	4798	4793	4793
query73	721	618	348	348
query74	9133	9070	9078	9070
query75	3801	3141	2695	2695
query76	3619	1146	731	731
query77	784	371	289	289
query78	10256	10138	9352	9352
query79	2366	820	580	580
query80	663	511	453	453
query81	494	260	228	228
query82	478	130	97	97
query83	250	246	250	246
query84	249	110	79	79
query85	835	369	323	323
query86	389	321	306	306
query87	4556	4405	4402	4402
query88	3561	2251	2319	2251
query89	373	310	293	293
query90	1867	201	198	198
query91	149	144	106	106
query92	76	58	58	58
query93	1705	966	592	592
query94	690	381	309	309
query95	372	287	279	279
query96	484	563	272	272
query97	2706	2758	2608	2608
query98	241	207	207	207
query99	1434	1466	1289	1289
Total cold run time: 274681 ms
Total hot run time: 184478 ms

@doris-robot
Copy link

doris-robot commented Jul 7, 2025

ClickBench: Total hot run time: 30.39 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 82c9982d06fd08b718a3c2edd51ab0610533a2c6, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.04
query3	0.24	0.08	0.08
query4	1.61	0.10	0.11
query5	0.43	0.43	0.42
query6	1.15	0.67	0.65
query7	0.03	0.02	0.02
query8	0.05	0.04	0.03
query9	0.59	0.52	0.52
query10	0.58	0.57	0.57
query11	0.15	0.11	0.11
query12	0.15	0.12	0.11
query13	0.62	0.62	0.61
query14	0.80	0.81	0.81
query15	0.91	0.91	0.86
query16	0.38	0.38	0.38
query17	1.13	1.08	1.05
query18	0.22	0.21	0.21
query19	1.94	1.89	1.85
query20	0.01	0.01	0.01
query21	15.39	0.91	0.55
query22	0.75	1.09	0.67
query23	15.05	1.36	0.59
query24	6.73	1.70	1.85
query25	0.50	0.12	0.16
query26	0.60	0.15	0.14
query27	0.07	0.05	0.05
query28	10.29	0.81	0.44
query29	12.54	3.93	3.21
query30	0.26	0.09	0.06
query31	2.85	0.59	0.39
query32	3.23	0.55	0.48
query33	3.13	3.06	3.09
query34	16.15	5.42	4.85
query35	4.85	4.80	4.88
query36	0.71	0.51	0.49
query37	0.09	0.08	0.07
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.15	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.03
query43	0.04	0.03	0.02
Total cold run time: 104.69 s
Total hot run time: 30.39 s

@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Jul 7, 2025

run fe-ut

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 7, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉
Increment coverage report
Complete coverage report

hello-stephen
hello-stephen approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@hello-stephen hello-stephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

PR approved by anyone and no changes requested.

MoanasDaddyXu
MoanasDaddyXu approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@MoanasDaddyXu MoanasDaddyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit d1983dd into apache:master Jul 8, 2025
33 of 34 checks passed
morningman pushed a commit to morningman/doris that referenced this pull request Jul 10, 2025
@suxiaogang223 @morningman
[fix](paimon) fix CacheException msg in loadSnapshot (apache#52881)
a258004 
### What problem does this PR solve?
relate pr: apache#52561
Fix CacheException msg in loadSnapshot to make
test_paimon_catalog.groovy happy
@morningman morningman mentioned this pull request Jul 10, 2025
Merged
morningman pushed a commit to morningman/doris that referenced this pull request Jul 10, 2025
@suxiaogang223 @morningman
[fix](paimon) fix CacheException msg in loadSnapshot (apache#52881)
484158e 
### What problem does this PR solve?
relate pr: apache#52561
Fix CacheException msg in loadSnapshot to make
test_paimon_catalog.groovy happy
@suxiaogang223 suxiaogang223 deleted the fix_paimon_catalog branch July 10, 2025 09:02
morningman pushed a commit to morningman/doris that referenced this pull request Jul 10, 2025
@suxiaogang223 @morningman
[fix](paimon) fix CacheException msg in loadSnapshot (apache#52881)
d12da64 
### What problem does this PR solve?
relate pr: apache#52561
Fix CacheException msg in loadSnapshot to make
test_paimon_catalog.groovy happy
morningman pushed a commit to morningman/doris that referenced this pull request Jul 11, 2025
@suxiaogang223 @morningman
[fix](paimon) fix CacheException msg in loadSnapshot (apache#52881)
9983787 
### What problem does this PR solve?
relate pr: apache#52561
Fix CacheException msg in loadSnapshot to make
test_paimon_catalog.groovy happy
morrySnow pushed a commit that referenced this pull request Jul 11, 2025
@morningman @suxiaogang223
branch-3.1: [fix](hive) use the remote name when get meta from hive s…
250e3d7 
…ystem. #52561 #52817 #52881 #52989 (#53030)

bp (#52561)(#52817)(#52881)(#52989)

---------

Co-authored-by: Socrates <suyiteng@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@hello-stephen hello-stephen hello-stephen approved these changes

+1 more reviewer

@MoanasDaddyXu MoanasDaddyXu MoanasDaddyXu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@suxiaogang223 @hello-stephen @doris-robot @morningman @MoanasDaddyXu @morrySnow