Skip to content

branch-3.1: [feature](cloud) support event driven or periodic warm up #52370 #52538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 18 commits into from
Jul 1, 2025
Merged

branch-3.1: [feature](cloud) support event driven or periodic warm up #52370 #52538

morrySnow merged 18 commits into from
Jul 1, 2025

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented Jun 30, 2025

What problem does this PR solve?

backport #52370

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

kaijchen and others added 12 commits June 30, 2025 16:43
@kaijchen
[feature](cloud) support event driven or periodic warm up (apache#4101)
415fb30
@kaijchen
[fix](warmup) recycle_cache should also recycle index files (apache#4104
70d8f8e 
)
@kaijchen
[fix](warmup) call recycle_cache in remove_unused_rowsets (apache#4105)
a4669f0
@kaijchen
[fix](warmup) fix use-after-free
8eefb59
@kaijchen
[fix](warmup) a job should not potentially block itself
049c28b
@kaijchen
[fix](metrics) prevent NPE when processing null values
c887c5c
@kaijchen
[fix](warmup) safely remove unused rowsets and avoid RPC under lock (a…
7ec9529 
…pache#4108)

fixup 74492dcb7f6c3dd0f0f19fbc5c9ce3f568fb80d0
@kaijchen
[opt](warmup) inverted index should not be added to the index queue
19b336e
@kaijchen
[metrics](warmup) Add metric to record last call timestamp of warm_up…
a4bdb6e 
…_rowset
@kaijchen
[metrics](warmup) change timestamp to microseconds
7eb79c4
@kaijchen
fixup
319e9c3
@kaijchen
fixup
0a3f99b
@kaijchen kaijchen requested a review from morrySnow as a code owner June 30, 2025 09:40
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaijchen
Copy link
Member Author

kaijchen commented Jun 30, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 30, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 82.87% (1142/1378)
Line Coverage 66.90% (20302/30347)
Region Coverage 66.09% (9992/15118)
Branch Coverage 55.87% (5282/9454)

@kaijchen
Copy link
Member Author

kaijchen commented Jun 30, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 30, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.57% (1170/1400)
Line Coverage 67.52% (20638/30565)
Region Coverage 67.10% (10250/15276)
Branch Coverage 56.39% (5363/9510)

@kaijchen
Copy link
Member Author

kaijchen commented Jun 30, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jun 30, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.57% (1170/1400)
Line Coverage 67.59% (20660/30565)
Region Coverage 67.11% (10252/15276)
Branch Coverage 56.45% (5368/9510)

@kaijchen
Copy link
Member Author

kaijchen commented Jun 30, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jun 30, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.57% (1170/1400)
Line Coverage 67.54% (20643/30565)
Region Coverage 67.07% (10246/15276)
Branch Coverage 56.45% (5368/9510)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 30, 2025

BE UT Coverage Report

Increment line coverage 0.32% (1/311) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 44.98% (12352/27464)
Line Coverage 35.97% (109403/304118)
Region Coverage 35.04% (56698/161826)
Branch Coverage 32.16% (30751/95622)

@kaijchen
Copy link
Member Author

kaijchen commented Jun 30, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 30, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.57% (1170/1400)
Line Coverage 67.48% (20624/30565)
Region Coverage 67.07% (10245/15276)
Branch Coverage 56.35% (5359/9510)

@doris-robot
Copy link

doris-robot commented Jun 30, 2025

BE UT Coverage Report

Increment line coverage 0.32% (1/312) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 44.98% (12352/27464)
Line Coverage 35.96% (109370/304119)
Region Coverage 35.03% (56686/161826)
Branch Coverage 32.16% (30749/95622)

@gavinchou gavinchou changed the title [feature](cloud) support event driven or periodic warm up [feature](cloud) support event driven or periodic warm up #52370 Jul 1, 2025
@morrySnow morrySnow changed the title [feature](cloud) support event driven or periodic warm up #52370 branch-3.1: [feature](cloud) support event driven or periodic warm up #52370 Jul 1, 2025
@morrySnow morrySnow merged commit 23ce44a into apache:branch-3.1 Jul 1, 2025
20 of 23 checks passed
@Hastyshell Hastyshell mentioned this pull request Jul 31, 2025
Merged
16 tasks
morrySnow pushed a commit that referenced this pull request Aug 4, 2025
@Hastyshell
[fix](replica) Get tablet replica infos should return all primary bac…
c798c20 
…kends except for warmup jobs (#54132)

Fix logic conflict of #52538 and #52715
@kaijchen kaijchen mentioned this pull request Aug 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaijchen @hello-stephen @doris-robot @morrySnow