Remove unused session variables #4108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused session variables named sql_select_limit. Change-Id: I35244cd6e490638d08f86a5c08131ff3cdba80b6
wuyunfeng
reviewed
Jul 16, 2020
| queryCacheType = in.readInt(); | ||
| autoIncrementIncrement = in.readInt(); | ||
| maxAllowedPacket = in.readInt(); | ||
| sqlSelectLimit = in.readLong(); |
Member
There was a problem hiding this comment.
Maybe you should consider BWC.
morningman
reviewed
Jul 16, 2020
Contributor
morningman
left a comment
There was a problem hiding this comment.
This variable is used for compatibility for some low version mysql lib.
Better not to remove it.
Contributor
|
Should not remove. |
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Jun 26, 2025
…pache#4108) fixup 74492dcb7f6c3dd0f0f19fbc5c9ce3f568fb80d0
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Jun 26, 2025
…pache#4108) fixup 74492dcb7f6c3dd0f0f19fbc5c9ce3f568fb80d0
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Jun 30, 2025
…pache#4108) fixup 74492dcb7f6c3dd0f0f19fbc5c9ce3f568fb80d0
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Jun 30, 2025
…pache#4108) fixup 74492dcb7f6c3dd0f0f19fbc5c9ce3f568fb80d0
csun5285
pushed a commit
to csun5285/doris
that referenced
this pull request
Sep 23, 2025
…pache#4108) fixup 74492dcb7f6c3dd0f0f19fbc5c9ce3f568fb80d0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused session variables named sql_select_limit.
Change-Id: I35244cd6e490638d08f86a5c08131ff3cdba80b6