Skip to content

branch-3.1: [opt](rowset) Remote fetch rowsets to avoid -230 error when capturing rowsets #52995 #52715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinchou merged 5 commits into from
Jul 9, 2025
Merged

branch-3.1: [opt](rowset) Remote fetch rowsets to avoid -230 error when capturing rowsets #52995 #52715

gavinchou merged 5 commits into from
Jul 9, 2025

Conversation

@Hastyshell
Copy link
Collaborator

@Hastyshell Hastyshell commented Jul 3, 2025 •
edited
Loading

What problem does this PR solve?

Related: #52995

Problem Summary:

Make stale rowsets accessible across BEs to avoid E-230 (versions already merged) in Read-Write Splitting senario.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Hastyshell Hastyshell requested a review from morrySnow as a code owner July 3, 2025 07:41
@Thearas
Copy link
Contributor

Thearas commented Jul 3, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Jul 3, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 3, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.83% (1192/1422)
Line Coverage 67.91% (21035/30977)
Region Coverage 67.42% (10424/15462)
Branch Coverage 56.99% (5500/9650)

@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Jul 4, 2025

run buildall

gavinchou
gavinchou previously approved these changes Jul 4, 2025
View reviewed changes
@doris-robot
Copy link

doris-robot commented Jul 4, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.83% (1192/1422)
Line Coverage 67.93% (21042/30977)
Region Coverage 67.49% (10436/15462)
Branch Coverage 57.03% (5503/9650)

@doris-robot
Copy link

doris-robot commented Jul 4, 2025

BE UT Coverage Report

Increment line coverage 16.64% (100/601) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.10% (12409/27516)
Line Coverage 36.02% (109764/304732)
Region Coverage 35.19% (56999/161973)
Branch Coverage 32.29% (30898/95700)

@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Jul 8, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 8, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.81% (1191/1421)
Line Coverage 67.87% (21016/30965)
Region Coverage 67.44% (10432/15469)
Branch Coverage 57.00% (5505/9658)

@doris-robot
Copy link

doris-robot commented Jul 8, 2025

BE UT Coverage Report

Increment line coverage 16.64% (100/601) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.19% (12463/27579)
Line Coverage 36.15% (110503/305696)
Region Coverage 35.31% (57312/162306)
Branch Coverage 32.40% (31076/95926)

@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Jul 8, 2025

run cloud_p0

@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Jul 8, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 8, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.83% (1192/1422)
Line Coverage 67.96% (21040/30961)
Region Coverage 67.48% (10445/15478)
Branch Coverage 57.10% (5519/9666)

@doris-robot
Copy link

doris-robot commented Jul 8, 2025

BE UT Coverage Report

Increment line coverage 16.64% (100/601) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.14% (12478/27643)
Line Coverage 36.01% (110654/307313)
Region Coverage 35.19% (57365/163008)
Branch Coverage 32.26% (31094/96390)

@morrySnow
Copy link
Contributor

morrySnow commented Jul 9, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 9, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.83% (1192/1422)
Line Coverage 68.05% (21068/30961)
Region Coverage 67.50% (10448/15478)
Branch Coverage 57.09% (5518/9666)

@doris-robot
Copy link

doris-robot commented Jul 9, 2025

BE UT Coverage Report

Increment line coverage 16.64% (100/601) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.13% (12480/27651)
Line Coverage 36.00% (110667/307370)
Region Coverage 35.18% (57373/163079)
Branch Coverage 32.25% (31100/96432)

@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Jul 9, 2025

run cloud_p0

@gavinchou gavinchou changed the title [opt](rowset) Remote fetch rowsets to avoid -230 error when capturing rowsets [opt](rowset) Remote fetch rowsets to avoid -230 error when capturing rowsets #52995 Jul 9, 2025
@gavinchou gavinchou merged commit 918f6f7 into apache:branch-3.1 Jul 9, 2025
21 of 23 checks passed
@morrySnow morrySnow changed the title [opt](rowset) Remote fetch rowsets to avoid -230 error when capturing rowsets #52995 branch-3.1: [opt](rowset) Remote fetch rowsets to avoid -230 error when capturing rowsets #52995 Jul 9, 2025
@Hastyshell Hastyshell mentioned this pull request Jul 31, 2025
Merged
16 tasks
morrySnow pushed a commit that referenced this pull request Aug 4, 2025
@Hastyshell
[fix](replica) Get tablet replica infos should return all primary bac…
c798c20 
…kends except for warmup jobs (#54132)

Fix logic conflict of #52538 and #52715
@bobhan1 bobhan1 mentioned this pull request Sep 27, 2025
Merged
morrySnow pushed a commit that referenced this pull request Sep 29, 2025
@bobhan1
branch-3.1: [feature](cloud) Support query with freshness tolerance #…
f30eb3d 
…53540 #54611 (#56390)

pick #54611 and #53540, modified due to conflict with #52715

---------

Co-authored-by: zhannngchen <zhangchen@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Hastyshell @Thearas @doris-robot @hello-stephen @morrySnow @gavinchou