[Fix](timezone) Fix incorrect DST handling #51454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run performance |
Contributor
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33743 ms |
TPC-H: Total hot run time: 34422 ms |
TPC-DS: Total hot run time: 186236 ms |
ClickBench: Total hot run time: 29.98 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the incorrect handling of daylight saving time in datetime conversions by updating conversion logic, expected outputs, and regression tests. Key changes include adding new test cases for DST and non-DST scenarios, updating expected outputs in several test files, and refactoring the datetime conversion implementation for more reliable DST handling.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| regression-test/suites/datatype_p0/datetimev2/test_timezone.groovy | Added regression tests for DST and non-DST timezone conversions. |
| regression-test/data/datatype_p0/datetimev2/test_tz_streamload.out | Updated expected output timestamp for streamload tests. |
| regression-test/data/datatype_p0/datetimev2/test_timezone.out | Modified expected output for timezone tests to reflect DST adjustments. |
| regression-test/data/cast_p0/cast_to_datetime.out | Adjusted expected output timestamps in datetime cast tests. |
| be/test/vec/function/function_test_util.h | Enhanced error output for function result mismatches. |
| be/test/vec/function/cast/cast_to_datetime_test.cpp | Updated test expectations to match new timezone handling. |
| be/test/vec/function/cast/cast_to_date_test.cpp | Revised expected outputs in date cast tests to align with new timezone logic. |
| be/src/vec/runtime/vdatetime_value.h | Fixed uninitialized variable issues in datetime comparison operators. |
| be/src/vec/runtime/vdatetime_value.cpp | Refactored DST conversion logic and updated type handling for timezone offsets. |
| be/src/olap/rowset/segment_v2/inverted_index/util/priority_queue.h | Cleaned up redundant max_size validation for the priority queue. |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
zhangstar333
approved these changes
Jun 24, 2025
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Jun 27, 2025
Problem Summary:
before:
```sql
mysql> select/*+SET_VAR(debug_skip_fold_constant=true)*/ cast('2010-01-05 08:15:30Europe/London' as datetime);
+------------------------------------------------------+
| cast('2010-01-05 08:15:30Europe/London' as datetime) |
+------------------------------------------------------+
| 2010-01-05 15:15:30 |
+------------------------------------------------------+
1 row in set (0.19 sec)
```
now:
```sql
mysql> select/*+SET_VAR(debug_skip_fold_constant=true)*/ cast('2010-01-05 08:15:30Europe/London' as datetime);
+------------------------------------------------------+
| cast('2010-01-05 08:15:30Europe/London' as datetime) |
+------------------------------------------------------+
| 2010-01-05 16:15:30 |
+------------------------------------------------------+
1 row in set (0.12 sec)
```
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Jun 27, 2025
Problem Summary:
before:
```sql
mysql> select/*+SET_VAR(debug_skip_fold_constant=true)*/ cast('2010-01-05 08:15:30Europe/London' as datetime);
+------------------------------------------------------+
| cast('2010-01-05 08:15:30Europe/London' as datetime) |
+------------------------------------------------------+
| 2010-01-05 15:15:30 |
+------------------------------------------------------+
1 row in set (0.19 sec)
```
now:
```sql
mysql> select/*+SET_VAR(debug_skip_fold_constant=true)*/ cast('2010-01-05 08:15:30Europe/London' as datetime);
+------------------------------------------------------+
| cast('2010-01-05 08:15:30Europe/London' as datetime) |
+------------------------------------------------------+
| 2010-01-05 16:15:30 |
+------------------------------------------------------+
1 row in set (0.12 sec)
```
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Jun 27, 2025
Problem Summary:
before:
```sql
mysql> select/*+SET_VAR(debug_skip_fold_constant=true)*/ cast('2010-01-05 08:15:30Europe/London' as datetime);
+------------------------------------------------------+
| cast('2010-01-05 08:15:30Europe/London' as datetime) |
+------------------------------------------------------+
| 2010-01-05 15:15:30 |
+------------------------------------------------------+
1 row in set (0.19 sec)
```
now:
```sql
mysql> select/*+SET_VAR(debug_skip_fold_constant=true)*/ cast('2010-01-05 08:15:30Europe/London' as datetime);
+------------------------------------------------------+
| cast('2010-01-05 08:15:30Europe/London' as datetime) |
+------------------------------------------------------+
| 2010-01-05 16:15:30 |
+------------------------------------------------------+
1 row in set (0.12 sec)
```
This was referenced Jun 27, 2025
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Jun 27, 2025
Problem Summary:
before:
```sql
mysql> select/*+SET_VAR(debug_skip_fold_constant=true)*/ cast('2010-01-05 08:15:30Europe/London' as datetime);
+------------------------------------------------------+
| cast('2010-01-05 08:15:30Europe/London' as datetime) |
+------------------------------------------------------+
| 2010-01-05 15:15:30 |
+------------------------------------------------------+
1 row in set (0.19 sec)
```
now:
```sql
mysql> select/*+SET_VAR(debug_skip_fold_constant=true)*/ cast('2010-01-05 08:15:30Europe/London' as datetime);
+------------------------------------------------------+
| cast('2010-01-05 08:15:30Europe/London' as datetime) |
+------------------------------------------------------+
| 2010-01-05 16:15:30 |
+------------------------------------------------------+
1 row in set (0.12 sec)
```
yiguolei
pushed a commit
that referenced
this pull request
Jun 28, 2025
morrySnow
pushed a commit
that referenced
this pull request
Jun 28, 2025
dataroaring
pushed a commit
that referenced
this pull request
Jul 2, 2025
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
before:
now:
Release note
Fix incorrect daylight saving time handling
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)