Skip to content

[branch-3.0](timezone) Fix incorrect DST handling (#51454) #52421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jul 2, 2025
Merged

[branch-3.0](timezone) Fix incorrect DST handling (#51454) #52421

dataroaring merged 1 commit into from
Jul 2, 2025

Conversation

@zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Jun 27, 2025

pick #51454

@zclllyybb
[Fix](timezone) Fix incorrect DST handling (apache#51454)
a4dfcf3 
Problem Summary:

before:
```sql
mysql> select/*+SET_VAR(debug_skip_fold_constant=true)*/ cast('2010-01-05 08:15:30Europe/London' as datetime);
+------------------------------------------------------+
| cast('2010-01-05 08:15:30Europe/London' as datetime) |
+------------------------------------------------------+
| 2010-01-05 15:15:30                                  |
+------------------------------------------------------+
1 row in set (0.19 sec)
```

now:
```sql
mysql> select/*+SET_VAR(debug_skip_fold_constant=true)*/ cast('2010-01-05 08:15:30Europe/London' as datetime);
+------------------------------------------------------+
| cast('2010-01-05 08:15:30Europe/London' as datetime) |
+------------------------------------------------------+
| 2010-01-05 16:15:30                                  |
+------------------------------------------------------+
1 row in set (0.12 sec)
```
@zclllyybb zclllyybb requested a review from dataroaring as a code owner June 27, 2025 06:29
@zclllyybb
Copy link
Contributor Author

zclllyybb commented Jun 27, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jun 27, 2025

TPC-H: Total hot run time: 39805 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a4dfcf35fc0832242b82e96437ecad3d6b526bf2, data reload: false

------ Round 1 ----------------------------------
q1	17619	6792	6597	6597
q2	2070	170	181	170
q3	10688	1060	1269	1060
q4	10521	772	722	722
q5	7736	2841	2843	2841
q6	218	135	129	129
q7	965	613	597	597
q8	9345	1969	1998	1969
q9	6571	6444	6445	6444
q10	7033	2313	2309	2309
q11	484	262	264	262
q12	398	211	208	208
q13	17764	3006	2991	2991
q14	231	206	210	206
q15	511	452	459	452
q16	487	376	378	376
q17	981	591	596	591
q18	7312	6657	6702	6657
q19	1386	1111	1009	1009
q20	474	202	199	199
q21	3900	3058	3162	3058
q22	1075	958	986	958
Total cold run time: 107769 ms
Total hot run time: 39805 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6618	6553	6599	6553
q2	328	228	230	228
q3	2920	2770	2832	2770
q4	2033	1762	1730	1730
q5	5746	5765	5754	5754
q6	224	130	128	128
q7	2192	1796	1851	1796
q8	3355	3586	3531	3531
q9	9087	8769	8938	8769
q10	3579	3535	3531	3531
q11	607	505	497	497
q12	805	581	650	581
q13	10555	3146	3182	3146
q14	289	262	269	262
q15	503	470	470	470
q16	492	447	430	430
q17	1838	1630	1576	1576
q18	8291	7820	7734	7734
q19	1688	1558	1588	1558
q20	2075	1851	1789	1789
q21	5039	4984	5074	4984
q22	1113	1052	1039	1039
Total cold run time: 69377 ms
Total hot run time: 58856 ms

@doris-robot
Copy link

doris-robot commented Jun 27, 2025

TPC-DS: Total hot run time: 197619 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a4dfcf35fc0832242b82e96437ecad3d6b526bf2, data reload: false

query1	1306	918	932	918
query2	6310	1872	1871	1871
query3	10810	4260	4366	4260
query4	60019	29848	23411	23411
query5	5268	466	445	445
query6	400	170	171	170
query7	5473	306	306	306
query8	310	230	229	229
query9	8346	2600	2580	2580
query10	487	269	260	260
query11	17982	15334	15686	15334
query12	161	102	108	102
query13	1432	470	438	438
query14	11646	7782	7747	7747
query15	202	183	189	183
query16	6838	484	422	422
query17	1277	589	627	589
query18	1729	317	321	317
query19	212	172	167	167
query20	123	111	112	111
query21	205	109	105	105
query22	4594	4585	4515	4515
query23	35051	34009	33915	33915
query24	6146	2870	3000	2870
query25	542	420	441	420
query26	654	173	171	171
query27	1914	366	361	361
query28	4367	2212	2149	2149
query29	728	459	439	439
query30	231	156	158	156
query31	967	795	830	795
query32	73	53	57	53
query33	458	315	320	315
query34	941	501	521	501
query35	863	737	732	732
query36	1051	938	955	938
query37	108	65	68	65
query38	4124	4025	3966	3966
query39	1523	1480	1474	1474
query40	214	105	100	100
query41	54	44	48	44
query42	114	102	103	102
query43	536	487	486	486
query44	1197	824	821	821
query45	185	172	170	170
query46	1138	761	709	709
query47	1990	1925	1963	1925
query48	472	391	397	391
query49	727	416	396	396
query50	854	417	433	417
query51	7504	7390	7366	7366
query52	97	94	89	89
query53	259	186	190	186
query54	568	464	467	464
query55	77	78	79	78
query56	288	258	259	258
query57	1302	1243	1234	1234
query58	233	231	207	207
query59	3232	2925	2956	2925
query60	292	271	267	267
query61	117	112	161	112
query62	775	697	690	690
query63	219	186	186	186
query64	1373	681	654	654
query65	3269	3192	3229	3192
query66	654	301	294	294
query67	16095	15552	15525	15525
query68	4184	585	578	578
query69	426	263	262	262
query70	1201	1090	1097	1090
query71	334	259	257	257
query72	6355	4003	4099	4003
query73	754	350	358	350
query74	10128	9015	9369	9015
query75	3379	2638	2652	2638
query76	1992	1148	1129	1129
query77	513	281	270	270
query78	10570	9616	9552	9552
query79	1810	607	604	604
query80	1433	434	441	434
query81	515	221	218	218
query82	1147	89	86	86
query83	169	144	151	144
query84	278	76	80	76
query85	1002	304	300	300
query86	360	284	308	284
query87	4420	4261	4217	4217
query88	3919	2380	2354	2354
query89	417	289	298	289
query90	1971	185	187	185
query91	186	146	148	146
query92	66	47	50	47
query93	1889	557	559	557
query94	748	305	292	292
query95	356	268	259	259
query96	604	285	277	277
query97	3314	3126	3125	3125
query98	220	206	204	204
query99	1586	1312	1289	1289
Total cold run time: 314952 ms
Total hot run time: 197619 ms

dataroaring
dataroaring approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 6ba198b into apache:branch-3.0 Jul 2, 2025
20 of 25 checks passed
koarz pushed a commit to koarz/doris that referenced this pull request Jul 3, 2025
@zclllyybb @koarz
[branch-3.0](timezone) Fix incorrect DST handling (apache#51454) (apa…
721983e 
…che#52421)

pick apache#51454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zclllyybb @doris-robot @dataroaring