Skip to content

[branch-2.1](timezone) Fix incorrect DST handling (#51454) #52418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Jun 28, 2025
Merged

[branch-2.1](timezone) Fix incorrect DST handling (#51454) #52418

yiguolei merged 1 commit into from
Jun 28, 2025

Conversation

@zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Jun 27, 2025

pick #51454

@zclllyybb zclllyybb requested a review from yiguolei as a code owner June 27, 2025 06:28
@Thearas
Copy link
Contributor

Thearas commented Jun 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Jun 27, 2025

run buildall

@zclllyybb
[Fix](timezone) Fix incorrect DST handling (apache#51454)
dbaff0c 
Problem Summary:

before:
```sql
mysql> select/*+SET_VAR(debug_skip_fold_constant=true)*/ cast('2010-01-05 08:15:30Europe/London' as datetime);
+------------------------------------------------------+
| cast('2010-01-05 08:15:30Europe/London' as datetime) |
+------------------------------------------------------+
| 2010-01-05 15:15:30                                  |
+------------------------------------------------------+
1 row in set (0.19 sec)
```

now:
```sql
mysql> select/*+SET_VAR(debug_skip_fold_constant=true)*/ cast('2010-01-05 08:15:30Europe/London' as datetime);
+------------------------------------------------------+
| cast('2010-01-05 08:15:30Europe/London' as datetime) |
+------------------------------------------------------+
| 2010-01-05 16:15:30                                  |
+------------------------------------------------------+
1 row in set (0.12 sec)
```
@zclllyybb
Copy link
Contributor Author

zclllyybb commented Jun 27, 2025

run buildall

@yiguolei yiguolei merged commit af070ac into apache:branch-2.1 Jun 28, 2025
18 of 20 checks passed
@zclllyybb zclllyybb deleted the dst21 branch June 28, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zclllyybb @Thearas @yiguolei