[fix](Nereids) could not work well when check precision for null literal #50815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses an issue where null literals are not correctly handled when generating decimal objects by introducing a dedicated check in the precision verification logic and adding a regression test.
- Added a regression test for decimal precision computation in a Groovy suite.
- Modified the decimal precision check in SearchSignature.java to account explicitly for null literals.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| regression-test/suites/nereids_syntax_p0/decimal_percision_compute.groovy | Added a regression test suite for validating decimal precision with null literal inputs. |
| fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/SearchSignature.java | Updated the logic to handle null literals during decimal precision checks. |
Comments suppressed due to low confidence (1)
regression-test/suites/nereids_syntax_p0/decimal_percision_compute.groovy:1
- The file name contains a spelling mistake ('percision'). Consider renaming it to 'decimal_precision_compute.groovy' for clarity.
// Licensed to the Apache Software Foundation (ASF)...
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33860 ms |
TPC-DS: Total hot run time: 193113 ms |
ClickBench: Total hot run time: 29.41 s |
starocean999
approved these changes
May 13, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
924060929
approved these changes
May 14, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 14, 2025
…ral (#50815) ### What problem does this PR solve? we use Literal#stringValue to generate decimal object. however, null literal could not return valid decimal string, so we should process it specially.
github-actions bot
pushed a commit
that referenced
this pull request
May 14, 2025
…ral (#50815) ### What problem does this PR solve? we use Literal#stringValue to generate decimal object. however, null literal could not return valid decimal string, so we should process it specially.
yiguolei
pushed a commit
that referenced
this pull request
May 17, 2025
…ral (#50815) ### What problem does this PR solve? we use Literal#stringValue to generate decimal object. however, null literal could not return valid decimal string, so we should process it specially.
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…ral (apache#50815) ### What problem does this PR solve? we use Literal#stringValue to generate decimal object. however, null literal could not return valid decimal string, so we should process it specially.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
we use Literal#stringValue to generate decimal object. however, null literal could not return valid decimal string, so we should process it specially.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)