Skip to content

branch-3.0: [fix](Nereids) could not work well when check precision for null literal #50815 #50898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
May 17, 2025
Merged

branch-3.0: [fix](Nereids) could not work well when check precision for null literal #50815 #50898

dataroaring merged 1 commit into from
May 17, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented May 14, 2025

Cherry-picked from #50815

@morrySnow
[fix](Nereids) could not work well when check precision for null lite…
02967e9 
…ral (#50815)

### What problem does this PR solve?

we use Literal#stringValue to generate decimal object. however, null
literal could not return valid decimal string, so we should process it
specially.
@github-actions github-actions bot requested a review from dataroaring as a code owner May 14, 2025 08:20
@Thearas
Copy link
Contributor

Thearas commented May 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this May 14, 2025
@Thearas
Copy link
Contributor

Thearas commented May 14, 2025

run buildall

@doris-robot
Copy link

doris-robot commented May 14, 2025

TPC-H: Total hot run time: 40110 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 02967e9f8a2f3a15884cd6b27251159fdca3e398, data reload: false

------ Round 1 ----------------------------------
q1	17576	6791	7039	6791
q2	2049	160	186	160
q3	10631	1166	1188	1166
q4	10444	711	723	711
q5	7765	2897	2856	2856
q6	228	135	130	130
q7	980	617	612	612
q8	9598	1910	2009	1910
q9	8202	6384	6356	6356
q10	7032	2242	2284	2242
q11	458	269	268	268
q12	442	210	211	210
q13	17772	2952	2991	2952
q14	237	210	219	210
q15	511	474	463	463
q16	654	604	581	581
q17	1010	613	593	593
q18	7166	6805	6661	6661
q19	1405	1134	1017	1017
q20	471	206	205	205
q21	4064	3378	3037	3037
q22	1122	979	1008	979
Total cold run time: 109817 ms
Total hot run time: 40110 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6684	6619	6555	6555
q2	328	240	231	231
q3	2916	2924	3112	2924
q4	2038	1864	1780	1780
q5	5725	5695	5742	5695
q6	207	128	132	128
q7	2187	1803	1798	1798
q8	3400	3533	3520	3520
q9	8919	8774	8819	8774
q10	3570	3529	3492	3492
q11	590	478	495	478
q12	794	593	622	593
q13	5614	3219	3160	3160
q14	320	272	279	272
q15	526	474	464	464
q16	706	638	648	638
q17	1830	1586	1597	1586
q18	8021	7808	7666	7666
q19	1684	1618	1566	1566
q20	2092	1873	1880	1873
q21	5579	5261	5345	5261
q22	1080	1007	990	990
Total cold run time: 64810 ms
Total hot run time: 59444 ms

@doris-robot
Copy link

doris-robot commented May 14, 2025

TPC-DS: Total hot run time: 190100 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 02967e9f8a2f3a15884cd6b27251159fdca3e398, data reload: false

query1	952	374	373	373
query2	6510	2129	2027	2027
query3	6698	224	217	217
query4	33978	23536	23496	23496
query5	4361	459	456	456
query6	281	181	180	180
query7	4612	323	323	323
query8	288	229	219	219
query9	9550	2593	2591	2591
query10	479	265	261	261
query11	18593	15685	15227	15227
query12	154	99	102	99
query13	1656	427	404	404
query14	9825	7055	6568	6568
query15	200	171	171	171
query16	7746	448	449	448
query17	1598	560	561	560
query18	1997	318	318	318
query19	212	160	162	160
query20	117	109	108	108
query21	208	106	100	100
query22	4354	4288	4240	4240
query23	34473	33514	33262	33262
query24	11819	2827	2803	2803
query25	718	418	416	416
query26	1870	177	183	177
query27	2963	345	348	345
query28	8162	2417	2401	2401
query29	1177	440	448	440
query30	342	158	166	158
query31	1024	812	794	794
query32	103	57	61	57
query33	794	299	290	290
query34	949	508	531	508
query35	870	711	730	711
query36	1095	913	936	913
query37	276	74	72	72
query38	3979	3834	3816	3816
query39	1496	1442	1431	1431
query40	287	104	103	103
query41	55	49	52	49
query42	118	102	101	101
query43	528	505	488	488
query44	1273	802	799	799
query45	189	167	170	167
query46	1144	719	706	706
query47	1890	1808	1860	1808
query48	463	381	397	381
query49	1315	409	403	403
query50	812	414	428	414
query51	7326	7129	7087	7087
query52	105	92	90	90
query53	259	181	186	181
query54	1199	464	474	464
query55	79	79	76	76
query56	284	251	257	251
query57	1219	1104	1070	1070
query58	257	217	224	217
query59	3139	2952	2908	2908
query60	300	271	267	267
query61	139	136	129	129
query62	863	666	677	666
query63	234	194	188	188
query64	5384	694	650	650
query65	3264	3176	3178	3176
query66	1427	299	302	299
query67	16203	15456	15573	15456
query68	4476	580	596	580
query69	437	279	265	265
query70	1204	1141	1155	1141
query71	371	262	254	254
query72	6665	4063	4077	4063
query73	772	348	347	347
query74	10307	8926	9160	8926
query75	3349	2646	2657	2646
query76	2587	1224	967	967
query77	382	286	281	281
query78	10619	9706	9486	9486
query79	1229	591	590	590
query80	995	445	445	445
query81	547	237	232	232
query82	1149	96	91	91
query83	221	144	151	144
query84	233	77	83	77
query85	1296	303	292	292
query86	358	288	286	286
query87	4349	4233	4276	4233
query88	3634	2390	2366	2366
query89	408	304	291	291
query90	1908	185	182	182
query91	182	149	150	149
query92	59	50	53	50
query93	1090	556	546	546
query94	910	289	303	289
query95	355	258	257	257
query96	605	287	281	281
query97	3267	3118	3186	3118
query98	208	208	196	196
query99	1530	1295	1319	1295
Total cold run time: 301936 ms
Total hot run time: 190100 ms

@doris-robot
Copy link

doris-robot commented May 14, 2025

ClickBench: Total hot run time: 31.95 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 02967e9f8a2f3a15884cd6b27251159fdca3e398, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.02	0.03
query3	0.23	0.06	0.06
query4	1.63	0.10	0.10
query5	0.53	0.49	0.52
query6	1.14	0.73	0.73
query7	0.02	0.03	0.02
query8	0.03	0.03	0.03
query9	0.57	0.51	0.49
query10	0.54	0.55	0.56
query11	0.15	0.11	0.10
query12	0.14	0.11	0.11
query13	0.60	0.59	0.60
query14	2.85	2.74	2.81
query15	0.88	0.83	0.83
query16	0.38	0.38	0.38
query17	0.99	1.04	1.03
query18	0.24	0.22	0.22
query19	1.88	1.89	2.00
query20	0.01	0.01	0.01
query21	15.35	0.60	0.59
query22	2.74	2.41	1.87
query23	17.28	0.82	0.86
query24	2.92	1.37	0.59
query25	0.21	0.17	0.13
query26	0.34	0.14	0.13
query27	0.05	0.04	0.04
query28	10.66	0.54	0.46
query29	12.59	3.22	3.22
query30	0.27	0.07	0.06
query31	2.84	0.39	0.39
query32	3.22	0.46	0.46
query33	2.97	2.98	3.02
query34	16.82	4.48	4.47
query35	4.48	4.55	4.56
query36	0.66	0.48	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.04	0.02	0.03
query40	0.16	0.12	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.82 s
Total hot run time: 31.95 s

dataroaring
dataroaring approved these changes May 17, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit b7b4a27 into branch-3.0 May 17, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-50815-branch-3.0 branch May 17, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @doris-robot @dataroaring @morrySnow