Skip to content

branch-2.1: [fix](Nereids) could not work well when check precision for null literal #50815 #50899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
May 22, 2025
Merged

branch-2.1: [fix](Nereids) could not work well when check precision for null literal #50815 #50899

yiguolei merged 1 commit into from
May 22, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented May 14, 2025

Cherry-picked from #50815

@github-actions github-actions bot requested a review from yiguolei as a code owner May 14, 2025 08:21
@hello-stephen
Copy link
Contributor

hello-stephen commented May 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this May 14, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented May 14, 2025

run buildall

@morrySnow @yiguolei
[fix](Nereids) could not work well when check precision for null lite…
aa8a309 
…ral (#50815)

### What problem does this PR solve?

we use Literal#stringValue to generate decimal object. however, null
literal could not return valid decimal string, so we should process it
specially.
@yiguolei yiguolei force-pushed the auto-pick-50815-branch-2.1 branch from 4f7cef2 to aa8a309 Compare May 17, 2025 09:17
@yiguolei
Copy link
Contributor

yiguolei commented May 17, 2025

run buildall

@github-actions
Copy link
Contributor Author

github-actions bot commented May 22, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 22, 2025
@yiguolei yiguolei merged commit 5bc1618 into branch-2.1 May 22, 2025
22 of 24 checks passed
@github-actions
Copy link
Contributor Author

github-actions bot commented May 22, 2025

PR approved by anyone and no changes requested.

@github-actions github-actions bot deleted the auto-pick-50815-branch-2.1 branch May 22, 2025 06:38
@yiguolei yiguolei mentioned this pull request Aug 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @yiguolei @dataroaring @morrySnow