[refactor](fe) Merge MasterOpExecutor and FEOpExecutor #50776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33780 ms |
TPC-DS: Total hot run time: 191426 ms |
ClickBench: Total hot run time: 28.71 s |
16 tasks
suxiaogang223
approved these changes
May 12, 2025
CalvinKirs
approved these changes
May 12, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morningman
added a commit
that referenced
this pull request
May 26, 2025
…50791) ### What problem does this PR solve? Related PR: #50776, #46882 Problem Summary: 1. Fix bug that `KILL connection_id` is not supported in Nereids This PR #46882 implements `KILL` in Nereids, but it miss the grammar `KILL connection_id` and treat it as `KILL query_id`. This PR fix it. 2. Unify the core code of `KILL` operation in both old and new planner All core logic about `kill` are moved to `KillUtils` class. So that both old and new planner and can have same logic. 3. Support Kill query by query id from all FE Previously, when executing `kill query query_id;`, Doris will only find query id in current FE. If not found, Doris will send the cancel request to all Backends to try cancelling this query. In this PR, I changed the logic. Doris will first find query id in current FE, if not found, this `kill` command will be forwarded to all other Frontends to then find it in other FEs. And Doris will no longer send the cancel request to Backend. 4. Support Kill query by trace id from all FE User can set a custom `trace id` by `set session_context="trace_id:your_trace_id"`. And this trace id will be bind to the subsequent queries in this connection. Then user can cancel the query by trace id: `KILL QUERY "trace_id"` More details can be found in user doc: apache/doris-website#2371
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
### What problem does this PR solve? Related PR: apache#34685 Problem Summary: This PR apache#34685 introduced `FEOpExecutor`, which is just a copy of `MasterOpExecutor`. Both class are used to forwarding request to a specific FE node, and there are lots of duplicate code. So I refactor the code to let `MasterOpExecutor` extends from `FEOpExecutor`. No logic being changed in this PR.
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…pache#50791) ### What problem does this PR solve? Related PR: apache#50776, apache#46882 Problem Summary: 1. Fix bug that `KILL connection_id` is not supported in Nereids This PR apache#46882 implements `KILL` in Nereids, but it miss the grammar `KILL connection_id` and treat it as `KILL query_id`. This PR fix it. 2. Unify the core code of `KILL` operation in both old and new planner All core logic about `kill` are moved to `KillUtils` class. So that both old and new planner and can have same logic. 3. Support Kill query by query id from all FE Previously, when executing `kill query query_id;`, Doris will only find query id in current FE. If not found, Doris will send the cancel request to all Backends to try cancelling this query. In this PR, I changed the logic. Doris will first find query id in current FE, if not found, this `kill` command will be forwarded to all other Frontends to then find it in other FEs. And Doris will no longer send the cancel request to Backend. 4. Support Kill query by trace id from all FE User can set a custom `trace id` by `set session_context="trace_id:your_trace_id"`. And this trace id will be bind to the subsequent queries in this connection. Then user can cancel the query by trace id: `KILL QUERY "trace_id"` More details can be found in user doc: apache/doris-website#2371
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jun 19, 2025
Related PR: apache#34685 Problem Summary: This PR apache#34685 introduced `FEOpExecutor`, which is just a copy of `MasterOpExecutor`. Both class are used to forwarding request to a specific FE node, and there are lots of duplicate code. So I refactor the code to let `MasterOpExecutor` extends from `FEOpExecutor`. No logic being changed in this PR.
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jun 20, 2025
Related PR: apache#34685 Problem Summary: This PR apache#34685 introduced `FEOpExecutor`, which is just a copy of `MasterOpExecutor`. Both class are used to forwarding request to a specific FE node, and there are lots of duplicate code. So I refactor the code to let `MasterOpExecutor` extends from `FEOpExecutor`. No logic being changed in this PR.
morrySnow
pushed a commit
that referenced
this pull request
Jun 20, 2025
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jun 24, 2025
…pache#50791) Related PR: apache#50776, apache#46882 Problem Summary: 1. Fix bug that `KILL connection_id` is not supported in Nereids This PR apache#46882 implements `KILL` in Nereids, but it miss the grammar `KILL connection_id` and treat it as `KILL query_id`. This PR fix it. 2. Unify the core code of `KILL` operation in both old and new planner All core logic about `kill` are moved to `KillUtils` class. So that both old and new planner and can have same logic. 3. Support Kill query by query id from all FE Previously, when executing `kill query query_id;`, Doris will only find query id in current FE. If not found, Doris will send the cancel request to all Backends to try cancelling this query. In this PR, I changed the logic. Doris will first find query id in current FE, if not found, this `kill` command will be forwarded to all other Frontends to then find it in other FEs. And Doris will no longer send the cancel request to Backend. 4. Support Kill query by trace id from all FE User can set a custom `trace id` by `set session_context="trace_id:your_trace_id"`. And this trace id will be bind to the subsequent queries in this connection. Then user can cancel the query by trace id: `KILL QUERY "trace_id"` More details can be found in user doc: apache/doris-website#2371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #34685
Problem Summary:
This PR #34685 introduced
FEOpExecutor, which is just a copy ofMasterOpExecutor.Both class are used to forwarding request to a specific FE node, and there are lots of duplicate code.
So I refactor the code to let
MasterOpExecutorextends fromFEOpExecutor.No logic being changed in this PR.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)