-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Improvement](set) enable admin_set_frontend_config can apply to all fe #34685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
run buildall |
lide-reed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
nextdreamblue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
### What problem does this PR solve? Related PR: #34685 Problem Summary: This PR #34685 introduced `FEOpExecutor`, which is just a copy of `MasterOpExecutor`. Both class are used to forwarding request to a specific FE node, and there are lots of duplicate code. So I refactor the code to let `MasterOpExecutor` extends from `FEOpExecutor`. No logic being changed in this PR.
### What problem does this PR solve? Related PR: apache#34685 Problem Summary: This PR apache#34685 introduced `FEOpExecutor`, which is just a copy of `MasterOpExecutor`. Both class are used to forwarding request to a specific FE node, and there are lots of duplicate code. So I refactor the code to let `MasterOpExecutor` extends from `FEOpExecutor`. No logic being changed in this PR.
Related PR: apache#34685 Problem Summary: This PR apache#34685 introduced `FEOpExecutor`, which is just a copy of `MasterOpExecutor`. Both class are used to forwarding request to a specific FE node, and there are lots of duplicate code. So I refactor the code to let `MasterOpExecutor` extends from `FEOpExecutor`. No logic being changed in this PR.
Related PR: apache#34685 Problem Summary: This PR apache#34685 introduced `FEOpExecutor`, which is just a copy of `MasterOpExecutor`. Both class are used to forwarding request to a specific FE node, and there are lots of duplicate code. So I refactor the code to let `MasterOpExecutor` extends from `FEOpExecutor`. No logic being changed in this PR.
Proposed changes
Currently, admin_set_frontend_config only apply to the connected fe, now enable it can be apply to all fe


Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...