Skip to content

Conversation

@Yulei-Yang
Copy link
Contributor

@Yulei-Yang Yulei-Yang commented May 11, 2024

Proposed changes

Currently, admin_set_frontend_config only apply to the connected fe, now enable it can be apply to all fe
image
image

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Yulei-Yang
Copy link
Contributor Author

run buildall

@Yulei-Yang
Copy link
Contributor Author

run buildall

Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 13, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@nextdreamblue nextdreamblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lide-reed lide-reed merged commit e12b200 into apache:master May 13, 2024
@Yulei-Yang Yulei-Yang deleted the admin_set_all branch May 13, 2024 04:12
ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
morningman added a commit that referenced this pull request May 12, 2025
### What problem does this PR solve?

Related PR: #34685

Problem Summary:

This PR #34685 introduced `FEOpExecutor`, which is just a copy of
`MasterOpExecutor`.
Both class are used to forwarding request to a specific FE node, and
there are lots of duplicate code.
So I refactor the code to let `MasterOpExecutor` extends from
`FEOpExecutor`.

No logic being changed in this PR.
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
### What problem does this PR solve?

Related PR: apache#34685

Problem Summary:

This PR apache#34685 introduced `FEOpExecutor`, which is just a copy of
`MasterOpExecutor`.
Both class are used to forwarding request to a specific FE node, and
there are lots of duplicate code.
So I refactor the code to let `MasterOpExecutor` extends from
`FEOpExecutor`.

No logic being changed in this PR.
morningman added a commit to morningman/doris that referenced this pull request Jun 19, 2025
Related PR: apache#34685

Problem Summary:

This PR apache#34685 introduced `FEOpExecutor`, which is just a copy of
`MasterOpExecutor`.
Both class are used to forwarding request to a specific FE node, and
there are lots of duplicate code.
So I refactor the code to let `MasterOpExecutor` extends from
`FEOpExecutor`.

No logic being changed in this PR.
morningman added a commit to morningman/doris that referenced this pull request Jun 20, 2025
Related PR: apache#34685

Problem Summary:

This PR apache#34685 introduced `FEOpExecutor`, which is just a copy of
`MasterOpExecutor`.
Both class are used to forwarding request to a specific FE node, and
there are lots of duplicate code.
So I refactor the code to let `MasterOpExecutor` extends from
`FEOpExecutor`.

No logic being changed in this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants