Skip to content

[Enhancement] (nereids)implement kill connection and query command in nereids #46882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
starocean999 merged 26 commits into from
Apr 3, 2025
Merged

[Enhancement] (nereids)implement kill connection and query command in nereids #46882

starocean999 merged 26 commits into from
Apr 3, 2025

Conversation

@yx-keith
Copy link
Contributor

@yx-keith yx-keith commented Jan 13, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #42532,#42533

Related PR: NO

Problem Summary: implement kill connection and query command in nereids

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yx-keith
Copy link
Contributor Author

yx-keith commented Jan 13, 2025 •
edited
Loading

kill connection command:
image

kill query command:
image

@yx-keith
Copy link
Contributor Author

yx-keith commented Jan 13, 2025

run p0

@yx-keith
Copy link
Contributor Author

yx-keith commented Jan 13, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jan 13, 2025

TPC-H: Total hot run time: 33008 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 43e23ee0d54ece3b36cb66425e6be67026680a19, data reload: false

------ Round 1 ----------------------------------
q1	17579	6202	6083	6083
q2	2047	312	204	204
q3	10377	1231	759	759
q4	10232	867	435	435
q5	7865	2209	1997	1997
q6	206	180	150	150
q7	896	744	616	616
q8	9251	1374	1153	1153
q9	5329	4907	4846	4846
q10	7001	2261	1854	1854
q11	488	280	252	252
q12	359	400	233	233
q13	17979	3751	3351	3351
q14	245	249	221	221
q15	557	510	497	497
q16	626	618	587	587
q17	595	866	349	349
q18	6941	6451	6388	6388
q19	2459	957	570	570
q20	298	318	191	191
q21	3030	2208	1957	1957
q22	358	335	315	315
Total cold run time: 104718 ms
Total hot run time: 33008 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6421	6306	6217	6217
q2	241	334	237	237
q3	2270	2707	2336	2336
q4	1390	1887	1346	1346
q5	4341	4770	4941	4770
q6	186	176	141	141
q7	2047	1950	1810	1810
q8	2610	2854	2714	2714
q9	7278	7233	7208	7208
q10	3075	3315	2748	2748
q11	596	525	497	497
q12	726	796	625	625
q13	3600	3970	3286	3286
q14	303	321	276	276
q15	561	507	518	507
q16	636	696	650	650
q17	1241	1730	1254	1254
q18	7778	7482	7231	7231
q19	866	981	1213	981
q20	1962	2044	1918	1918
q21	5684	5104	5117	5104
q22	638	637	638	637
Total cold run time: 54450 ms
Total hot run time: 52493 ms

@doris-robot
Copy link

doris-robot commented Jan 13, 2025

TPC-DS: Total hot run time: 195284 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 43e23ee0d54ece3b36cb66425e6be67026680a19, data reload: false

query1	1326	976	935	935
query2	6328	2361	2447	2361
query3	10976	4604	4840	4604
query4	33232	23960	23387	23387
query5	4724	582	461	461
query6	276	193	179	179
query7	3993	490	318	318
query8	307	246	230	230
query9	9196	2694	2669	2669
query10	483	305	253	253
query11	18133	15330	15065	15065
query12	163	116	100	100
query13	1546	515	379	379
query14	9803	7572	7552	7552
query15	241	212	205	205
query16	8205	616	449	449
query17	1594	779	610	610
query18	2079	442	318	318
query19	216	223	167	167
query20	122	120	118	118
query21	205	125	105	105
query22	4411	4643	4357	4357
query23	34300	33485	33374	33374
query24	6445	2347	2323	2323
query25	490	450	371	371
query26	819	285	161	161
query27	2262	479	340	340
query28	5642	2486	2448	2448
query29	586	558	436	436
query30	220	189	157	157
query31	973	906	820	820
query32	73	61	63	61
query33	494	376	331	331
query34	787	862	513	513
query35	786	852	723	723
query36	1035	1044	965	965
query37	123	96	77	77
query38	4165	4156	4072	4072
query39	1530	1481	1428	1428
query40	203	113	99	99
query41	51	83	52	52
query42	131	110	104	104
query43	513	514	505	505
query44	1370	828	830	828
query45	180	185	170	170
query46	861	1066	666	666
query47	1891	1904	1840	1840
query48	380	408	325	325
query49	723	519	399	399
query50	648	667	388	388
query51	7021	7087	6912	6912
query52	107	98	93	93
query53	223	249	181	181
query54	488	538	418	418
query55	81	84	80	80
query56	267	263	240	240
query57	1243	1198	1164	1164
query58	258	233	271	233
query59	3163	3340	3080	3080
query60	300	282	274	274
query61	141	159	147	147
query62	833	810	756	756
query63	230	191	193	191
query64	3128	1029	655	655
query65	3304	3197	3228	3197
query66	783	442	299	299
query67	16424	15750	15354	15354
query68	8059	697	518	518
query69	485	293	263	263
query70	1212	1132	1178	1132
query71	433	286	260	260
query72	6239	3886	3867	3867
query73	666	741	345	345
query74	10055	9071	8933	8933
query75	4076	3139	2652	2652
query76	3676	1175	773	773
query77	774	382	277	277
query78	10195	10133	9253	9253
query79	3241	786	580	580
query80	616	521	437	437
query81	482	280	240	240
query82	655	152	113	113
query83	164	183	150	150
query84	238	91	77	77
query85	776	338	301	301
query86	366	322	305	305
query87	4498	4465	4221	4221
query88	4668	2154	2140	2140
query89	414	330	290	290
query90	1890	191	187	187
query91	142	132	106	106
query92	62	58	53	53
query93	1789	872	530	530
query94	640	385	279	279
query95	335	264	247	247
query96	485	612	291	291
query97	2853	2944	2820	2820
query98	221	202	197	197
query99	1742	1482	1375	1375
Total cold run time: 295381 ms
Total hot run time: 195284 ms

@doris-robot
Copy link

doris-robot commented Jan 13, 2025

ClickBench: Total hot run time: 31.18 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 43e23ee0d54ece3b36cb66425e6be67026680a19, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.04
query3	0.23	0.07	0.07
query4	1.62	0.11	0.10
query5	0.43	0.41	0.41
query6	1.14	0.64	0.65
query7	0.02	0.02	0.02
query8	0.03	0.04	0.03
query9	0.58	0.49	0.50
query10	0.53	0.57	0.55
query11	0.14	0.11	0.10
query12	0.14	0.11	0.11
query13	0.60	0.61	0.59
query14	2.73	2.74	2.83
query15	0.90	0.83	0.83
query16	0.38	0.37	0.39
query17	1.04	1.03	1.03
query18	0.22	0.21	0.20
query19	1.96	1.88	2.02
query20	0.02	0.01	0.02
query21	15.36	0.95	0.60
query22	0.75	0.86	0.64
query23	15.24	1.41	0.58
query24	3.46	1.30	0.85
query25	0.33	0.19	0.18
query26	0.23	0.14	0.13
query27	0.06	0.04	0.04
query28	13.73	1.49	1.05
query29	12.61	4.01	3.28
query30	0.25	0.10	0.06
query31	2.84	0.59	0.38
query32	3.23	0.56	0.45
query33	3.21	3.03	3.24
query34	16.89	5.09	4.45
query35	4.51	4.43	4.46
query36	0.65	0.49	0.49
query37	0.10	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.03	0.02
query40	0.17	0.14	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 106.66 s
Total hot run time: 31.18 s

@doris-robot
Copy link

doris-robot commented Jan 13, 2025

TPC-H: Total hot run time: 32414 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 43e23ee0d54ece3b36cb66425e6be67026680a19, data reload: false

------ Round 1 ----------------------------------
q1	17652	6093	6000	6000
q2	2059	310	167	167
q3	10419	1225	685	685
q4	10204	848	439	439
q5	7523	2134	1920	1920
q6	203	179	146	146
q7	882	752	603	603
q8	9238	1351	1075	1075
q9	5135	4860	4879	4860
q10	6751	2278	1879	1879
q11	477	267	261	261
q12	348	354	223	223
q13	17770	3644	2975	2975
q14	233	231	211	211
q15	552	492	490	490
q16	637	635	576	576
q17	559	839	338	338
q18	7377	6513	6548	6513
q19	1849	944	548	548
q20	313	315	189	189
q21	2805	2220	2007	2007
q22	370	333	309	309
Total cold run time: 103356 ms
Total hot run time: 32414 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6208	6206	6187	6187
q2	240	334	240	240
q3	2243	2675	2315	2315
q4	1420	1813	1439	1439
q5	4347	4760	4731	4731
q6	183	176	142	142
q7	2096	1973	1829	1829
q8	2608	2783	2655	2655
q9	7241	7221	7218	7218
q10	3004	3306	2804	2804
q11	597	528	498	498
q12	653	787	617	617
q13	3495	3912	3223	3223
q14	275	287	292	287
q15	564	512	516	512
q16	628	698	647	647
q17	1203	1722	1260	1260
q18	7753	7649	7062	7062
q19	757	993	1075	993
q20	1915	1928	1823	1823
q21	5452	4974	4837	4837
q22	589	595	576	576
Total cold run time: 53471 ms
Total hot run time: 51895 ms

@doris-robot
Copy link

doris-robot commented Jan 13, 2025

TPC-DS: Total hot run time: 187723 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 43e23ee0d54ece3b36cb66425e6be67026680a19, data reload: false

query1	985	373	365	365
query2	6517	2269	2287	2269
query3	6706	219	214	214
query4	33485	23430	23208	23208
query5	4302	620	451	451
query6	300	190	185	185
query7	4620	498	301	301
query8	284	226	219	219
query9	9451	2661	2663	2661
query10	474	315	247	247
query11	18599	15350	15414	15350
query12	166	107	103	103
query13	1637	500	383	383
query14	9979	7791	6990	6990
query15	228	202	198	198
query16	7301	582	450	450
query17	1543	699	544	544
query18	1218	369	299	299
query19	220	184	148	148
query20	113	111	113	111
query21	205	121	105	105
query22	4094	4444	4245	4245
query23	33973	32571	33728	32571
query24	6366	2232	2253	2232
query25	450	438	377	377
query26	1085	263	159	159
query27	1979	447	338	338
query28	4977	2409	2371	2371
query29	501	531	407	407
query30	229	190	155	155
query31	988	860	794	794
query32	72	59	56	56
query33	510	366	297	297
query34	747	849	492	492
query35	812	816	728	728
query36	983	1051	911	911
query37	133	104	79	79
query38	4009	4124	3984	3984
query39	1453	1424	1421	1421
query40	213	115	105	105
query41	58	60	57	57
query42	117	104	115	104
query43	526	527	493	493
query44	1281	812	811	811
query45	183	170	169	169
query46	852	1023	637	637
query47	1828	1820	1770	1770
query48	391	387	309	309
query49	779	476	406	406
query50	609	667	388	388
query51	6873	6857	6768	6768
query52	104	98	91	91
query53	233	270	182	182
query54	476	481	415	415
query55	82	79	85	79
query56	253	260	249	249
query57	1148	1163	1098	1098
query58	238	235	234	234
query59	3186	3093	3022	3022
query60	277	273	248	248
query61	119	118	114	114
query62	881	763	712	712
query63	223	194	189	189
query64	4185	1010	646	646
query65	3245	3150	3141	3141
query66	1055	413	322	322
query67	15836	15685	15264	15264
query68	8143	718	530	530
query69	476	287	258	258
query70	1235	1131	1119	1119
query71	445	284	250	250
query72	6161	3819	3766	3766
query73	671	748	355	355
query74	10552	9150	9098	9098
query75	4485	3190	2640	2640
query76	4030	1158	777	777
query77	781	360	272	272
query78	11084	9919	9370	9370
query79	3236	782	577	577
query80	664	550	436	436
query81	467	276	239	239
query82	615	148	120	120
query83	170	171	151	151
query84	234	90	74	74
query85	776	368	298	298
query86	348	330	289	289
query87	4621	4719	4204	4204
query88	4424	2155	2121	2121
query89	403	308	317	308
query90	1901	185	195	185
query91	134	140	108	108
query92	72	57	54	54
query93	1032	710	533	533
query94	655	397	286	286
query95	333	261	255	255
query96	478	602	273	273
query97	2817	2912	2762	2762
query98	229	204	190	190
query99	1597	1469	1384	1384
Total cold run time: 290214 ms
Total hot run time: 187723 ms

@doris-robot
Copy link

doris-robot commented Jan 13, 2025

ClickBench: Total hot run time: 30.95 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 43e23ee0d54ece3b36cb66425e6be67026680a19, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.61	0.11	0.11
query5	0.44	0.42	0.40
query6	1.15	0.68	0.65
query7	0.03	0.02	0.02
query8	0.03	0.03	0.03
query9	0.58	0.50	0.50
query10	0.55	0.57	0.54
query11	0.14	0.11	0.10
query12	0.13	0.11	0.12
query13	0.61	0.62	0.59
query14	2.83	2.86	2.74
query15	0.90	0.82	0.83
query16	0.38	0.38	0.37
query17	1.03	1.02	1.04
query18	0.24	0.22	0.21
query19	1.92	2.05	1.88
query20	0.02	0.01	0.02
query21	15.36	1.02	0.59
query22	0.76	0.69	0.73
query23	15.33	1.40	0.57
query24	3.08	1.20	0.48
query25	0.11	0.10	0.08
query26	0.44	0.15	0.14
query27	0.05	0.06	0.06
query28	13.36	1.56	1.05
query29	12.56	4.12	3.41
query30	0.25	0.09	0.06
query31	2.82	0.58	0.38
query32	3.22	0.54	0.46
query33	3.10	3.09	3.17
query34	16.89	5.09	4.41
query35	4.53	4.46	4.46
query36	0.83	0.49	0.50
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.04	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.11 s
Total hot run time: 30.95 s

@yx-keith
Copy link
Contributor Author

yx-keith commented Jan 14, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jan 14, 2025

TPC-H: Total hot run time: 32433 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 43e23ee0d54ece3b36cb66425e6be67026680a19, data reload: false

------ Round 1 ----------------------------------
q1	17571	6162	6022	6022
q2	2045	308	181	181
q3	10410	1190	748	748
q4	10444	858	431	431
q5	7539	2246	1996	1996
q6	201	180	149	149
q7	892	772	594	594
q8	9456	1367	1187	1187
q9	5308	4972	4928	4928
q10	6761	2316	1853	1853
q11	481	285	256	256
q12	349	362	213	213
q13	17789	3614	3057	3057
q14	242	233	208	208
q15	554	508	512	508
q16	615	639	584	584
q17	550	841	330	330
q18	6811	6230	6365	6230
q19	2234	959	536	536
q20	295	311	180	180
q21	2780	2194	1945	1945
q22	362	330	297	297
Total cold run time: 103689 ms
Total hot run time: 32433 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6289	6251	6210	6210
q2	239	324	231	231
q3	2223	2651	2327	2327
q4	1372	1795	1343	1343
q5	4325	4769	4729	4729
q6	187	179	144	144
q7	2067	1923	1801	1801
q8	2637	2830	2700	2700
q9	7313	7268	7366	7268
q10	3058	3316	2719	2719
q11	577	531	514	514
q12	683	763	625	625
q13	3478	3804	3203	3203
q14	297	305	280	280
q15	575	532	504	504
q16	657	691	649	649
q17	1235	1739	1256	1256
q18	7702	7354	7370	7354
q19	785	1094	1114	1094
q20	2020	2064	1897	1897
q21	5721	5097	5046	5046
q22	625	621	573	573
Total cold run time: 54065 ms
Total hot run time: 52467 ms

@doris-robot
Copy link

doris-robot commented Jan 14, 2025

TPC-DS: Total hot run time: 194500 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 43e23ee0d54ece3b36cb66425e6be67026680a19, data reload: false

query1	1251	1004	951	951
query2	5966	2353	2318	2318
query3	11362	4967	4864	4864
query4	33153	23918	23573	23573
query5	5158	665	453	453
query6	309	189	185	185
query7	3976	488	300	300
query8	286	227	213	213
query9	9249	2680	2669	2669
query10	495	318	247	247
query11	17997	15147	15056	15056
query12	152	109	111	109
query13	1565	502	394	394
query14	10515	6525	7164	6525
query15	238	224	187	187
query16	7806	615	465	465
query17	1427	812	592	592
query18	2117	440	331	331
query19	221	194	181	181
query20	126	117	119	117
query21	215	128	107	107
query22	4583	4532	4737	4532
query23	34183	33165	33478	33165
query24	6396	2360	2375	2360
query25	489	468	387	387
query26	875	272	162	162
query27	2061	471	329	329
query28	5248	2465	2414	2414
query29	576	551	430	430
query30	219	194	156	156
query31	958	918	811	811
query32	69	57	59	57
query33	524	356	298	298
query34	749	873	510	510
query35	843	829	754	754
query36	1012	1011	974	974
query37	127	101	78	78
query38	4053	4093	4096	4093
query39	1549	1496	1452	1452
query40	205	118	105	105
query41	52	56	54	54
query42	129	99	102	99
query43	526	536	511	511
query44	1375	836	828	828
query45	190	177	175	175
query46	868	1053	651	651
query47	1905	1906	1902	1902
query48	377	414	340	340
query49	756	488	382	382
query50	660	676	400	400
query51	6976	6971	6825	6825
query52	103	102	89	89
query53	223	258	195	195
query54	495	506	420	420
query55	81	83	81	81
query56	274	259	245	245
query57	1216	1232	1140	1140
query58	244	244	234	234
query59	3217	3366	2972	2972
query60	276	270	253	253
query61	123	111	116	111
query62	879	772	734	734
query63	214	190	185	185
query64	3033	1023	642	642
query65	3285	3198	3188	3188
query66	965	413	307	307
query67	15945	15870	15468	15468
query68	7682	699	516	516
query69	496	287	255	255
query70	1180	1147	1114	1114
query71	464	310	258	258
query72	6437	3888	3879	3879
query73	638	746	353	353
query74	10395	8863	8567	8567
query75	4250	3153	2639	2639
query76	3887	1217	771	771
query77	800	378	287	287
query78	10089	9875	9322	9322
query79	3779	797	584	584
query80	742	536	443	443
query81	503	291	237	237
query82	678	157	122	122
query83	176	166	162	162
query84	261	97	91	91
query85	809	343	299	299
query86	364	318	303	303
query87	4369	4518	4451	4451
query88	5016	2158	2129	2129
query89	421	327	282	282
query90	1896	193	188	188
query91	134	135	110	110
query92	68	55	54	54
query93	2232	864	525	525
query94	649	381	289	289
query95	340	262	252	252
query96	486	616	288	288
query97	2900	2948	2830	2830
query98	219	209	199	199
query99	1624	1458	1366	1366
Total cold run time: 296674 ms
Total hot run time: 194500 ms

@doris-robot
Copy link

doris-robot commented Jan 14, 2025

ClickBench: Total hot run time: 31.68 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 43e23ee0d54ece3b36cb66425e6be67026680a19, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.04	0.04
query3	0.24	0.06	0.07
query4	1.61	0.11	0.10
query5	0.40	0.42	0.42
query6	1.17	0.64	0.65
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.60	0.50	0.49
query10	0.55	0.56	0.56
query11	0.14	0.10	0.11
query12	0.14	0.11	0.11
query13	0.60	0.59	0.60
query14	2.85	2.70	2.75
query15	0.92	0.84	0.83
query16	0.40	0.38	0.38
query17	1.09	1.07	0.98
query18	0.24	0.22	0.21
query19	1.83	1.87	2.02
query20	0.02	0.00	0.02
query21	15.36	0.91	0.60
query22	0.75	0.80	0.59
query23	15.30	1.48	0.56
query24	3.33	1.26	1.57
query25	0.16	0.19	0.06
query26	0.28	0.15	0.13
query27	0.05	0.06	0.05
query28	14.16	1.50	1.05
query29	12.65	4.09	3.42
query30	0.25	0.09	0.06
query31	2.82	0.61	0.39
query32	3.29	0.55	0.47
query33	3.05	3.08	3.10
query34	16.87	5.10	4.52
query35	4.52	4.50	4.52
query36	0.79	0.49	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.02
query40	0.18	0.12	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.02	0.03
Total cold run time: 107.1 s
Total hot run time: 31.68 s

@yx-keith
Copy link
Contributor Author

yx-keith commented Jan 14, 2025

run buildall

@yx-keith
Copy link
Contributor Author

yx-keith commented Jan 14, 2025

@hello-stephen hi can you help to review this?

@yx-keith
Copy link
Contributor Author

yx-keith commented Jan 15, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jan 15, 2025

TPC-H: Total hot run time: 32629 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 645d63fb1c5c7b328737cbadf7624e7d63d4b7d1, data reload: false

------ Round 1 ----------------------------------
q1	17575	6113	6034	6034
q2	2050	309	193	193
q3	10392	1201	747	747
q4	10227	873	445	445
q5	8298	2187	1981	1981
q6	210	177	148	148
q7	885	749	600	600
q8	9244	1364	1149	1149
q9	5159	4889	4891	4889
q10	6731	2296	1836	1836
q11	477	275	258	258
q12	341	358	220	220
q13	17771	3669	3049	3049
q14	233	225	219	219
q15	578	533	521	521
q16	644	648	576	576
q17	573	868	325	325
q18	6823	6454	6424	6424
q19	1901	955	553	553
q20	317	322	180	180
q21	2804	2153	1976	1976
q22	361	340	306	306
Total cold run time: 103594 ms
Total hot run time: 32629 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6275	6269	6224	6224
q2	244	328	246	246
q3	2334	2720	2399	2399
q4	1411	1862	1355	1355
q5	4434	4820	4868	4820
q6	185	180	139	139
q7	2108	1957	1825	1825
q8	2601	2863	2718	2718
q9	7297	7226	7286	7226
q10	3055	3261	2737	2737
q11	604	538	494	494
q12	716	757	636	636
q13	3539	3899	3266	3266
q14	290	298	294	294
q15	583	547	517	517
q16	655	692	627	627
q17	1228	1725	1260	1260
q18	7674	7502	7570	7502
q19	798	1169	1055	1055
q20	1982	2029	1876	1876
q21	5531	5105	5028	5028
q22	644	615	562	562
Total cold run time: 54188 ms
Total hot run time: 52806 ms

@doris-robot
Copy link

doris-robot commented Jan 15, 2025

TPC-DS: Total hot run time: 195632 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 645d63fb1c5c7b328737cbadf7624e7d63d4b7d1, data reload: false

query1	1296	947	924	924
query2	6424	2033	2023	2023
query3	11120	4624	4603	4603
query4	61520	34829	23634	23634
query5	5453	621	439	439
query6	346	192	178	178
query7	5022	503	318	318
query8	309	243	225	225
query9	6577	2755	2745	2745
query10	416	311	269	269
query11	15807	15285	15717	15285
query12	164	109	107	107
query13	1026	573	431	431
query14	10179	7107	7898	7107
query15	219	199	192	192
query16	6663	680	498	498
query17	1086	724	561	561
query18	1096	381	303	303
query19	221	183	155	155
query20	114	117	113	113
query21	230	120	104	104
query22	4463	4661	4440	4440
query23	34120	33649	33650	33649
query24	5670	2328	2352	2328
query25	467	452	401	401
query26	648	279	155	155
query27	1770	487	333	333
query28	4013	2496	2480	2480
query29	537	551	427	427
query30	217	198	164	164
query31	926	888	816	816
query32	73	60	58	58
query33	461	357	300	300
query34	743	885	519	519
query35	787	845	764	764
query36	1000	1037	942	942
query37	125	96	82	82
query38	4270	4323	4273	4273
query39	1535	1446	1485	1446
query40	203	115	106	106
query41	50	49	46	46
query42	118	104	103	103
query43	524	525	508	508
query44	1380	851	849	849
query45	184	170	165	165
query46	884	1052	650	650
query47	1882	1919	1832	1832
query48	384	404	332	332
query49	713	519	398	398
query50	673	658	391	391
query51	6955	6995	6959	6959
query52	107	104	91	91
query53	229	267	185	185
query54	485	528	421	421
query55	90	83	83	83
query56	271	262	259	259
query57	1247	1203	1150	1150
query58	250	237	224	224
query59	2996	2991	3007	2991
query60	302	260	243	243
query61	137	118	111	111
query62	796	756	693	693
query63	219	186	179	179
query64	1235	1021	639	639
query65	3195	3141	3116	3116
query66	712	403	297	297
query67	15961	15597	15466	15466
query68	5014	816	525	525
query69	513	301	260	260
query70	1183	1169	1088	1088
query71	412	281	256	256
query72	6068	3784	3946	3784
query73	815	747	362	362
query74	10425	8850	8906	8850
query75	3183	3122	2678	2678
query76	3773	1186	761	761
query77	472	353	275	275
query78	10088	9974	9328	9328
query79	3161	811	606	606
query80	1161	533	433	433
query81	550	275	244	244
query82	475	169	121	121
query83	240	259	146	146
query84	294	93	72	72
query85	762	334	292	292
query86	420	291	271	271
query87	4446	4615	4466	4466
query88	4577	2187	2205	2187
query89	399	313	291	291
query90	1591	188	193	188
query91	136	138	106	106
query92	72	59	54	54
query93	2427	878	540	540
query94	805	407	294	294
query95	326	260	249	249
query96	483	614	276	276
query97	2856	2934	2776	2776
query98	229	200	199	199
query99	1414	1492	1376	1376
Total cold run time: 308065 ms
Total hot run time: 195632 ms

@doris-robot
Copy link

doris-robot commented Jan 15, 2025

ClickBench: Total hot run time: 30.68 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 645d63fb1c5c7b328737cbadf7624e7d63d4b7d1, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.03
query3	0.24	0.06	0.07
query4	1.62	0.11	0.11
query5	0.43	0.43	0.39
query6	1.18	0.65	0.65
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.60	0.54	0.50
query10	0.57	0.57	0.55
query11	0.14	0.11	0.10
query12	0.14	0.10	0.11
query13	0.61	0.59	0.61
query14	2.86	2.77	2.74
query15	0.91	0.83	0.81
query16	0.40	0.37	0.38
query17	0.96	1.03	1.06
query18	0.22	0.21	0.21
query19	1.97	1.80	1.92
query20	0.02	0.01	0.02
query21	15.37	0.96	0.60
query22	0.76	0.84	0.72
query23	15.24	1.42	0.56
query24	3.32	0.42	1.79
query25	0.21	0.15	0.06
query26	0.31	0.15	0.14
query27	0.06	0.08	0.06
query28	13.89	1.51	1.05
query29	12.58	3.92	3.23
query30	0.24	0.09	0.06
query31	2.84	0.60	0.38
query32	3.23	0.54	0.46
query33	2.96	2.99	3.11
query34	16.70	5.26	4.52
query35	4.62	4.52	4.52
query36	0.67	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.54 s
Total hot run time: 30.68 s

@yx-keith yx-keith changed the title implement kill connection and query command in nereids [Enhancement] (nereids)implement kill connection and query command in nereids Jan 15, 2025
@yx-keith
Copy link
Contributor Author

yx-keith commented Jan 17, 2025

run buildall

1 similar comment
@yx-keith
Copy link
Contributor Author

yx-keith commented Jan 18, 2025

run buildall

@yx-keith
Copy link
Contributor Author

yx-keith commented Apr 3, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 3, 2025

TPC-H: Total hot run time: 34231 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 159ba949bd10543b97b79c45f7ccd3d0e1157271, data reload: false

------ Round 1 ----------------------------------
q1	26107	5040	5055	5040
q2	2070	282	183	183
q3	10540	1224	694	694
q4	10236	992	523	523
q5	7785	2407	2328	2328
q6	197	163	134	134
q7	936	760	612	612
q8	9326	1351	1096	1096
q9	6830	5111	5124	5111
q10	6794	2316	1890	1890
q11	489	288	268	268
q12	347	365	222	222
q13	17792	3723	3153	3153
q14	226	231	221	221
q15	531	474	510	474
q16	641	651	581	581
q17	604	863	384	384
q18	7673	7264	7107	7107
q19	1512	956	554	554
q20	344	356	230	230
q21	4063	2690	2471	2471
q22	1058	1020	955	955
Total cold run time: 116101 ms
Total hot run time: 34231 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5201	5132	5150	5132
q2	244	352	227	227
q3	2156	2662	2250	2250
q4	1462	1882	1472	1472
q5	4543	4496	4414	4414
q6	216	181	132	132
q7	1968	1924	1749	1749
q8	2583	2658	2543	2543
q9	7198	7121	7101	7101
q10	2963	3163	2724	2724
q11	570	512	474	474
q12	698	753	628	628
q13	3533	3883	3178	3178
q14	280	297	287	287
q15	554	482	477	477
q16	655	677	641	641
q17	1178	1549	1394	1394
q18	7702	7482	7344	7344
q19	791	812	954	812
q20	1960	1996	1897	1897
q21	5063	4647	4594	4594
q22	1033	987	990	987
Total cold run time: 52551 ms
Total hot run time: 50457 ms

@doris-robot
Copy link

doris-robot commented Apr 3, 2025

TPC-DS: Total hot run time: 186340 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 159ba949bd10543b97b79c45f7ccd3d0e1157271, data reload: false

query1	987	495	460	460
query2	6542	1935	1912	1912
query3	6755	214	216	214
query4	26149	23479	22922	22922
query5	4272	612	455	455
query6	302	212	201	201
query7	4626	495	278	278
query8	334	246	244	244
query9	8637	2601	2587	2587
query10	474	322	269	269
query11	15824	15038	14989	14989
query12	156	113	103	103
query13	1661	516	403	403
query14	9292	6095	6141	6095
query15	223	190	165	165
query16	7255	633	461	461
query17	1202	722	589	589
query18	1984	407	317	317
query19	193	185	179	179
query20	123	116	119	116
query21	218	129	109	109
query22	4188	4391	4300	4300
query23	33677	32905	33070	32905
query24	8416	2355	2361	2355
query25	559	470	401	401
query26	1230	278	150	150
query27	2718	509	330	330
query28	4292	2450	2379	2379
query29	758	568	418	418
query30	289	221	193	193
query31	962	852	783	783
query32	78	70	62	62
query33	560	380	301	301
query34	776	857	500	500
query35	772	823	754	754
query36	961	959	912	912
query37	119	96	75	75
query38	4220	4163	4033	4033
query39	1468	1428	1397	1397
query40	225	117	105	105
query41	56	53	51	51
query42	114	106	111	106
query43	482	499	481	481
query44	1274	796	790	790
query45	176	173	166	166
query46	819	1014	610	610
query47	1756	1805	1706	1706
query48	370	410	300	300
query49	788	500	443	443
query50	649	665	391	391
query51	4165	4139	4178	4139
query52	110	108	98	98
query53	214	246	178	178
query54	579	558	499	499
query55	86	81	83	81
query56	296	286	302	286
query57	1148	1156	1074	1074
query58	264	259	250	250
query59	2602	2786	2535	2535
query60	324	328	304	304
query61	138	161	128	128
query62	784	767	657	657
query63	229	185	184	184
query64	4400	1014	684	684
query65	4298	4243	4247	4243
query66	1143	423	317	317
query67	15570	15700	15340	15340
query68	9254	878	521	521
query69	453	298	257	257
query70	1205	1129	1074	1074
query71	454	313	295	295
query72	5257	4776	4812	4776
query73	733	624	346	346
query74	9302	9081	8988	8988
query75	4281	3227	2705	2705
query76	3662	1173	756	756
query77	927	383	287	287
query78	10081	10280	9263	9263
query79	1823	860	574	574
query80	590	518	445	445
query81	492	263	219	219
query82	453	129	102	102
query83	267	254	246	246
query84	252	107	192	107
query85	792	363	320	320
query86	339	314	291	291
query87	4405	4363	4363	4363
query88	3398	2226	2208	2208
query89	379	319	281	281
query90	1938	223	220	220
query91	158	142	115	115
query92	78	64	58	58
query93	1290	956	599	599
query94	662	405	304	304
query95	382	296	289	289
query96	479	572	268	268
query97	3151	3320	3126	3126
query98	226	212	208	208
query99	1441	1424	1267	1267
Total cold run time: 274915 ms
Total hot run time: 186340 ms

@doris-robot
Copy link

doris-robot commented Apr 3, 2025

ClickBench: Total hot run time: 30.71 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 159ba949bd10543b97b79c45f7ccd3d0e1157271, data reload: false

query1	0.04	0.04	0.04
query2	0.12	0.10	0.10
query3	0.24	0.20	0.19
query4	1.60	0.19	0.20
query5	0.56	0.56	0.56
query6	1.19	0.73	0.72
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.53	0.51
query10	0.63	0.59	0.56
query11	0.14	0.11	0.11
query12	0.14	0.12	0.11
query13	0.61	0.60	0.60
query14	2.68	2.70	2.75
query15	0.94	0.85	0.84
query16	0.39	0.37	0.38
query17	0.99	1.06	1.01
query18	0.21	0.19	0.19
query19	1.91	1.91	1.85
query20	0.02	0.01	0.02
query21	15.50	0.91	0.54
query22	0.73	1.24	0.59
query23	15.00	1.41	0.60
query24	7.38	1.24	0.54
query25	0.48	0.33	0.08
query26	0.58	0.15	0.13
query27	0.06	0.05	0.05
query28	9.57	0.86	0.43
query29	12.54	4.09	3.31
query30	0.25	0.09	0.06
query31	2.83	0.58	0.39
query32	3.23	0.55	0.46
query33	3.10	3.16	3.08
query34	15.66	5.15	4.47
query35	4.57	4.48	4.54
query36	0.69	0.50	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.74 s
Total hot run time: 30.71 s

@yx-keith
Copy link
Contributor Author

yx-keith commented Apr 3, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 3, 2025

TPC-H: Total hot run time: 34335 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit aa4585b4327486f007a36999008daee32c48d177, data reload: false

------ Round 1 ----------------------------------
q1	25832	5059	5090	5059
q2	2057	276	180	180
q3	10403	1263	672	672
q4	10222	991	514	514
q5	7507	2374	2372	2372
q6	183	170	132	132
q7	904	729	644	644
q8	9307	1287	1123	1123
q9	6763	5130	5115	5115
q10	6862	2315	1923	1923
q11	484	282	268	268
q12	366	355	221	221
q13	17763	3644	3132	3132
q14	230	232	208	208
q15	538	487	475	475
q16	620	613	588	588
q17	594	855	370	370
q18	7663	7172	7112	7112
q19	2026	960	560	560
q20	345	326	228	228
q21	4044	3382	2438	2438
q22	1072	1003	1001	1001
Total cold run time: 115785 ms
Total hot run time: 34335 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5195	5142	5155	5142
q2	233	326	226	226
q3	2173	2626	2278	2278
q4	1399	1811	1486	1486
q5	4470	4440	4427	4427
q6	225	170	135	135
q7	2015	1878	1749	1749
q8	2590	2574	2488	2488
q9	7247	7162	7212	7162
q10	2994	3172	2730	2730
q11	590	518	485	485
q12	662	779	617	617
q13	3564	3943	3369	3369
q14	279	293	283	283
q15	525	494	482	482
q16	650	685	663	663
q17	1138	1515	1419	1419
q18	7793	7574	7582	7574
q19	832	801	800	800
q20	1938	1990	1940	1940
q21	5296	4797	4830	4797
q22	1095	1041	1014	1014
Total cold run time: 52903 ms
Total hot run time: 51266 ms

@doris-robot
Copy link

doris-robot commented Apr 3, 2025

TPC-DS: Total hot run time: 193307 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit aa4585b4327486f007a36999008daee32c48d177, data reload: false

query1	1422	1079	1041	1041
query2	6178	1921	1931	1921
query3	11007	4516	4528	4516
query4	54381	25292	23322	23322
query5	5145	497	471	471
query6	368	195	185	185
query7	5001	506	284	284
query8	329	258	230	230
query9	6277	2617	2636	2617
query10	450	321	261	261
query11	15200	14971	14756	14756
query12	161	113	107	107
query13	1144	511	414	414
query14	10213	6305	6237	6237
query15	199	204	188	188
query16	7074	668	521	521
query17	1064	741	590	590
query18	1554	419	316	316
query19	201	190	157	157
query20	126	116	125	116
query21	207	128	105	105
query22	4459	4496	4195	4195
query23	33985	33347	33218	33218
query24	6888	2453	2434	2434
query25	446	490	413	413
query26	657	270	159	159
query27	2137	509	338	338
query28	3000	2447	2435	2435
query29	596	579	440	440
query30	276	229	196	196
query31	853	881	769	769
query32	72	64	60	60
query33	447	385	317	317
query34	773	872	523	523
query35	817	839	753	753
query36	945	990	916	916
query37	130	100	79	79
query38	4249	4283	4283	4283
query39	1479	1450	1427	1427
query40	205	125	105	105
query41	53	52	52	52
query42	120	113	109	109
query43	503	506	487	487
query44	1336	831	824	824
query45	181	177	169	169
query46	856	1038	665	665
query47	1848	1881	1823	1823
query48	386	427	305	305
query49	694	535	434	434
query50	664	699	412	412
query51	4247	4230	4303	4230
query52	115	111	101	101
query53	234	268	191	191
query54	606	584	530	530
query55	94	86	83	83
query56	307	328	310	310
query57	1181	1226	1157	1157
query58	273	262	279	262
query59	2723	2803	2697	2697
query60	339	327	317	317
query61	145	132	131	131
query62	756	738	680	680
query63	228	191	218	191
query64	1484	1062	707	707
query65	4395	4369	4363	4363
query66	726	410	304	304
query67	15868	15517	15419	15419
query68	4818	886	531	531
query69	521	304	273	273
query70	1193	1129	1115	1115
query71	431	304	301	301
query72	6000	4886	4971	4886
query73	1021	706	351	351
query74	8891	9153	8806	8806
query75	3425	3224	2696	2696
query76	3619	1177	735	735
query77	566	379	288	288
query78	9956	10169	9332	9332
query79	1641	912	564	564
query80	671	536	461	461
query81	483	266	229	229
query82	212	129	96	96
query83	274	259	242	242
query84	313	112	86	86
query85	843	424	480	424
query86	334	302	268	268
query87	4467	4382	4375	4375
query88	2796	2213	2208	2208
query89	388	311	280	280
query90	1905	209	208	208
query91	150	140	217	140
query92	76	59	58	58
query93	2288	953	576	576
query94	670	405	291	291
query95	370	287	298	287
query96	486	577	270	270
query97	3117	3242	3073	3073
query98	228	205	212	205
query99	1320	1396	1284	1284
Total cold run time: 293950 ms
Total hot run time: 193307 ms

@doris-robot
Copy link

doris-robot commented Apr 3, 2025

ClickBench: Total hot run time: 30.64 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit aa4585b4327486f007a36999008daee32c48d177, data reload: false

query1	0.03	0.03	0.03
query2	0.13	0.10	0.11
query3	0.25	0.20	0.19
query4	1.59	0.19	0.20
query5	0.59	0.57	0.60
query6	1.19	0.73	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.57	0.52	0.53
query10	0.58	0.59	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.11
query13	0.61	0.60	0.60
query14	2.66	2.68	2.73
query15	0.91	0.84	0.86
query16	0.38	0.38	0.40
query17	1.05	1.03	1.01
query18	0.21	0.19	0.19
query19	1.96	1.95	1.80
query20	0.02	0.01	0.01
query21	15.36	0.91	0.54
query22	0.76	1.22	0.66
query23	14.90	1.40	0.63
query24	7.57	0.98	0.42
query25	0.51	0.07	0.16
query26	0.61	0.16	0.13
query27	0.05	0.05	0.05
query28	9.34	0.92	0.44
query29	12.56	4.03	3.32
query30	0.25	0.09	0.06
query31	2.82	0.58	0.38
query32	3.22	0.55	0.46
query33	3.02	3.06	3.13
query34	15.86	5.10	4.50
query35	4.58	4.52	4.47
query36	0.67	0.49	0.49
query37	0.09	0.07	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.12
query41	0.07	0.02	0.02
query42	0.04	0.02	0.03
query43	0.03	0.04	0.03
Total cold run time: 105.65 s
Total hot run time: 30.64 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

PR approved by at least one committer and no changes requested.

@starocean999 starocean999 merged commit 691b99a into apache:master Apr 3, 2025
24 of 26 checks passed
@morningman morningman mentioned this pull request May 11, 2025
Merged
16 tasks
morningman added a commit that referenced this pull request May 26, 2025
@morningman
[fix/feature](kill) fix kill operation and support kill by trace id (#…
4f1aa7d 
…50791)

### What problem does this PR solve?

Related PR: #50776, #46882

Problem Summary:

1. Fix bug that `KILL connection_id` is not supported in Nereids

This PR #46882 implements `KILL` in Nereids, but it miss the grammar
`KILL connection_id` and treat it as `KILL query_id`. This PR fix it.

2. Unify the core code of `KILL` operation in both old and new planner

All core logic about `kill` are moved to `KillUtils` class. So that both
old and new planner and can have same logic.

3. Support Kill query by query id from all FE

Previously, when executing `kill query query_id;`, Doris will only find
query id in current FE. If not found, Doris will send the cancel request
to all Backends to try cancelling this query.

In this PR, I changed the logic. Doris will first find query id in
current FE, if not found, this `kill` command will be forwarded to all
other Frontends to then find it in other FEs. And Doris will no longer
send the cancel request to Backend.

4. Support Kill query by trace id from all FE

User can set a custom `trace id` by `set
session_context="trace_id:your_trace_id"`. And this trace id will be
bind to the subsequent queries in this connection. Then user can cancel
the query by trace id:

    `KILL QUERY "trace_id"`

More details can be found in user doc:
apache/doris-website#2371
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@yx-keith @koarz
[Enhancement] (nereids)implement kill connection and query command in…
81e6673 
… nereids (apache#46882)

Issue Number: close
#[42532](apache#42532
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@morningman @koarz
[fix/feature](kill) fix kill operation and support kill by trace id (a…
de18272 
…pache#50791)

### What problem does this PR solve?

Related PR: apache#50776, apache#46882

Problem Summary:

1. Fix bug that `KILL connection_id` is not supported in Nereids

This PR apache#46882 implements `KILL` in Nereids, but it miss the grammar
`KILL connection_id` and treat it as `KILL query_id`. This PR fix it.

2. Unify the core code of `KILL` operation in both old and new planner

All core logic about `kill` are moved to `KillUtils` class. So that both
old and new planner and can have same logic.

3. Support Kill query by query id from all FE

Previously, when executing `kill query query_id;`, Doris will only find
query id in current FE. If not found, Doris will send the cancel request
to all Backends to try cancelling this query.

In this PR, I changed the logic. Doris will first find query id in
current FE, if not found, this `kill` command will be forwarded to all
other Frontends to then find it in other FEs. And Doris will no longer
send the cancel request to Backend.

4. Support Kill query by trace id from all FE

User can set a custom `trace id` by `set
session_context="trace_id:your_trace_id"`. And this trace id will be
bind to the subsequent queries in this connection. Then user can cancel
the query by trace id:

    `KILL QUERY "trace_id"`

More details can be found in user doc:
apache/doris-website#2371
morningman pushed a commit to morningman/doris that referenced this pull request Jun 24, 2025
@yx-keith @morningman
[Enhancement] (nereids)implement kill connection and query command in…
a5af569 
… nereids (apache#46882)

Issue Number: close
morningman added a commit to morningman/doris that referenced this pull request Jun 24, 2025
@morningman
[fix/feature](kill) fix kill operation and support kill by trace id (a…
7ce104a 
…pache#50791)

Related PR: apache#50776, apache#46882

Problem Summary:

1. Fix bug that `KILL connection_id` is not supported in Nereids

This PR apache#46882 implements `KILL` in Nereids, but it miss the grammar
`KILL connection_id` and treat it as `KILL query_id`. This PR fix it.

2. Unify the core code of `KILL` operation in both old and new planner

All core logic about `kill` are moved to `KillUtils` class. So that both
old and new planner and can have same logic.

3. Support Kill query by query id from all FE

Previously, when executing `kill query query_id;`, Doris will only find
query id in current FE. If not found, Doris will send the cancel request
to all Backends to try cancelling this query.

In this PR, I changed the logic. Doris will first find query id in
current FE, if not found, this `kill` command will be forwarded to all
other Frontends to then find it in other FEs. And Doris will no longer
send the cancel request to Backend.

4. Support Kill query by trace id from all FE

User can set a custom `trace id` by `set
session_context="trace_id:your_trace_id"`. And this trace id will be
bind to the subsequent queries in this connection. Then user can cancel
the query by trace id:

    `KILL QUERY "trace_id"`

More details can be found in user doc:
apache/doris-website#2371
@morningman morningman mentioned this pull request Jun 24, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jun 24, 2025
@morningman @yx-keith @Vallishp
branch-3.1: [fix/feature](kill) fix kill operation and support kill b…
7199808 
…y trace id #46882 #48942 #50791 #43231 (#52197)

bp #46882 #48942 #50791 #43231

---------

Co-authored-by: yaoxiao <yx136264032@163.com>
Co-authored-by: Vallish Pai <vallishpai@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@englefly englefly englefly approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yx-keith @hello-stephen @doris-robot @englefly @starocean999 @morningman @morrySnow