-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Enhancement] (nereids) implement drop/killAnalyzeJobCommand in nereids #48942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] (nereids) implement drop/killAnalyzeJobCommand in nereids #48942
Conversation
|
run buildAll |
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
please add a regression test case |
|
run builall |
|
run buildall |
TPC-H: Total hot run time: 34318 ms |
TPC-DS: Total hot run time: 193544 ms |
ClickBench: Total hot run time: 31.33 s |
|
run buildall |
TPC-H: Total hot run time: 33904 ms |
TPC-DS: Total hot run time: 193188 ms |
ClickBench: Total hot run time: 31.37 s |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 34051 ms |
TPC-DS: Total hot run time: 193746 ms |
ClickBench: Total hot run time: 31.26 s |
|
run buildall |
TPC-H: Total hot run time: 34388 ms |
TPC-DS: Total hot run time: 186497 ms |
ClickBench: Total hot run time: 30.92 s |
|
run buildall |
TPC-H: Total hot run time: 34243 ms |
TPC-DS: Total hot run time: 187123 ms |
ClickBench: Total hot run time: 31.45 s |
|
run p0 |
|
|
||
| @Override | ||
| public void doRun(ConnectContext ctx, StmtExecutor executor) throws Exception { | ||
| validate(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to do the validate() here, because there is a privilege chech in the handleKillAnalyzeJob() function. Same for the JobAnalyzeJobCommand above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 34273 ms |
TPC-DS: Total hot run time: 193325 ms |
ClickBench: Total hot run time: 30.84 s |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
…ds (apache#48942) Issue Number: close apache#42712,apache#42713
…ds (apache#48942) Issue Number: close apache#42712,apache#42713
What problem does this PR solve?
Issue Number: close #42712,#42713
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)