Skip to content

[opt](identifer) let unicode format as a superset of latin format #48078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Feb 24, 2025
Merged

[opt](identifer) let unicode format as a superset of latin format #48078

morrySnow merged 1 commit into from
Feb 24, 2025

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Feb 19, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

morrySnow commented Feb 19, 2025

run buildall

@morrySnow morrySnow force-pushed the let_unicode_name_same branch from c322c26 to d39b5a9 Compare February 19, 2025 07:55
@morrySnow
Copy link
Contributor Author

morrySnow commented Feb 19, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Feb 19, 2025

TPC-H: Total hot run time: 31616 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d39b5a93f2141c5799af488cb224cbf33831b6a5, data reload: false

------ Round 1 ----------------------------------
q1	17624	5320	5049	5049
q2	2046	312	177	177
q3	10393	1237	737	737
q4	10443	997	534	534
q5	7567	2485	2311	2311
q6	186	162	132	132
q7	905	761	609	609
q8	9431	1329	1235	1235
q9	4992	4569	4630	4569
q10	6872	2297	1880	1880
q11	499	283	263	263
q12	365	361	226	226
q13	17771	3686	3113	3113
q14	226	233	217	217
q15	492	469	467	467
q16	631	612	583	583
q17	585	850	343	343
q18	6656	6177	6175	6175
q19	1519	965	538	538
q20	307	324	190	190
q21	2847	2169	1970	1970
q22	364	332	298	298
Total cold run time: 102721 ms
Total hot run time: 31616 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5105	5091	5055	5055
q2	238	324	230	230
q3	2136	2658	2245	2245
q4	1412	1801	1377	1377
q5	4247	4170	4178	4170
q6	209	164	126	126
q7	1861	1846	1673	1673
q8	2606	2597	2542	2542
q9	7318	7207	7030	7030
q10	2995	3218	2816	2816
q11	584	512	501	501
q12	716	751	663	663
q13	3435	3914	3276	3276
q14	277	317	273	273
q15	501	467	455	455
q16	634	692	641	641
q17	1138	1565	1356	1356
q18	7528	7307	7253	7253
q19	820	836	887	836
q20	1991	2081	1850	1850
q21	5292	5024	4769	4769
q22	588	577	523	523
Total cold run time: 51631 ms
Total hot run time: 49660 ms

@doris-robot
Copy link

doris-robot commented Feb 19, 2025

TPC-DS: Total hot run time: 189961 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d39b5a93f2141c5799af488cb224cbf33831b6a5, data reload: false

query1	1311	969	908	908
query2	6238	1823	1833	1823
query3	10932	4450	4394	4394
query4	56627	24487	23017	23017
query5	5167	505	506	505
query6	384	208	184	184
query7	5266	507	297	297
query8	344	249	237	237
query9	6682	2550	2558	2550
query10	408	298	262	262
query11	15354	15046	14897	14897
query12	155	107	103	103
query13	1234	536	367	367
query14	10392	6637	6633	6633
query15	208	214	176	176
query16	7024	679	454	454
query17	1055	706	560	560
query18	1487	406	305	305
query19	192	220	161	161
query20	125	125	123	123
query21	202	120	101	101
query22	4551	4434	4331	4331
query23	34134	33223	33441	33223
query24	5679	2455	2450	2450
query25	450	461	386	386
query26	662	281	155	155
query27	1666	524	344	344
query28	2956	2489	2483	2483
query29	556	560	423	423
query30	216	183	149	149
query31	875	895	801	801
query32	81	62	61	61
query33	440	380	329	329
query34	767	891	544	544
query35	828	856	760	760
query36	955	1028	917	917
query37	124	100	77	77
query38	4373	4443	4230	4230
query39	1524	1426	1537	1426
query40	205	124	107	107
query41	56	56	56	56
query42	125	107	108	107
query43	516	519	511	511
query44	1351	827	824	824
query45	181	175	165	165
query46	888	1147	668	668
query47	1842	1857	1827	1827
query48	394	434	327	327
query49	758	508	401	401
query50	723	757	421	421
query51	4209	4326	4266	4266
query52	120	107	102	102
query53	263	271	192	192
query54	487	511	420	420
query55	78	87	77	77
query56	259	282	258	258
query57	1146	1187	1114	1114
query58	261	240	249	240
query59	2663	2890	2580	2580
query60	277	276	258	258
query61	118	112	115	112
query62	729	756	665	665
query63	237	199	198	198
query64	1395	1037	675	675
query65	3336	3178	3116	3116
query66	708	393	296	296
query67	16052	15616	15445	15445
query68	5265	795	543	543
query69	505	304	266	266
query70	1192	1172	1144	1144
query71	442	299	252	252
query72	5879	3569	3705	3569
query73	992	750	360	360
query74	9239	9162	9293	9162
query75	3492	3164	2688	2688
query76	3649	1166	724	724
query77	570	370	284	284
query78	10018	10134	9391	9391
query79	1778	813	602	602
query80	642	532	446	446
query81	493	274	239	239
query82	352	177	91	91
query83	168	173	159	159
query84	296	94	75	75
query85	740	343	299	299
query86	335	317	280	280
query87	4555	4498	4420	4420
query88	2896	2192	2185	2185
query89	405	314	287	287
query90	1940	195	185	185
query91	134	135	109	109
query92	70	63	61	61
query93	2386	1028	582	582
query94	637	416	313	313
query95	349	265	258	258
query96	507	550	269	269
query97	2760	2848	2715	2715
query98	225	205	204	204
query99	1323	1399	1225	1225
Total cold run time: 295235 ms
Total hot run time: 189961 ms

@doris-robot
Copy link

doris-robot commented Feb 19, 2025

ClickBench: Total hot run time: 30.68 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d39b5a93f2141c5799af488cb224cbf33831b6a5, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.03
query3	0.24	0.08	0.06
query4	1.61	0.11	0.10
query5	0.42	0.41	0.39
query6	1.14	0.66	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.59	0.52	0.53
query10	0.57	0.58	0.58
query11	0.16	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	2.69	2.70	2.70
query15	0.92	0.87	0.83
query16	0.38	0.37	0.38
query17	1.03	1.03	1.04
query18	0.22	0.19	0.19
query19	1.92	1.77	2.05
query20	0.01	0.01	0.01
query21	15.35	0.90	0.53
query22	0.76	1.37	0.68
query23	14.78	1.38	0.63
query24	8.16	3.63	0.87
query25	0.41	0.26	0.19
query26	0.82	0.19	0.14
query27	0.05	0.05	0.05
query28	7.91	0.75	0.43
query29	12.54	3.90	3.28
query30	0.25	0.09	0.06
query31	2.82	0.60	0.39
query32	3.22	0.55	0.46
query33	3.08	3.17	3.05
query34	15.64	5.10	4.50
query35	4.53	4.48	4.58
query36	0.67	0.49	0.49
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.17	0.13	0.13
query41	0.08	0.03	0.03
query42	0.03	0.02	0.03
query43	0.04	0.02	0.02
Total cold run time: 104.3 s
Total hot run time: 30.68 s

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Feb 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 948540c into apache:master Feb 24, 2025
25 of 26 checks passed
@morrySnow morrySnow deleted the let_unicode_name_same branch February 24, 2025 06:26
seawinde pushed a commit to seawinde/doris that referenced this pull request Feb 28, 2025
@morrySnow @seawinde
[opt](identifer) let unicode format as a superset of latin format (ap…
2e40f53 
…ache#48078)
csun5285 pushed a commit to csun5285/doris that referenced this pull request Mar 28, 2025
@morrySnow
[opt](identifier) let column's name format more flexable apache#47840 a…
36395af 
…pache#48078 (apache#3811)

pick 2 PR from doris' master
- apache#47840
- apache#48078
morrySnow added a commit that referenced this pull request Apr 4, 2025
@morrySnow
branch-3.0: [opt](identifer) let unicode format as a superset of lati…
31b293d 
…n format #48078

pick from master #48078
@morrySnow morrySnow mentioned this pull request Apr 4, 2025
Merged
dataroaring pushed a commit that referenced this pull request Apr 4, 2025
@morrySnow
branch-3.0: [opt](identifer) let unicode format as a superset of lati…
2c92722 
…n format #48078 (#49808)

pick from master #48078
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@morrySnow @koarz
[opt](identifer) let unicode format as a superset of latin format (ap…
36a2ffb 
…ache#48078)
@morrySnow morrySnow mentioned this pull request Jul 15, 2025
Merged
yiguolei pushed a commit that referenced this pull request Jul 16, 2025
@morrySnow
branch-2.1: [opt](identifer) let unicode format as a superset of lati…
cc387f3 
…n format #48078 (#53264)

cherry-picked from #48078
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.11-merged dev/3.0.5-merged kind/behavior-changed reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@morrySnow @hello-stephen @doris-robot @morningman @starocean999 @yiguolei @dataroaring