Skip to content

[opt](identifier) let column's name format more flexable #47840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Feb 14, 2025
Merged

[opt](identifier) let column's name format more flexable #47840

morrySnow merged 1 commit into from
Feb 14, 2025

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Feb 12, 2025

What problem does this PR solve?

Problem Summary:

support some symbol as first character

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@morrySnow morrySnow added usercase Important user case type label dev/3.0.x labels Feb 12, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

morrySnow commented Feb 12, 2025

run buildall

@morrySnow
[opt](identifier) let column's name format more flexable
c763734 
support some symbol as first character
@morrySnow
Copy link
Contributor Author

morrySnow commented Feb 13, 2025

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Feb 13, 2025

TPC-H: Total hot run time: 31446 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c76373476df57f8e9bc11b623684a05c580102a7, data reload: false

------ Round 1 ----------------------------------
q1	7443	5007	4984	4984
q2	388	290	168	168
q3	8476	1234	680	680
q4	10558	1003	527	527
q5	7536	2377	2327	2327
q6	189	167	139	139
q7	894	730	604	604
q8	9293	1261	1047	1047
q9	4811	4887	4810	4810
q10	6840	2327	1887	1887
q11	491	273	249	249
q12	352	349	217	217
q13	17746	3676	3154	3154
q14	235	226	209	209
q15	511	478	448	448
q16	616	619	577	577
q17	573	863	348	348
q18	6784	6391	6092	6092
q19	1073	954	551	551
q20	311	320	194	194
q21	2760	2173	1928	1928
q22	365	331	306	306
Total cold run time: 88245 ms
Total hot run time: 31446 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5077	5067	5048	5048
q2	230	325	243	243
q3	2156	2685	2300	2300
q4	1454	1775	1356	1356
q5	4228	4131	4145	4131
q6	209	164	122	122
q7	1859	1813	1642	1642
q8	2505	2508	2485	2485
q9	6885	6782	6785	6782
q10	2873	3072	2609	2609
q11	570	488	472	472
q12	646	729	587	587
q13	3253	3661	3003	3003
q14	265	280	257	257
q15	493	467	445	445
q16	638	691	626	626
q17	1088	1520	1352	1352
q18	7110	7122	7039	7039
q19	750	804	997	804
q20	1902	1950	1785	1785
q21	5124	4742	4653	4653
q22	599	618	568	568
Total cold run time: 49914 ms
Total hot run time: 48309 ms

@doris-robot
Copy link

doris-robot commented Feb 13, 2025

TPC-DS: Total hot run time: 183040 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c76373476df57f8e9bc11b623684a05c580102a7, data reload: false

query1	966	386	395	386
query2	6540	1862	1809	1809
query3	6791	211	208	208
query4	26519	23661	23358	23358
query5	5733	672	486	486
query6	314	207	184	184
query7	4611	497	304	304
query8	295	248	236	236
query9	8642	2561	2571	2561
query10	503	304	251	251
query11	15549	15070	14868	14868
query12	165	107	106	106
query13	1643	503	382	382
query14	10513	6461	6059	6059
query15	203	186	182	182
query16	6865	617	465	465
query17	1399	685	539	539
query18	1140	354	306	306
query19	190	180	156	156
query20	129	118	115	115
query21	212	129	103	103
query22	4256	4149	4208	4149
query23	33779	32917	32874	32874
query24	7986	2372	2362	2362
query25	572	469	410	410
query26	1242	270	162	162
query27	2699	495	339	339
query28	4339	2430	2428	2428
query29	669	555	443	443
query30	234	196	160	160
query31	934	830	790	790
query32	73	63	66	63
query33	564	375	318	318
query34	775	853	491	491
query35	808	803	747	747
query36	948	1046	899	899
query37	120	97	75	75
query38	4084	4147	4008	4008
query39	1435	1382	1393	1382
query40	211	117	103	103
query41	56	55	53	53
query42	123	107	103	103
query43	498	510	482	482
query44	1264	788	796	788
query45	171	165	165	165
query46	855	1054	636	636
query47	1768	1798	1735	1735
query48	376	412	312	312
query49	792	520	453	453
query50	674	745	405	405
query51	4146	4183	4127	4127
query52	113	106	97	97
query53	228	252	184	184
query54	476	484	418	418
query55	85	80	78	78
query56	272	260	247	247
query57	1134	1153	1069	1069
query58	250	232	234	232
query59	2596	2708	2554	2554
query60	281	278	264	264
query61	122	117	119	117
query62	803	712	676	676
query63	229	194	188	188
query64	4382	1011	692	692
query65	3220	3171	3111	3111
query66	1019	418	317	317
query67	15764	15778	15391	15391
query68	7937	753	512	512
query69	491	298	261	261
query70	1205	1107	1127	1107
query71	406	289	258	258
query72	6008	3706	3793	3706
query73	744	732	349	349
query74	9559	9107	8697	8697
query75	3164	3181	2647	2647
query76	3173	1168	737	737
query77	535	376	286	286
query78	9917	10044	9303	9303
query79	2433	808	606	606
query80	595	519	441	441
query81	501	287	240	240
query82	467	124	100	100
query83	177	169	156	156
query84	313	93	71	71
query85	751	350	300	300
query86	339	306	292	292
query87	4363	4396	4337	4337
query88	3843	2212	2195	2195
query89	386	331	299	299
query90	2074	196	193	193
query91	139	139	112	112
query92	79	61	56	56
query93	2035	1034	577	577
query94	703	398	302	302
query95	345	261	268	261
query96	481	557	273	273
query97	2792	2863	2748	2748
query98	232	205	212	205
query99	1309	1428	1252	1252
Total cold run time: 273843 ms
Total hot run time: 183040 ms

@doris-robot
Copy link

doris-robot commented Feb 13, 2025

ClickBench: Total hot run time: 30.27 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c76373476df57f8e9bc11b623684a05c580102a7, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.03	0.04
query3	0.23	0.07	0.07
query4	1.61	0.10	0.10
query5	0.42	0.41	0.40
query6	1.17	0.66	0.65
query7	0.02	0.02	0.01
query8	0.04	0.02	0.03
query9	0.58	0.51	0.54
query10	0.57	0.59	0.57
query11	0.16	0.11	0.10
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	2.68	2.83	2.71
query15	0.93	0.85	0.88
query16	0.37	0.38	0.38
query17	1.03	1.04	1.03
query18	0.21	0.19	0.20
query19	1.94	1.81	1.97
query20	0.01	0.01	0.02
query21	15.37	0.92	0.56
query22	0.75	1.31	0.93
query23	14.71	1.37	0.61
query24	11.00	1.32	0.35
query25	0.46	0.26	0.07
query26	0.92	0.17	0.14
query27	0.06	0.04	0.04
query28	6.39	0.76	0.46
query29	12.53	3.85	3.22
query30	0.25	0.08	0.06
query31	2.83	0.58	0.39
query32	3.22	0.54	0.46
query33	2.99	3.00	3.02
query34	15.76	5.13	4.45
query35	4.52	4.55	4.59
query36	0.67	0.50	0.48
query37	0.09	0.06	0.07
query38	0.04	0.04	0.05
query39	0.03	0.02	0.03
query40	0.17	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.03
query43	0.03	0.04	0.03
Total cold run time: 105.73 s
Total hot run time: 30.27 s

@morrySnow morrySnow merged commit 29d56c0 into apache:master Feb 14, 2025
25 of 26 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 14, 2025
@morrySnow
[opt](identifier) let column's name format more flexable (#47840)
0cd56fb
@github-actions github-actions bot mentioned this pull request Feb 14, 2025
Merged
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@morrySnow @lzyy2024
[opt](identifier) let column's name format more flexable (apache#47840)
c4e8afc
@morrySnow morrySnow deleted the update_name_format branch February 24, 2025 06:26
dataroaring pushed a commit that referenced this pull request Feb 25, 2025
@github-actions @morrySnow
branch-3.0: [opt](identifier) let column's name format more flexable #…
ee534df 
…47840 (#47902)

Cherry-picked from #47840

Co-authored-by: morrySnow <zhangwenxin@selectdb.com>
csun5285 pushed a commit to csun5285/doris that referenced this pull request Mar 28, 2025
@morrySnow
[opt](identifier) let column's name format more flexable apache#47840 a…
36395af 
…pache#48078 (apache#3811)

pick 2 PR from doris' master
- apache#47840
- apache#48078
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@morrySnow @koarz
[opt](identifier) let column's name format more flexable (apache#47840)
057f5d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.5-merged kind/behavior-changed reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@morrySnow @hello-stephen @doris-robot @morningman @starocean999 @dataroaring