Skip to content

branch-3.0: [opt](identifier) let column's name format more flexable #47840 #47902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Feb 25, 2025
Merged

branch-3.0: [opt](identifier) let column's name format more flexable #47840 #47902

dataroaring merged 1 commit into from
Feb 25, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 14, 2025

Cherry-picked from #47840

@Thearas
Copy link
Contributor

Thearas commented Feb 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Feb 14, 2025
@Thearas
Copy link
Contributor

Thearas commented Feb 14, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Feb 14, 2025

TPC-H: Total hot run time: 40584 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0cd56fb2d45a0072c2ae0100aea127851a4da86c, data reload: false

------ Round 1 ----------------------------------
q1	17581	7615	7220	7220
q2	2056	174	175	174
q3	10610	1080	1176	1080
q4	10607	747	738	738
q5	7780	2861	2819	2819
q6	241	145	142	142
q7	961	617	599	599
q8	9355	1929	2019	1929
q9	6560	6391	6433	6391
q10	7043	2271	2316	2271
q11	471	268	265	265
q12	397	207	203	203
q13	17799	2998	2995	2995
q14	239	207	206	206
q15	571	518	526	518
q16	670	593	581	581
q17	963	519	516	516
q18	7218	6567	6670	6567
q19	1447	1067	1134	1067
q20	472	206	196	196
q21	3924	3251	3091	3091
q22	1089	1019	1016	1016
Total cold run time: 108054 ms
Total hot run time: 40584 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7231	7209	7197	7197
q2	325	232	229	229
q3	2901	2953	2887	2887
q4	1998	1830	1801	1801
q5	5697	5721	5681	5681
q6	225	140	145	140
q7	2254	1751	1831	1751
q8	3336	3509	3494	3494
q9	8750	8948	8833	8833
q10	3575	3563	3582	3563
q11	603	513	493	493
q12	806	613	600	600
q13	9045	3242	3136	3136
q14	316	279	282	279
q15	566	520	522	520
q16	702	648	636	636
q17	1854	1607	1601	1601
q18	8156	7808	7556	7556
q19	1657	1625	1555	1555
q20	2122	1900	1879	1879
q21	5468	5381	5309	5309
q22	1129	1044	1050	1044
Total cold run time: 68716 ms
Total hot run time: 60184 ms

@doris-robot
Copy link

doris-robot commented Feb 14, 2025

TPC-DS: Total hot run time: 198242 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0cd56fb2d45a0072c2ae0100aea127851a4da86c, data reload: false

query1	1333	939	920	920
query2	6244	2155	2088	2088
query3	10824	4332	4173	4173
query4	66506	31335	23855	23855
query5	4809	484	445	445
query6	408	179	173	173
query7	5667	308	312	308
query8	315	229	228	228
query9	9187	2701	2682	2682
query10	455	263	257	257
query11	17003	15348	15861	15348
query12	154	112	102	102
query13	1542	461	467	461
query14	10882	7848	7240	7240
query15	198	187	184	184
query16	7137	497	498	497
query17	1081	588	603	588
query18	1895	355	354	354
query19	213	163	162	162
query20	119	115	109	109
query21	200	107	109	107
query22	4757	4626	4477	4477
query23	34591	34256	33907	33907
query24	6136	2919	2967	2919
query25	549	420	427	420
query26	658	178	169	169
query27	1859	359	344	344
query28	4548	2481	2465	2465
query29	761	451	430	430
query30	247	164	166	164
query31	966	812	840	812
query32	72	58	59	58
query33	429	286	283	283
query34	927	521	537	521
query35	885	733	754	733
query36	1098	963	968	963
query37	117	76	80	76
query38	4103	4098	4059	4059
query39	1513	1492	1485	1485
query40	210	98	96	96
query41	50	47	46	46
query42	111	100	99	99
query43	541	516	506	506
query44	1209	829	849	829
query45	182	165	178	165
query46	1131	737	741	737
query47	2002	1918	1908	1908
query48	491	396	394	394
query49	738	410	418	410
query50	819	433	435	433
query51	7297	7264	6994	6994
query52	101	87	86	86
query53	255	181	183	181
query54	544	446	444	444
query55	76	79	76	76
query56	261	249	233	233
query57	1224	1109	1109	1109
query58	207	202	206	202
query59	3311	3022	3129	3022
query60	276	260	282	260
query61	111	136	110	110
query62	845	722	709	709
query63	218	189	192	189
query64	1387	660	659	659
query65	3268	3179	3200	3179
query66	699	301	306	301
query67	16064	15717	15697	15697
query68	3946	593	588	588
query69	421	280	263	263
query70	1204	1139	1143	1139
query71	353	256	256	256
query72	6382	4036	4191	4036
query73	739	350	352	350
query74	10426	9279	8920	8920
query75	3342	2667	2673	2667
query76	1818	1080	1040	1040
query77	507	280	266	266
query78	10568	9601	9531	9531
query79	2106	587	600	587
query80	1379	427	434	427
query81	540	245	240	240
query82	1282	120	117	117
query83	272	151	148	148
query84	279	74	74	74
query85	1010	292	302	292
query86	409	305	288	288
query87	4380	4258	4379	4258
query88	3993	2377	2346	2346
query89	420	292	291	291
query90	1835	184	190	184
query91	185	150	149	149
query92	58	50	51	50
query93	2899	540	546	540
query94	801	290	323	290
query95	364	258	254	254
query96	612	279	289	279
query97	3331	3253	3112	3112
query98	209	199	203	199
query99	1691	1421	1428	1421
Total cold run time: 321777 ms
Total hot run time: 198242 ms

@doris-robot
Copy link

doris-robot commented Feb 14, 2025

ClickBench: Total hot run time: 31.61 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0cd56fb2d45a0072c2ae0100aea127851a4da86c, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.04	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.10
query5	0.53	0.54	0.51
query6	1.14	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.56	0.51	0.48
query10	0.55	0.55	0.55
query11	0.14	0.10	0.10
query12	0.14	0.11	0.12
query13	0.62	0.59	0.60
query14	2.72	2.75	2.84
query15	0.90	0.82	0.83
query16	0.38	0.39	0.38
query17	1.07	1.05	1.07
query18	0.24	0.22	0.22
query19	1.95	1.88	1.98
query20	0.02	0.01	0.01
query21	15.36	0.58	0.59
query22	2.75	3.37	1.12
query23	17.00	1.20	0.80
query24	3.09	0.52	1.68
query25	0.23	0.21	0.08
query26	0.49	0.15	0.14
query27	0.05	0.06	0.03
query28	10.72	1.12	1.07
query29	12.58	3.27	3.29
query30	0.25	0.05	0.06
query31	2.86	0.38	0.38
query32	3.26	0.46	0.45
query33	2.96	3.00	2.98
query34	17.00	4.45	4.50
query35	4.48	4.57	4.46
query36	0.68	0.48	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.16	0.12	0.12
query41	0.07	0.02	0.02
query42	0.04	0.03	0.02
query43	0.04	0.04	0.03
Total cold run time: 107.21 s
Total hot run time: 31.61 s

@morrySnow
Copy link
Contributor

morrySnow commented Feb 24, 2025

run buildall

dataroaring
dataroaring approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit ee534df into branch-3.0 Feb 25, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-47840-branch-3.0 branch February 25, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @doris-robot @morrySnow @dataroaring