Skip to content

branch-3.0: [opt](identifer) let unicode format as a superset of latin format #48078 #49808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Apr 4, 2025
Merged

branch-3.0: [opt](identifer) let unicode format as a superset of latin format #48078 #49808

dataroaring merged 1 commit into from
Apr 4, 2025

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Apr 4, 2025

pick from master #48078

@morrySnow morrySnow requested a review from dataroaring as a code owner April 4, 2025 12:30
@Thearas
Copy link
Contributor

Thearas commented Apr 4, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025

PR approved by anyone and no changes requested.

@gavinchou
Copy link
Contributor

gavinchou commented Apr 4, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 4, 2025

TPC-H: Total hot run time: 39953 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 31b293d4f42e10b1b36acc2bbe96a556789cd550, data reload: false

------ Round 1 ----------------------------------
q1	17577	6727	6588	6588
q2	2071	172	174	172
q3	10659	1072	1204	1072
q4	10529	725	697	697
q5	7761	2864	2751	2751
q6	222	137	141	137
q7	972	622	621	621
q8	9388	1934	2020	1934
q9	6678	6495	6469	6469
q10	7065	2230	2248	2230
q11	466	258	253	253
q12	399	225	212	212
q13	17792	3006	2993	2993
q14	240	201	208	201
q15	502	453	461	453
q16	669	589	600	589
q17	961	576	511	511
q18	7346	6736	6732	6732
q19	1447	1030	1034	1030
q20	474	199	196	196
q21	4216	3123	3276	3123
q22	1127	989	1007	989
Total cold run time: 108561 ms
Total hot run time: 39953 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6647	6606	6586	6586
q2	327	230	231	230
q3	2865	2735	2926	2735
q4	2088	1851	1788	1788
q5	5786	5738	5774	5738
q6	209	128	131	128
q7	2176	1860	1837	1837
q8	3388	3562	3528	3528
q9	8666	8889	8832	8832
q10	3589	3521	3508	3508
q11	603	480	505	480
q12	792	604	612	604
q13	8650	3209	3190	3190
q14	304	270	285	270
q15	517	460	468	460
q16	717	654	652	652
q17	1858	1617	1607	1607
q18	8304	7631	7534	7534
q19	1656	1651	1524	1524
q20	2107	1889	1861	1861
q21	5635	5446	5369	5369
q22	1140	1047	1054	1047
Total cold run time: 68024 ms
Total hot run time: 59508 ms

@doris-robot
Copy link

doris-robot commented Apr 4, 2025

TPC-DS: Total hot run time: 197141 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 31b293d4f42e10b1b36acc2bbe96a556789cd550, data reload: false

query1	1318	941	922	922
query2	6233	2066	2034	2034
query3	10933	4376	4475	4376
query4	65969	28751	23310	23310
query5	5051	454	448	448
query6	409	171	171	171
query7	5643	303	313	303
query8	302	207	230	207
query9	9432	2614	2593	2593
query10	472	272	264	264
query11	17496	15056	15713	15056
query12	168	112	106	106
query13	1575	433	440	433
query14	10895	7272	7719	7272
query15	199	189	188	188
query16	7087	485	489	485
query17	1407	599	553	553
query18	1852	304	315	304
query19	212	147	149	147
query20	122	110	107	107
query21	212	104	100	100
query22	5061	4620	4743	4620
query23	34312	34053	34177	34053
query24	6157	2886	2867	2867
query25	518	390	408	390
query26	652	169	165	165
query27	1900	353	355	353
query28	4326	2418	2399	2399
query29	695	461	467	461
query30	245	165	159	159
query31	1010	829	820	820
query32	77	56	57	56
query33	457	307	322	307
query34	931	514	538	514
query35	842	746	738	738
query36	1071	933	952	933
query37	121	73	68	68
query38	4098	3922	4028	3922
query39	1518	1482	1509	1482
query40	209	110	109	109
query41	52	52	51	51
query42	116	106	97	97
query43	543	479	504	479
query44	1176	840	824	824
query45	189	176	173	173
query46	1141	715	734	715
query47	2038	1947	1942	1942
query48	490	401	388	388
query49	748	417	411	411
query50	856	422	428	422
query51	7244	7122	7211	7122
query52	102	88	90	88
query53	255	185	179	179
query54	588	468	453	453
query55	78	77	75	75
query56	278	270	272	270
query57	1274	1143	1158	1143
query58	224	219	216	216
query59	3189	3071	2782	2782
query60	288	253	259	253
query61	110	107	105	105
query62	753	680	669	669
query63	214	191	186	186
query64	1397	677	671	671
query65	3222	3187	3162	3162
query66	705	297	303	297
query67	16118	15546	15671	15546
query68	4125	586	576	576
query69	434	269	264	264
query70	1214	1102	1088	1088
query71	346	260	260	260
query72	6389	3979	4006	3979
query73	752	346	345	345
query74	10030	9019	8989	8989
query75	3384	2588	2649	2588
query76	1865	1055	1121	1055
query77	464	275	306	275
query78	10594	9656	9651	9651
query79	1449	598	586	586
query80	853	416	427	416
query81	508	238	240	238
query82	1249	90	90	90
query83	241	142	141	141
query84	283	85	80	80
query85	858	313	310	310
query86	356	304	310	304
query87	4459	4333	4357	4333
query88	3679	2427	2356	2356
query89	411	287	289	287
query90	2011	185	190	185
query91	184	149	149	149
query92	67	61	52	52
query93	1836	541	536	536
query94	767	303	286	286
query95	362	257	259	257
query96	608	290	276	276
query97	3268	3186	3173	3173
query98	212	205	199	199
query99	1640	1303	1305	1303
Total cold run time: 319473 ms
Total hot run time: 197141 ms

@doris-robot
Copy link

doris-robot commented Apr 4, 2025

ClickBench: Total hot run time: 32.48 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 31b293d4f42e10b1b36acc2bbe96a556789cd550, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.63	0.11	0.09
query5	0.53	0.49	0.53
query6	1.13	0.72	0.73
query7	0.02	0.01	0.02
query8	0.04	0.05	0.03
query9	0.56	0.51	0.51
query10	0.54	0.54	0.54
query11	0.14	0.10	0.10
query12	0.14	0.12	0.10
query13	0.60	0.59	0.59
query14	2.75	2.75	2.89
query15	0.90	0.84	0.82
query16	0.39	0.39	0.38
query17	1.05	1.08	1.06
query18	0.24	0.23	0.22
query19	1.83	1.81	1.97
query20	0.01	0.01	0.01
query21	15.36	0.58	0.59
query22	2.86	2.03	2.38
query23	16.96	1.18	0.79
query24	2.51	1.14	1.57
query25	0.18	0.10	0.05
query26	0.59	0.14	0.14
query27	0.04	0.05	0.05
query28	10.32	0.55	0.45
query29	12.62	3.21	3.20
query30	0.24	0.06	0.06
query31	2.88	0.38	0.38
query32	3.26	0.45	0.45
query33	2.98	3.02	3.01
query34	17.18	4.50	4.48
query35	4.61	4.53	4.53
query36	0.66	0.48	0.49
query37	0.10	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.03	0.02
query40	0.16	0.13	0.13
query41	0.09	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.59 s
Total hot run time: 32.48 s

dataroaring
dataroaring approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 2c92722 into branch-3.0 Apr 4, 2025
29 of 32 checks passed
@morrySnow morrySnow deleted the 3.0_48078 branch April 7, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@morrySnow @Thearas @gavinchou @doris-robot @dataroaring