-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](Variant) handle scalar variant with none string root #37794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40179 ms |
TPC-DS: Total hot run time: 174073 ms |
ClickBench: Total hot run time: 32.19 s |
If columns is ColumnObject(Int32), root cast to ColumnString will result crash
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39977 ms |
TPC-DS: Total hot run time: 173887 ms |
cbb46d7 to
026dc72
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
2 similar comments
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39727 ms |
TPC-DS: Total hot run time: 174899 ms |
ClickBench: Total hot run time: 31.75 s |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40102 ms |
TPC-DS: Total hot run time: 173480 ms |
ClickBench: Total hot run time: 30.51 s |
xiaokang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Previous we allow invalid text as variant in PR apache#37794 and store as string type.But in encoding rowstore we CHECK the json is valid and store as jsonb binary field.In this PR we support the invalid json encoding as row store
…pe (apache#39394) Previous we allow invalid text as variant in PR apache#37794 and store as string type.But in encoding rowstore we CHECK the json is valid and store as jsonb binary field.In this PR we support the invalid json encoding as row store
…pe (apache#39394) Previous we allow invalid text as variant in PR apache#37794 and store as string type.But in encoding rowstore we CHECK the json is valid and store as jsonb binary field.In this PR we support the invalid json encoding as row store
Proposed changes
Issue Number: close #xxx