Skip to content

[Pick](Variant) pick some fix #37922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 5 commits into from
Jul 16, 2024
Merged

[Pick](Variant) pick some fix #37922

yiguolei merged 5 commits into from
Jul 16, 2024

Conversation

@eldenmoon
Copy link
Member

@eldenmoon eldenmoon commented Jul 16, 2024 •
edited
Loading

eldenmoon added 4 commits July 16, 2024 17:33
@eldenmoon
[Fix](Variant) ensure variant column finalized before reading the roo…
4f62297 
…t column (apache#37674)

…t column

Eg. segment 1 has no variant columns and fill the dst with default
value, which the variant columns's root is type nothing with n rows(not
finalized), then reading segment2 with the none finalized variant column
will lead to nullptr in `obj.get_root();`
@eldenmoon
[Refactor](Variant) should not call finalize in const functions (apac…
a6aad0a 
…he#37839)

`finalize` may change the inner data structure in ColumnObject, and lead
to heap use after free in some scenario

Issue Number: close #xxx

<!--Describe your changes.-->
@eldenmoon
[Feature](Variant) support export csv format (apache#37857)
12be29b
@eldenmoon
[Fix](Variant) handle scalar variant with none string root (apache#37794
532e14a 
)

1. If columns is ColumnObject(Int32), root cast to ColumnString will
result crash
2. variant with invalid json will be stored as raw string instead of
throwing exception
@doris-robot
Copy link

doris-robot commented Jul 16, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@eldenmoon eldenmoon changed the base branch from master to branch-2.1 July 16, 2024 09:37
@eldenmoon
Copy link
Member Author

eldenmoon commented Jul 16, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jul 16, 2024

TeamCity be ut coverage result:
Function Coverage: 36.45% (9240/25349)
Line Coverage: 28.00% (75518/269738)
Region Coverage: 26.82% (38824/144776)
Branch Coverage: 23.55% (19709/83674)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1bfb2d504be188774c9312a6faead230a2bd45a1_1bfb2d504be188774c9312a6faead230a2bd45a1/report/index.html

@yiguolei yiguolei merged commit b15ccdb into apache:branch-2.1 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring Awaiting requested review from dataroaring

@CalvinKirs CalvinKirs Awaiting requested review from CalvinKirs

@morningman morningman Awaiting requested review from morningman

@platoneko platoneko Awaiting requested review from platoneko

@gavinchou gavinchou Awaiting requested review from gavinchou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eldenmoon @doris-robot @yiguolei