[Fix](Row store) fix row store with invalid json string in variant type #39394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous we allow invalid text as variant in PR apache#37794 and store as string type.But in encoding rowstore we CHECK the json is valid and store as jsonb binary field.In this PR we support the invalid json encoding as row store
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 37983 ms |
TPC-H: Total hot run time: 37434 ms |
TPC-DS: Total hot run time: 189051 ms |
ClickBench: Total hot run time: 30.39 s |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
PR approved by at least one committer and no changes requested. |
xiaokang
reviewed
Aug 15, 2024
| bool succ = json_parser.parse(value_str.data(), value_str.size()); | ||
| // maybe more graceful, it is ok to check here since data could be parsed | ||
| CHECK(succ); | ||
| if (!succ) { |
Contributor
There was a problem hiding this comment.
if (succ) {
// write binary
} else {
// write string
}
2f48c66 to
323277a
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 38409 ms |
Contributor
|
PR approved by at least one committer and no changes requested. |
TPC-DS: Total hot run time: 196570 ms |
ClickBench: Total hot run time: 31.58 s |
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Aug 16, 2024
…pe (apache#39394) Previous we allow invalid text as variant in PR apache#37794 and store as string type.But in encoding rowstore we CHECK the json is valid and store as jsonb binary field.In this PR we support the invalid json encoding as row store
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Aug 16, 2024
…pe (apache#39394) Previous we allow invalid text as variant in PR apache#37794 and store as string type.But in encoding rowstore we CHECK the json is valid and store as jsonb binary field.In this PR we support the invalid json encoding as row store
eldenmoon
added a commit
that referenced
this pull request
Aug 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous we allow invalid text as variant in PR #37794 and store as string type.But in encoding rowstore we CHECK the json is valid and store as jsonb binary field.In this PR we support the invalid json encoding as row store
Proposed changes
Issue Number: close #xxx