[bugfix](topn) fix topn optimzation wrong result for NULL values #18121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
TeamCity pipeline, clickbench performance test result: |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
Contributor
|
PR approved by at least one committer and no changes requested. |
liaoxin01
pushed a commit
to liaoxin01/doris
that referenced
this pull request
Mar 31, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 31, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 31, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 31, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 31, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 31, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 31, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
luwei16
pushed a commit
to luwei16/incubator-doris
that referenced
this pull request
Apr 7, 2023
…x 17352 (apache#1565) commit 4e1e0ce Author: Kang <kxiao.tiger@gmail.com> Date: Fri Mar 31 10:01:34 2023 +0800 [bugfix](topn) fix topn optimzation wrong result for NULL values (apache#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node Author: Kang <kxiao.tiger@gmail.com> Date: Mon Mar 27 11:29:42 2023 +0800 [bugfix](inverted index)temporary disable skip read column data if it match inverted index (apache#18065) The optimization for skip reading column data if it match inverted index and only used in WHERE clause may get wrong result for complex SQL. This PR temporary disable the optimization and later PRs will resolve the problem fundamentality. Author: Kang <kxiao.tiger@gmail.com> Date: Wed Mar 8 14:18:26 2023 +0800 [bugfix](jsonb) Fix create mv using jsonb key cause be crash (apache#17430) Author: Kang <kxiao.tiger@gmail.com> Date: Fri Mar 3 21:00:49 2023 +0800 [improvement](inverted index)use reference to avoid bitmap copy for performance (apache#17352) Query runtime is reduced from 10s to 1s for a MATCH query that match 40 million rows out of 44 million rows.
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 25, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 25, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 27, 2023
…che#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node
xiaokang
added a commit
to xiaokang/doris
that referenced
this pull request
Jun 4, 2023
[bugfix](topn) fix topn optimzation wrong result for NULL values (apache#18121)
morningman
pushed a commit
that referenced
this pull request
Jun 6, 2023
1. add testcase for key topn opt 2. disable key topn opt only for DUP_KEYS and UNIQUE_KEYS with MOW 3. cherry pick some bugfix commit from master commit 58c5108 Author: Kang <kxiao.tiger@gmail.com> Date: Sun Feb 19 23:28:33 2023 +0800 [bugfix](topn) fix topn read_orderby_key_columns nullptr (#16896) commit 479272f Author: Kang <kxiao.tiger@gmail.com> Date: Fri Mar 31 10:02:07 2023 +0800 [bugfix](topn) fix topn optimzation wrong result for NULL values (#18121) commit d9924c9 Author: Kang <kxiao.tiger@gmail.com> Date: Fri Feb 10 12:56:33 2023 +0800 [Improvement](topn) add limit threashold session variable and fuzzy for topn optimizations (#16514) 1. add limit threshold for topn runtime pushdown and key topn optimization 2. use unified session variable topn_opt_limit_threshold for all topn optimizations 4. add fuzzy support for topn_opt_limit_threshold
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Jul 12, 2023
…20406) 1. add testcase for key topn opt 2. disable key topn opt only for DUP_KEYS and UNIQUE_KEYS with MOW 3. cherry pick some bugfix commit from master commit 58c5108 Author: Kang <kxiao.tiger@gmail.com> Date: Sun Feb 19 23:28:33 2023 +0800 [bugfix](topn) fix topn read_orderby_key_columns nullptr (apache#16896) commit 479272f Author: Kang <kxiao.tiger@gmail.com> Date: Fri Mar 31 10:02:07 2023 +0800 [bugfix](topn) fix topn optimzation wrong result for NULL values (apache#18121) commit d9924c9 Author: Kang <kxiao.tiger@gmail.com> Date: Fri Feb 10 12:56:33 2023 +0800 [Improvement](topn) add limit threashold session variable and fuzzy for topn optimizations (apache#16514) 1. add limit threshold for topn runtime pushdown and key topn optimization 2. use unified session variable topn_opt_limit_threshold for all topn optimizations 4. add fuzzy support for topn_opt_limit_threshold
swjtu-zhanglei
pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
…x 17352 (apache#1565) commit 4e1e0ce Author: Kang <kxiao.tiger@gmail.com> Date: Fri Mar 31 10:01:34 2023 +0800 [bugfix](topn) fix topn optimzation wrong result for NULL values (apache#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node Author: Kang <kxiao.tiger@gmail.com> Date: Mon Mar 27 11:29:42 2023 +0800 [bugfix](inverted index)temporary disable skip read column data if it match inverted index (apache#18065) The optimization for skip reading column data if it match inverted index and only used in WHERE clause may get wrong result for complex SQL. This PR temporary disable the optimization and later PRs will resolve the problem fundamentality. Author: Kang <kxiao.tiger@gmail.com> Date: Wed Mar 8 14:18:26 2023 +0800 [bugfix](jsonb) Fix create mv using jsonb key cause be crash (apache#17430) Author: Kang <kxiao.tiger@gmail.com> Date: Fri Mar 3 21:00:49 2023 +0800 [improvement](inverted index)use reference to avoid bitmap copy for performance (apache#17352) Query runtime is reduced from 10s to 1s for a MATCH query that match 40 million rows out of 44 million rows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...