[bugfix](topn) cherry pick key topn fixes for branch-1.2-lts #20406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or topn optimizations (apache#16514) 1. add limit threshold for topn runtime pushdown and key topn optimization 2. use unified session variable topn_opt_limit_threshold for all topn optimizations 3. add fuzzy support for topn_opt_limit_threshold
[bugfix](topn) fix topn optimzation wrong result for NULL values (apache#18121)
Contributor
Author
|
run buildall |
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Jul 12, 2023
…20406) 1. add testcase for key topn opt 2. disable key topn opt only for DUP_KEYS and UNIQUE_KEYS with MOW 3. cherry pick some bugfix commit from master commit 58c5108 Author: Kang <kxiao.tiger@gmail.com> Date: Sun Feb 19 23:28:33 2023 +0800 [bugfix](topn) fix topn read_orderby_key_columns nullptr (apache#16896) commit 479272f Author: Kang <kxiao.tiger@gmail.com> Date: Fri Mar 31 10:02:07 2023 +0800 [bugfix](topn) fix topn optimzation wrong result for NULL values (apache#18121) commit d9924c9 Author: Kang <kxiao.tiger@gmail.com> Date: Fri Feb 10 12:56:33 2023 +0800 [Improvement](topn) add limit threashold session variable and fuzzy for topn optimizations (apache#16514) 1. add limit threshold for topn runtime pushdown and key topn optimization 2. use unified session variable topn_opt_limit_threshold for all topn optimizations 4. add fuzzy support for topn_opt_limit_threshold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
commit 58c5108
Author: Kang kxiao.tiger@gmail.com
Date: Sun Feb 19 23:28:33 2023 +0800
commit 479272f
Author: Kang kxiao.tiger@gmail.com
Date: Fri Mar 31 10:02:07 2023 +0800
commit d9924c9
Author: Kang kxiao.tiger@gmail.com
Date: Fri Feb 10 12:56:33 2023 +0800
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...