Skip to content

Conversation

@xiaokang
Copy link
Contributor

@xiaokang xiaokang commented Mar 2, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

Query runtime is reduced from 10s to 1s for a MATCH query that match 40 million rows out of 44 million rows.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xiaokang
Copy link
Contributor Author

xiaokang commented Mar 2, 2023

run buildall

@Tanya-W
Copy link
Contributor

Tanya-W commented Mar 2, 2023

LGTM

Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

clang-tidy review says "All clean, LGTM! 👍"

@qidaye qidaye merged commit b501a9e into apache:master Mar 3, 2023
xiaokang added a commit to xiaokang/doris that referenced this pull request Mar 6, 2023
…erformance (apache#17352)

Query runtime is reduced from 10s to 1s for a MATCH query that match 40 million rows out of 44 million rows.
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 9, 2023
…erformance (apache#17352)

Query runtime is reduced from 10s to 1s for a MATCH query that match 40 million rows out of 44 million rows.
luwei16 pushed a commit to luwei16/incubator-doris that referenced this pull request Apr 7, 2023
…x 17352 (apache#1565)


commit 4e1e0ce
Author: Kang <kxiao.tiger@gmail.com>
Date:   Fri Mar 31 10:01:34 2023 +0800

    [bugfix](topn) fix topn optimzation wrong result for NULL values (apache#18121)
    
    1. add PassNullPredicate to fix topn wrong result for NULL values
    2. refactor RuntimePredicate to avoid using TCondition
    3. refactor using ordering_exprs in fe and vsort_node


Author: Kang <kxiao.tiger@gmail.com>
Date:   Mon Mar 27 11:29:42 2023 +0800

    [bugfix](inverted index)temporary disable skip read column data if it match inverted index (apache#18065)
    
    The optimization for skip reading column data if it match inverted index and only used in WHERE clause may get wrong result for complex SQL.
    
    This PR temporary disable the optimization and later PRs will resolve the problem fundamentality.


Author: Kang <kxiao.tiger@gmail.com>
Date:   Wed Mar 8 14:18:26 2023 +0800

    [bugfix](jsonb) Fix create mv using jsonb key cause be crash (apache#17430)


Author: Kang <kxiao.tiger@gmail.com>
Date:   Fri Mar 3 21:00:49 2023 +0800

    [improvement](inverted index)use reference to avoid bitmap copy for performance (apache#17352)
    
    Query runtime is reduced from 10s to 1s for a MATCH query that match 40 million rows out of 44 million rows.
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
…erformance (apache#17352)

Query runtime is reduced from 10s to 1s for a MATCH query that match 40 million rows out of 44 million rows.
swjtu-zhanglei pushed a commit to swjtu-zhanglei/incubator-doris that referenced this pull request Jul 25, 2023
…x 17352 (apache#1565)

commit 4e1e0ce
Author: Kang <kxiao.tiger@gmail.com>
Date:   Fri Mar 31 10:01:34 2023 +0800

    [bugfix](topn) fix topn optimzation wrong result for NULL values (apache#18121)

    1. add PassNullPredicate to fix topn wrong result for NULL values
    2. refactor RuntimePredicate to avoid using TCondition
    3. refactor using ordering_exprs in fe and vsort_node

Author: Kang <kxiao.tiger@gmail.com>
Date:   Mon Mar 27 11:29:42 2023 +0800

    [bugfix](inverted index)temporary disable skip read column data if it match inverted index (apache#18065)

    The optimization for skip reading column data if it match inverted index and only used in WHERE clause may get wrong result for complex SQL.

    This PR temporary disable the optimization and later PRs will resolve the problem fundamentality.

Author: Kang <kxiao.tiger@gmail.com>
Date:   Wed Mar 8 14:18:26 2023 +0800

    [bugfix](jsonb) Fix create mv using jsonb key cause be crash (apache#17430)

Author: Kang <kxiao.tiger@gmail.com>
Date:   Fri Mar 3 21:00:49 2023 +0800

    [improvement](inverted index)use reference to avoid bitmap copy for performance (apache#17352)

    Query runtime is reduced from 10s to 1s for a MATCH query that match 40 million rows out of 44 million rows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants