-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Enhencement](inverted index) use reference to avoid bitmap copy for performance #17352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
Contributor
|
LGTM |
qidaye
approved these changes
Mar 2, 2023
Contributor
qidaye
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
xiaokang
added a commit
to xiaokang/doris
that referenced
this pull request
Mar 6, 2023
…erformance (apache#17352) Query runtime is reduced from 10s to 1s for a MATCH query that match 40 million rows out of 44 million rows.
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 9, 2023
…erformance (apache#17352) Query runtime is reduced from 10s to 1s for a MATCH query that match 40 million rows out of 44 million rows.
luwei16
pushed a commit
to luwei16/incubator-doris
that referenced
this pull request
Apr 7, 2023
…x 17352 (apache#1565) commit 4e1e0ce Author: Kang <kxiao.tiger@gmail.com> Date: Fri Mar 31 10:01:34 2023 +0800 [bugfix](topn) fix topn optimzation wrong result for NULL values (apache#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node Author: Kang <kxiao.tiger@gmail.com> Date: Mon Mar 27 11:29:42 2023 +0800 [bugfix](inverted index)temporary disable skip read column data if it match inverted index (apache#18065) The optimization for skip reading column data if it match inverted index and only used in WHERE clause may get wrong result for complex SQL. This PR temporary disable the optimization and later PRs will resolve the problem fundamentality. Author: Kang <kxiao.tiger@gmail.com> Date: Wed Mar 8 14:18:26 2023 +0800 [bugfix](jsonb) Fix create mv using jsonb key cause be crash (apache#17430) Author: Kang <kxiao.tiger@gmail.com> Date: Fri Mar 3 21:00:49 2023 +0800 [improvement](inverted index)use reference to avoid bitmap copy for performance (apache#17352) Query runtime is reduced from 10s to 1s for a MATCH query that match 40 million rows out of 44 million rows.
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
…erformance (apache#17352) Query runtime is reduced from 10s to 1s for a MATCH query that match 40 million rows out of 44 million rows.
swjtu-zhanglei
pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
…x 17352 (apache#1565) commit 4e1e0ce Author: Kang <kxiao.tiger@gmail.com> Date: Fri Mar 31 10:01:34 2023 +0800 [bugfix](topn) fix topn optimzation wrong result for NULL values (apache#18121) 1. add PassNullPredicate to fix topn wrong result for NULL values 2. refactor RuntimePredicate to avoid using TCondition 3. refactor using ordering_exprs in fe and vsort_node Author: Kang <kxiao.tiger@gmail.com> Date: Mon Mar 27 11:29:42 2023 +0800 [bugfix](inverted index)temporary disable skip read column data if it match inverted index (apache#18065) The optimization for skip reading column data if it match inverted index and only used in WHERE clause may get wrong result for complex SQL. This PR temporary disable the optimization and later PRs will resolve the problem fundamentality. Author: Kang <kxiao.tiger@gmail.com> Date: Wed Mar 8 14:18:26 2023 +0800 [bugfix](jsonb) Fix create mv using jsonb key cause be crash (apache#17430) Author: Kang <kxiao.tiger@gmail.com> Date: Fri Mar 3 21:00:49 2023 +0800 [improvement](inverted index)use reference to avoid bitmap copy for performance (apache#17352) Query runtime is reduced from 10s to 1s for a MATCH query that match 40 million rows out of 44 million rows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Query runtime is reduced from 10s to 1s for a MATCH query that match 40 million rows out of 44 million rows.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...