Refactor architecture by Technoboy- · Pull Request #1926 · apache/dolphinscheduler

Technoboy- · 2020-02-10T12:40:32Z

Tips

Thanks very much for contributing to Apache DolphinScheduler.
Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.

What is the purpose of the pull request

(For example: This pull request adds checkstyle plugin.)

Brief change log

(for example:)

Add maven-checkstyle-plugin to root pom.xml

Verify this pull request

(Please pick either of the following options)

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

Added dolphinscheduler-dao tests for end-to-end.
Added CronUtilsTest to verify the change.
Manually verified the change by testing locally.

merge

…r into dev

#1871 correct spelling (#1872)

some updates for TaskQueueZkImpl (#1874)

remove unused properties in pom (#1876)

1. remove tomcat dependency 2. remove combined_logback.xml in api module 3. format pom.xml for not aligning

some updates for pom (#1879)

1. add jsp-2.1 dependency 2. remove jasper-runtime dependency

…r into dev

* add stringutils ut

Continue to finish the rest works, add the cache feature for dependence,mr,python,sub_process,procedure and shell.

* class overrides equals() and should therefore also override hashCode() * #1862 add modify user in process difinition list * #1862 add pg-1.2.2 ddl.sql * modify ScriptRunnerTest * add updateProessDifinition UT * modify updateProcessDifinition UT * modify updateProcessDifinition UT * modify mysql 1.2.2 ddl.sql&dml.sql * add scope test to mysql in pom * modify pg-1.2.2 ddl.sql

merge

1，remove dolphinscheduler-rpc module 2，add dolphinscheduler-remote m…

codecov-io · 2020-02-10T12:45:12Z

Codecov Report

Merging #1926 into refactor-architecture will decrease coverage by 1.46%.
The diff coverage is 2.94%.

@@                    Coverage Diff                    @@
##           refactor-architecture    #1926      +/-   ##
=========================================================
- Coverage                  25.19%   23.72%   -1.47%     
=========================================================
  Files                        298      323      +25     
  Lines                      14330    14773     +443     
  Branches                    2350     2397      +47     
=========================================================
- Hits                        3610     3505     -105     
- Misses                     10268    10851     +583     
+ Partials                     452      417      -35

Impacted Files	Coverage Δ
...olphinscheduler/service/queue/TaskQueueZkImpl.java	`0% <ø> (ø)`
.../dolphinscheduler/service/zk/AbstractZKClient.java	`0% <ø> (ø)`
...nscheduler/service/zk/DefaultEnsembleProvider.java	`0% <ø> (ø)`
...dolphinscheduler/server/monitor/ZKMonitorImpl.java	`0% <ø> (ø)`	⬆️
...uler/api/controller/ProcessInstanceController.java	`1.23% <ø> (ø)`	⬆️
...inscheduler/service/quartz/cron/AbstractCycle.java	`0% <ø> (ø)`
...uler/remote/command/ExecuteTaskRequestCommand.java	`0% <ø> (ø)`
...lphinscheduler/service/quartz/QuartzExecutors.java	`0% <ø> (ø)`
...he/dolphinscheduler/server/utils/RemoveZKNode.java	`0% <ø> (ø)`	⬆️
...phinscheduler/api/service/TaskInstanceService.java	`2.63% <ø> (ø)`	⬆️
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b35c4c...dc75521. Read the comment docs.

sonarqubecloud · 2020-02-10T12:56:53Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

2.0% Coverage
0.0% Duplication

qiaozhanwei

+1

* 1，remove dolphinscheduler-rpc module 2，add dolphinscheduler-remote module 3，add dolphinscheduler-service module 4，refactor LoggerServer module (#1925) * 1，remove dolphinscheduler-rpc module 2，add dolphinscheduler-remote module 3，add dolphinscheduler-service module 4，refactor LoggerServer module * ProcessUtils modify * Refactor architecture (#1926) * move version to parent pom * move version properties to parent pom for easy management * remove freemarker dependency * delete CombinedApplicationServer * #1871 correct spelling * #1873 some updates for TaskQueueZkImpl * #1875 remove unused properties in pom * #1878 1. remove tomcat dependency 2. remove combined_logback.xml in api module 3. format pom.xml for not aligning * #1885 fix api server startup failure 1. add jsp-2.1 dependency 2. remove jasper-runtime dependency * add stringutils ut (#1921) * add stringutils ut * Newfeature for #1675. (#1908) Continue to finish the rest works, add the cache feature for dependence,mr,python,sub_process,procedure and shell. * Add modify user name for process definition (#1919) * class overrides equals() and should therefore also override hashCode() * #1862 add modify user in process difinition list * #1862 add pg-1.2.2 ddl.sql * modify ScriptRunnerTest * add updateProessDifinition UT * modify updateProcessDifinition UT * modify updateProcessDifinition UT * modify mysql 1.2.2 ddl.sql&dml.sql * add scope test to mysql in pom * modify pg-1.2.2 ddl.sql * refactor module * updates Co-authored-by: khadgarmage <khadgar.mage@outlook.com> Co-authored-by: zhukai <boness@qq.com> Co-authored-by: Yelli <amarantine@my.com> * dolphinscheduler-common remove spring (#1931) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * SpringApplicationContext class title add license (#1932) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * add license (#1934) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * Refactor architecture (#1936) * move datasource classes to dao module * fix send4LetterWord bug * LoggerServiceTest remove ProcessDao (#1944) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * LoggerServiceTest remove ProcessDao * exclude jasper-compiler in case of runtime conflict (#1938) * move datasource classes to dao module * fix send4LetterWord bug * exclude jasper-compiler in case of runtime conflict * DataAnaylysisServiceTest and ProcessDefinitionService modify * remote module add comment * OSUtilsTest modify * add finally block to close channel (#1951) * move datasource classes to dao module * fix send4LetterWord bug * exclude jasper-compiler in case of runtime conflict * add finally block to close channel Co-authored-by: Tboy <technoboy@yeah.net> Co-authored-by: khadgarmage <khadgar.mage@outlook.com> Co-authored-by: zhukai <boness@qq.com> Co-authored-by: Yelli <amarantine@my.com>

…dify (#1960) * 1，remove dolphinscheduler-rpc module 2，add dolphinscheduler-remote module 3，add dolphinscheduler-service module 4，refactor LoggerServer module (#1925) * 1，remove dolphinscheduler-rpc module 2，add dolphinscheduler-remote module 3，add dolphinscheduler-service module 4，refactor LoggerServer module * ProcessUtils modify * Refactor architecture (#1926) * move version to parent pom * move version properties to parent pom for easy management * remove freemarker dependency * delete CombinedApplicationServer * #1871 correct spelling * #1873 some updates for TaskQueueZkImpl * #1875 remove unused properties in pom * #1878 1. remove tomcat dependency 2. remove combined_logback.xml in api module 3. format pom.xml for not aligning * #1885 fix api server startup failure 1. add jsp-2.1 dependency 2. remove jasper-runtime dependency * add stringutils ut (#1921) * add stringutils ut * Newfeature for #1675. (#1908) Continue to finish the rest works, add the cache feature for dependence,mr,python,sub_process,procedure and shell. * Add modify user name for process definition (#1919) * class overrides equals() and should therefore also override hashCode() * #1862 add modify user in process difinition list * #1862 add pg-1.2.2 ddl.sql * modify ScriptRunnerTest * add updateProessDifinition UT * modify updateProcessDifinition UT * modify updateProcessDifinition UT * modify mysql 1.2.2 ddl.sql&dml.sql * add scope test to mysql in pom * modify pg-1.2.2 ddl.sql * refactor module * updates Co-authored-by: khadgarmage <khadgar.mage@outlook.com> Co-authored-by: zhukai <boness@qq.com> Co-authored-by: Yelli <amarantine@my.com> * dolphinscheduler-common remove spring (#1931) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * SpringApplicationContext class title add license (#1932) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * add license (#1934) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * Refactor architecture (#1936) * move datasource classes to dao module * fix send4LetterWord bug * LoggerServiceTest remove ProcessDao (#1944) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * LoggerServiceTest remove ProcessDao * exclude jasper-compiler in case of runtime conflict (#1938) * move datasource classes to dao module * fix send4LetterWord bug * exclude jasper-compiler in case of runtime conflict * DataAnaylysisServiceTest and ProcessDefinitionService modify * remote module add comment * OSUtilsTest modify * add finally block to close channel (#1951) * move datasource classes to dao module * fix send4LetterWord bug * exclude jasper-compiler in case of runtime conflict * add finally block to close channel * 1，quartz.properties add conf category 2，dolphinscheduler-daemon.sh modify * dolphinscheduler-binary.xml modify Co-authored-by: Tboy <technoboy@yeah.net> Co-authored-by: khadgarmage <khadgar.mage@outlook.com> Co-authored-by: zhukai <boness@qq.com> Co-authored-by: Yelli <amarantine@my.com>

* 1，remove dolphinscheduler-rpc module 2，add dolphinscheduler-remote module 3，add dolphinscheduler-service module 4，refactor LoggerServer module (#1925) * 1，remove dolphinscheduler-rpc module 2，add dolphinscheduler-remote module 3，add dolphinscheduler-service module 4，refactor LoggerServer module * ProcessUtils modify * Refactor architecture (#1926) * move version to parent pom * move version properties to parent pom for easy management * remove freemarker dependency * delete CombinedApplicationServer * #1871 correct spelling * #1873 some updates for TaskQueueZkImpl * #1875 remove unused properties in pom * #1878 1. remove tomcat dependency 2. remove combined_logback.xml in api module 3. format pom.xml for not aligning * #1885 fix api server startup failure 1. add jsp-2.1 dependency 2. remove jasper-runtime dependency * add stringutils ut (#1921) * add stringutils ut * Newfeature for #1675. (#1908) Continue to finish the rest works, add the cache feature for dependence,mr,python,sub_process,procedure and shell. * Add modify user name for process definition (#1919) * class overrides equals() and should therefore also override hashCode() * #1862 add modify user in process difinition list * #1862 add pg-1.2.2 ddl.sql * modify ScriptRunnerTest * add updateProessDifinition UT * modify updateProcessDifinition UT * modify updateProcessDifinition UT * modify mysql 1.2.2 ddl.sql&dml.sql * add scope test to mysql in pom * modify pg-1.2.2 ddl.sql * refactor module * updates Co-authored-by: khadgarmage <khadgar.mage@outlook.com> Co-authored-by: zhukai <boness@qq.com> Co-authored-by: Yelli <amarantine@my.com> * dolphinscheduler-common remove spring (#1931) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * SpringApplicationContext class title add license (#1932) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * add license (#1934) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * move datasource classes to dao module * fix send4LetterWord bug * Refactor architecture (#1936) * move datasource classes to dao module * fix send4LetterWord bug * exclude jasper-compiler in case of runtime conflict * LoggerServiceTest remove ProcessDao (#1944) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * LoggerServiceTest remove ProcessDao * exclude jasper-compiler in case of runtime conflict (#1938) * move datasource classes to dao module * fix send4LetterWord bug * exclude jasper-compiler in case of runtime conflict * DataAnaylysisServiceTest and ProcessDefinitionService modify * remote module add comment * OSUtilsTest modify * add finally block to close channel * add finally block to close channel (#1951) * move datasource classes to dao module * fix send4LetterWord bug * exclude jasper-compiler in case of runtime conflict * add finally block to close channel * refactor log client service * add sendSync method * 1，quartz.properties add conf category 2，dolphinscheduler-daemon.sh modify * dolphinscheduler-binary.xml modify * add sendAsync method (#1962) * add sendAsync method * add sendAsync method * 1，add sendAsync method 2，refactor LoggerClient * LogClientService modify Co-authored-by: Tboy <technoboy@yeah.net> Co-authored-by: khadgarmage <khadgar.mage@outlook.com> Co-authored-by: zhukai <boness@qq.com> Co-authored-by: Yelli <amarantine@my.com>

Technoboy- and others added 28 commits January 6, 2020 11:15

move version to parent pom

5ebb02f

Merge pull request #1 from apache/dev

cf2b176

merge

Merge pull request #2 from apache/dev

07e5cef

merge

move version properties to parent pom for easy management

192133e

Merge pull request #3 from apache/dev

8e7afc3

merge

Merge pull request #4 from apache/dev

a178f69

merge

remove freemarker dependency

0e4d9d2

Merge pull request #5 from apache/dev

228c40c

merge

delete CombinedApplicationServer

ad789c8

Merge pull request #1 from apache/dev

c2f306e

merge

Merge branch 'dev' of github.com:Technoboy-/incubator-dolphinschedule…

3ac1010

…r into dev

#1871 correct spelling

6a4a0c3

Merge pull request #2 from apache/dev

0c335c2

#1871 correct spelling (#1872)

#1873 some updates for TaskQueueZkImpl

e83489c

Merge pull request #3 from apache/dev

563fe3e

some updates for TaskQueueZkImpl (#1874)

#1875 remove unused properties in pom

5fb4ee7

Merge pull request #4 from apache/dev

4a7153b

remove unused properties in pom (#1876)

#1878

6d15190

1. remove tomcat dependency 2. remove combined_logback.xml in api module 3. format pom.xml for not aligning

Merge pull request #5 from apache/dev

69ac8ea

some updates for pom (#1879)

#1885 fix api server startup failure

027329b

1. add jsp-2.1 dependency 2. remove jasper-runtime dependency

Merge branch 'dev' of github.com:Technoboy-/incubator-dolphinschedule…

ff1410b

…r into dev

add stringutils ut (#1921)

c447bb4

* add stringutils ut

Newfeature for #1675. (#1908)

bcc7347

Continue to finish the rest works, add the cache feature for dependence,mr,python,sub_process,procedure and shell.

Merge pull request #7 from apache/dev

8b35c4c

merge

Merge pull request #8 from apache/refactor-architecture

811f2a0

1，remove dolphinscheduler-rpc module 2，add dolphinscheduler-remote m…

refactor module

26a79db

updates

dc75521

Technoboy- requested a review from qiaozhanwei February 10, 2020 12:40

qiaozhanwei approved these changes Feb 10, 2020

View reviewed changes

qiaozhanwei merged commit 29f2b41 into apache:refactor-architecture Feb 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor architecture#1926

Refactor architecture#1926
qiaozhanwei merged 28 commits intoapache:refactor-architecturefrom
Technoboy-:refactor-architecture

Technoboy- commented Feb 10, 2020

Uh oh!

codecov-io commented Feb 10, 2020 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Feb 10, 2020

Uh oh!

qiaozhanwei left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

Technoboy- commented Feb 10, 2020

Tips

What is the purpose of the pull request

Brief change log

Verify this pull request

Uh oh!

codecov-io commented Feb 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sonarqubecloud bot commented Feb 10, 2020

Uh oh!

qiaozhanwei left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov-io commented Feb 10, 2020 •

edited

Loading