Add modify user name for process definition by Eights-Li · Pull Request #1919 · apache/dolphinscheduler

Eights-Li · 2020-02-09T14:33:19Z

What is the purpose of the pull request

#1862
Add modify user name for process definition

Brief change log

Edit api/service/ProcessDefinitionService.java
Edit common/utils/ScriptRunner.java
Edit common/utils/ScriptRunnerTest.java
Edit src/js/conf/home/pages/projects/pages/definition/pages/list/_source/list.vue
Add 1.2.2 mysql and pg ddl.sql&dml.sql

…duler into dev

codecov-io · 2020-02-09T15:42:15Z

Codecov Report

Merging #1919 into dev will increase coverage by 1.36%.
The diff coverage is 64.28%.

@@            Coverage Diff             @@
##              dev    #1919      +/-   ##
==========================================
+ Coverage   23.71%   25.08%   +1.36%     
==========================================
  Files         299      298       -1     
  Lines       14406    14395      -11     
  Branches     2374     2376       +2     
==========================================
+ Hits         3417     3611     +194     
+ Misses      10595    10330     -265     
- Partials      394      454      +60

Impacted Files	Coverage Δ
...dolphinscheduler/dao/entity/ProcessDefinition.java	`0% <ø> (ø)`	⬆️
...olphinscheduler/api/controller/BaseController.java	`3.79% <0%> (+0.13%)`	⬆️
...er/common/utils/placeholder/BusinessTimeUtils.java	`78.57% <0%> (-13.1%)`	⬇️
.../dolphinscheduler/api/service/ExecutorService.java	`31.57% <100%> (-0.3%)`	⬇️
...che/dolphinscheduler/dao/utils/cron/CronUtils.java	`90.47% <100%> (+90.47%)`	⬆️
...heduler/server/master/runner/MasterExecThread.java	`13.11% <100%> (-0.19%)`	⬇️
...scheduler/alert/template/AlertTemplateFactory.java	`57.14% <0%> (+14.28%)`	⬆️
...cheduler/api/service/ProcessDefinitionService.java	`40.3% <0%> (+4.59%)`	⬆️
.../dolphinscheduler/dao/utils/cron/CycleFactory.java	`25% <0%> (+25%)`	⬆️
...dolphinscheduler/dao/utils/cron/AbstractCycle.java	`50% <0%> (+50%)`	⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 842ea32...5a82e6f. Read the comment docs.

lgcareer · 2020-02-10T05:51:41Z

...hinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/ScriptRunner.java

                                ResultSetMetaData md = rs.getMetaData();
                                int cols = md.getColumnCount();
-                                for (int i = 0; i < cols; i++) {
+                                for (int i = 1; i < cols; i++) {


why change this place,if change this,Whether execute success when upgrade in mysql ?

because in pgsql: The number of columns starts from "1" and cannot start from "0".
i have test this modify in mysql-5.6 and pg-9.6

OK,It's great!

lgcareer · 2020-02-10T05:56:25Z

sql/upgrade/1.2.2_schema/mysql/dolphinscheduler_dml.sql

+*/
+SET sql_mode=(SELECT REPLACE(@@sql_mode,'ONLY_FULL_GROUP_BY',''));
+SET FOREIGN_KEY_CHECKS=0;
+UPDATE QRTZ_CRON_TRIGGERS SET SCHED_NAME='DolphinScheduler' WHERE SCHED_NAME='EasyScheduler';


the follow sqls are all execute sql fo QUARTZ,they are already exist in version 1.2.0,So nedd not execute again

thx, i will modify it~

break60 · 2020-02-10T06:56:27Z

+1

sonarqubecloud · 2020-02-10T07:01:44Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

64.7% Coverage
2.7% Duplication

davidzollo

+1

* move version to parent pom * move version properties to parent pom for easy management * remove freemarker dependency * delete CombinedApplicationServer * #1871 correct spelling * #1873 some updates for TaskQueueZkImpl * #1875 remove unused properties in pom * #1878 1. remove tomcat dependency 2. remove combined_logback.xml in api module 3. format pom.xml for not aligning * #1885 fix api server startup failure 1. add jsp-2.1 dependency 2. remove jasper-runtime dependency * add stringutils ut (#1921) * add stringutils ut * Newfeature for #1675. (#1908) Continue to finish the rest works, add the cache feature for dependence,mr,python,sub_process,procedure and shell. * Add modify user name for process definition (#1919) * class overrides equals() and should therefore also override hashCode() * #1862 add modify user in process difinition list * #1862 add pg-1.2.2 ddl.sql * modify ScriptRunnerTest * add updateProessDifinition UT * modify updateProcessDifinition UT * modify updateProcessDifinition UT * modify mysql 1.2.2 ddl.sql&dml.sql * add scope test to mysql in pom * modify pg-1.2.2 ddl.sql * refactor module * updates Co-authored-by: khadgarmage <khadgar.mage@outlook.com> Co-authored-by: zhukai <boness@qq.com> Co-authored-by: Yelli <amarantine@my.com>

* 1，remove dolphinscheduler-rpc module 2，add dolphinscheduler-remote module 3，add dolphinscheduler-service module 4，refactor LoggerServer module (#1925) * 1，remove dolphinscheduler-rpc module 2，add dolphinscheduler-remote module 3，add dolphinscheduler-service module 4，refactor LoggerServer module * ProcessUtils modify * Refactor architecture (#1926) * move version to parent pom * move version properties to parent pom for easy management * remove freemarker dependency * delete CombinedApplicationServer * #1871 correct spelling * #1873 some updates for TaskQueueZkImpl * #1875 remove unused properties in pom * #1878 1. remove tomcat dependency 2. remove combined_logback.xml in api module 3. format pom.xml for not aligning * #1885 fix api server startup failure 1. add jsp-2.1 dependency 2. remove jasper-runtime dependency * add stringutils ut (#1921) * add stringutils ut * Newfeature for #1675. (#1908) Continue to finish the rest works, add the cache feature for dependence,mr,python,sub_process,procedure and shell. * Add modify user name for process definition (#1919) * class overrides equals() and should therefore also override hashCode() * #1862 add modify user in process difinition list * #1862 add pg-1.2.2 ddl.sql * modify ScriptRunnerTest * add updateProessDifinition UT * modify updateProcessDifinition UT * modify updateProcessDifinition UT * modify mysql 1.2.2 ddl.sql&dml.sql * add scope test to mysql in pom * modify pg-1.2.2 ddl.sql * refactor module * updates Co-authored-by: khadgarmage <khadgar.mage@outlook.com> Co-authored-by: zhukai <boness@qq.com> Co-authored-by: Yelli <amarantine@my.com> * dolphinscheduler-common remove spring (#1931) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * SpringApplicationContext class title add license (#1932) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * add license (#1934) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * Refactor architecture (#1936) * move datasource classes to dao module * fix send4LetterWord bug * LoggerServiceTest remove ProcessDao (#1944) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * LoggerServiceTest remove ProcessDao * exclude jasper-compiler in case of runtime conflict (#1938) * move datasource classes to dao module * fix send4LetterWord bug * exclude jasper-compiler in case of runtime conflict * DataAnaylysisServiceTest and ProcessDefinitionService modify * remote module add comment * OSUtilsTest modify * add finally block to close channel (#1951) * move datasource classes to dao module * fix send4LetterWord bug * exclude jasper-compiler in case of runtime conflict * add finally block to close channel Co-authored-by: Tboy <technoboy@yeah.net> Co-authored-by: khadgarmage <khadgar.mage@outlook.com> Co-authored-by: zhukai <boness@qq.com> Co-authored-by: Yelli <amarantine@my.com>

…dify (#1960) * 1，remove dolphinscheduler-rpc module 2，add dolphinscheduler-remote module 3，add dolphinscheduler-service module 4，refactor LoggerServer module (#1925) * 1，remove dolphinscheduler-rpc module 2，add dolphinscheduler-remote module 3，add dolphinscheduler-service module 4，refactor LoggerServer module * ProcessUtils modify * Refactor architecture (#1926) * move version to parent pom * move version properties to parent pom for easy management * remove freemarker dependency * delete CombinedApplicationServer * #1871 correct spelling * #1873 some updates for TaskQueueZkImpl * #1875 remove unused properties in pom * #1878 1. remove tomcat dependency 2. remove combined_logback.xml in api module 3. format pom.xml for not aligning * #1885 fix api server startup failure 1. add jsp-2.1 dependency 2. remove jasper-runtime dependency * add stringutils ut (#1921) * add stringutils ut * Newfeature for #1675. (#1908) Continue to finish the rest works, add the cache feature for dependence,mr,python,sub_process,procedure and shell. * Add modify user name for process definition (#1919) * class overrides equals() and should therefore also override hashCode() * #1862 add modify user in process difinition list * #1862 add pg-1.2.2 ddl.sql * modify ScriptRunnerTest * add updateProessDifinition UT * modify updateProcessDifinition UT * modify updateProcessDifinition UT * modify mysql 1.2.2 ddl.sql&dml.sql * add scope test to mysql in pom * modify pg-1.2.2 ddl.sql * refactor module * updates Co-authored-by: khadgarmage <khadgar.mage@outlook.com> Co-authored-by: zhukai <boness@qq.com> Co-authored-by: Yelli <amarantine@my.com> * dolphinscheduler-common remove spring (#1931) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * SpringApplicationContext class title add license (#1932) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * add license (#1934) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * Refactor architecture (#1936) * move datasource classes to dao module * fix send4LetterWord bug * LoggerServiceTest remove ProcessDao (#1944) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * LoggerServiceTest remove ProcessDao * exclude jasper-compiler in case of runtime conflict (#1938) * move datasource classes to dao module * fix send4LetterWord bug * exclude jasper-compiler in case of runtime conflict * DataAnaylysisServiceTest and ProcessDefinitionService modify * remote module add comment * OSUtilsTest modify * add finally block to close channel (#1951) * move datasource classes to dao module * fix send4LetterWord bug * exclude jasper-compiler in case of runtime conflict * add finally block to close channel * 1，quartz.properties add conf category 2，dolphinscheduler-daemon.sh modify * dolphinscheduler-binary.xml modify Co-authored-by: Tboy <technoboy@yeah.net> Co-authored-by: khadgarmage <khadgar.mage@outlook.com> Co-authored-by: zhukai <boness@qq.com> Co-authored-by: Yelli <amarantine@my.com>

* 1，remove dolphinscheduler-rpc module 2，add dolphinscheduler-remote module 3，add dolphinscheduler-service module 4，refactor LoggerServer module (#1925) * 1，remove dolphinscheduler-rpc module 2，add dolphinscheduler-remote module 3，add dolphinscheduler-service module 4，refactor LoggerServer module * ProcessUtils modify * Refactor architecture (#1926) * move version to parent pom * move version properties to parent pom for easy management * remove freemarker dependency * delete CombinedApplicationServer * #1871 correct spelling * #1873 some updates for TaskQueueZkImpl * #1875 remove unused properties in pom * #1878 1. remove tomcat dependency 2. remove combined_logback.xml in api module 3. format pom.xml for not aligning * #1885 fix api server startup failure 1. add jsp-2.1 dependency 2. remove jasper-runtime dependency * add stringutils ut (#1921) * add stringutils ut * Newfeature for #1675. (#1908) Continue to finish the rest works, add the cache feature for dependence,mr,python,sub_process,procedure and shell. * Add modify user name for process definition (#1919) * class overrides equals() and should therefore also override hashCode() * #1862 add modify user in process difinition list * #1862 add pg-1.2.2 ddl.sql * modify ScriptRunnerTest * add updateProessDifinition UT * modify updateProcessDifinition UT * modify updateProcessDifinition UT * modify mysql 1.2.2 ddl.sql&dml.sql * add scope test to mysql in pom * modify pg-1.2.2 ddl.sql * refactor module * updates Co-authored-by: khadgarmage <khadgar.mage@outlook.com> Co-authored-by: zhukai <boness@qq.com> Co-authored-by: Yelli <amarantine@my.com> * dolphinscheduler-common remove spring (#1931) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * SpringApplicationContext class title add license (#1932) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * add license (#1934) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * move datasource classes to dao module * fix send4LetterWord bug * Refactor architecture (#1936) * move datasource classes to dao module * fix send4LetterWord bug * exclude jasper-compiler in case of runtime conflict * LoggerServiceTest remove ProcessDao (#1944) * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * dolphinscheduler-common remove spring * LoggerServiceTest remove ProcessDao * exclude jasper-compiler in case of runtime conflict (#1938) * move datasource classes to dao module * fix send4LetterWord bug * exclude jasper-compiler in case of runtime conflict * DataAnaylysisServiceTest and ProcessDefinitionService modify * remote module add comment * OSUtilsTest modify * add finally block to close channel * add finally block to close channel (#1951) * move datasource classes to dao module * fix send4LetterWord bug * exclude jasper-compiler in case of runtime conflict * add finally block to close channel * refactor log client service * add sendSync method * 1，quartz.properties add conf category 2，dolphinscheduler-daemon.sh modify * dolphinscheduler-binary.xml modify * add sendAsync method (#1962) * add sendAsync method * add sendAsync method * 1，add sendAsync method 2，refactor LoggerClient * LogClientService modify Co-authored-by: Tboy <technoboy@yeah.net> Co-authored-by: khadgarmage <khadgar.mage@outlook.com> Co-authored-by: zhukai <boness@qq.com> Co-authored-by: Yelli <amarantine@my.com>

Eights-Li added 8 commits February 2, 2020 22:20

class overrides equals() and should therefore also override hashCode()

6c5ceba

Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…

60e9c62

…duler into dev

Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…

5f702ea

…duler into dev

#1862 add modify user in process difinition list

fb364dd

#1862 add pg-1.2.2 ddl.sql

842ea32

Merge branch 'dev' of https://github.com/apache/incubator-dolphinsche…

23130ed

…duler into dev

modify ScriptRunnerTest

156b72d

add updateProessDifinition UT

947a570

Eights-Li added 2 commits February 9, 2020 23:59

modify updateProcessDifinition UT

615570f

modify updateProcessDifinition UT

f3f5511

Eights-Li requested a review from lgcareer February 9, 2020 16:36

lgcareer reviewed Feb 10, 2020

View reviewed changes

Eights-Li added 3 commits February 10, 2020 14:19

modify mysql 1.2.2 ddl.sql&dml.sql

1f11ea4

add scope test to mysql in pom

66febb7

modify pg-1.2.2 ddl.sql

5a82e6f

davidzollo approved these changes Feb 10, 2020

View reviewed changes

davidzollo merged commit d937a6a into apache:dev Feb 10, 2020

Eights-Li mentioned this pull request Feb 10, 2020

[Feature] add modify user name for process definition #1862

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add modify user name for process definition#1919

Add modify user name for process definition#1919
davidzollo merged 13 commits intoapache:devfrom
Eights-Li:dev

Eights-Li commented Feb 9, 2020

Uh oh!

codecov-io commented Feb 9, 2020 •

edited

Loading

Uh oh!

lgcareer Feb 10, 2020

Uh oh!

Eights-Li Feb 10, 2020

Uh oh!

lgcareer Feb 10, 2020 •

edited

Loading

Uh oh!

lgcareer Feb 10, 2020 •

edited

Loading

Uh oh!

Eights-Li Feb 10, 2020

Uh oh!

break60 commented Feb 10, 2020

Uh oh!

sonarqubecloud bot commented Feb 10, 2020

Uh oh!

davidzollo left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Eights-Li commented Feb 9, 2020

What is the purpose of the pull request

Brief change log

Uh oh!

codecov-io commented Feb 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lgcareer Feb 10, 2020

Choose a reason for hiding this comment

Uh oh!

Eights-Li Feb 10, 2020

Choose a reason for hiding this comment

Uh oh!

lgcareer Feb 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lgcareer Feb 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Eights-Li Feb 10, 2020

Choose a reason for hiding this comment

Uh oh!

break60 commented Feb 10, 2020

Uh oh!

sonarqubecloud bot commented Feb 10, 2020

Uh oh!

davidzollo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-io commented Feb 9, 2020 •

edited

Loading

lgcareer Feb 10, 2020 •

edited

Loading

lgcareer Feb 10, 2020 •

edited

Loading