chore: Revise batch pull approach to more follow C Data interface semantics#893
Merged
viirya merged 3 commits intoapache:mainfrom Sep 3, 2024
Merged
chore: Revise batch pull approach to more follow C Data interface semantics#893viirya merged 3 commits intoapache:mainfrom
viirya merged 3 commits intoapache:mainfrom
Conversation
viirya
commented
Aug 30, 2024
| } else { | ||
| val localTopK = if (orderingSatisfies) { | ||
| CometExecUtils.getNativeLimitRDD(childRDD, output, limit) | ||
| CometExecUtils.getNativeLimitRDD(childRDD, child.output, limit) |
Member
Author
There was a problem hiding this comment.
The fix in CometTakeOrderedAndProjectExec is at #896. I included it to verify it can make this PR passing CI.
Member
Author
|
The last test failure is fixed by #902. |
andygrove
approved these changes
Sep 3, 2024
huaxingao
approved these changes
Sep 3, 2024
Member
Author
|
Thanks @andygrove @huaxingao |
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
…antics (apache#893) * chore: Revise batch pull approach to more follow C Data interface semantics * fix clippy * Remove ExportedBatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #885.
Rationale for this change
What changes are included in this PR?
How are these changes tested?