fix: Add output to Comet operators equal and hashCode#902
Merged
viirya merged 2 commits intoapache:mainfrom Sep 2, 2024
Merged
fix: Add output to Comet operators equal and hashCode#902viirya merged 2 commits intoapache:mainfrom
viirya merged 2 commits intoapache:mainfrom
Conversation
andygrove
approved these changes
Sep 2, 2024
Member
Author
|
Thanks @andygrove |
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
* fix: Add output to Comet operators equal and hashCode * Update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
During debugging the last test failure in #893, it is caused by incorrectly exchange reuse of two Comet hash aggregate operators. Currently Comet hash aggregate operator's equal and hashCode don't include output. So if two hash operators have same input, mode, etc, they will be wrongly considered equal and cause the issue.
This patch add output to all Comet operators' equal and hashCode methods.
What changes are included in this PR?
How are these changes tested?