fix: CometTakeOrderedAndProjectExec native scan node should use child operator's output#896
Merged
viirya merged 1 commit intoapache:mainfrom Aug 30, 2024
Merged
Conversation
… operator's output
andygrove
approved these changes
Aug 30, 2024
Member
Author
|
Thanks @andygrove |
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
… operator's output (apache#896)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
This bug was found while debugging CI failure in #893. In
CometTakeOrderedAndProjectExec, we create internal native plan to execute native limit + sort + project. The pseudo scan node created there was incorrectly usingCometTakeOrderedAndProjectExec's output attributes but it should be child node's output.Currently it doesn't cause any error, although it will have incorrect schema in the scan node. Because sort/limit simply takes input so the incorrect schema doesn't make error. For project, we already bind attributes in Spark, as the input data is correct so it has no error too.
But in #893, we need to get the number of columns from the schema of scan node. If the schema is incorrect, the scan node will create incorrect number of array/schema structures which cause error later.
How are these changes tested?