noVNC: fix JP keyboard on vmware7+ which uses websocket URL#7694
Conversation
|
@blueorangutan package |
|
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
874ef3f to
f8a3fbc
Compare
yadvr
left a comment
There was a problem hiding this comment.
Change LGTM, didn't test them. I like the overall approach to get/pass the language details from the User VM and have noVNC codebase interpret the keyboard per the passed lang.
However, we need to be careful the next time we upgrade noVNC (to not revert such changes to novnc). Does it make sense to have a novnc fork somewhere (similar to cloudstack-nonoss/noredist repo)?
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6346 |
Codecov Report
@@ Coverage Diff @@
## 4.18 #7694 +/- ##
============================================
- Coverage 13.01% 13.01% -0.01%
- Complexity 9011 9015 +4
============================================
Files 2716 2719 +3
Lines 256656 256856 +200
Branches 40021 40049 +28
============================================
+ Hits 33410 33418 +8
- Misses 219060 219251 +191
- Partials 4186 4187 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@blueorangutan package |
|
@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6361 |
|
@blueorangutan package |
|
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6362 |
nvazquez
left a comment
There was a problem hiding this comment.
Code LGTM, thanks @weizhouapache
|
@blueorangutan package |
|
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6517 |
|
@blueorangutan test r8 vmware-70u3 |
|
@weizhouapache [SF] unsupported parameters provided. Supported mgmt server os are: |
|
@blueorangutan test rocky8 vmware-70u3 |
|
@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-7128)
|
andrijapanicsb
left a comment
There was a problem hiding this comment.
LGTM after testing.
The only difference is when pressing shift + 0 (shift and zero):
- in vCenter is sends key ~ (even though my onscreen keyboard layout specifies NO key)
- in noVNC console - it doesn't send any key (as expected by my keyboard layout)
Layout below:
|
thanks @andrijapanicsb for testing |
* 4.18: server: remove registered userdata when cleanup an account (#7777) server: Use max secondary storage defined on the account during upload (#7441) test: upgrade kubernetes versions to 1.25.0/1.26.0 (#7685) kvm: Added VNI Devices as normal bridge slave devs (#7836) noVNC: fix JP keyboard on vmware7+ which uses websocket URL (#7694)
This backports apache#7694
This backports apache#7694
Description
This PR fixes the type error on novnc console of VM on VMware7 which uses Japanese layout.
The other languages layout can be fixed by similar solution.
This PR fixes and closes #7335
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?