Skip to content

Added VNI Devices as normal bridge slave devs#7836

Merged
weizhouapache merged 1 commit intoapache:4.18from
fermosan:AGENT_VNI_BRIDGE
Aug 10, 2023
Merged

Added VNI Devices as normal bridge slave devs#7836
weizhouapache merged 1 commit intoapache:4.18from
fermosan:AGENT_VNI_BRIDGE

Conversation

@fermosan
Copy link
Copy Markdown
Contributor

@fermosan fermosan commented Aug 9, 2023

This will allow for VXLAN configurations to utilize tags on the physical network of a zone

Description

Added vni to the device list to be treated as a normal bridge slave devs

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

This will allow for VXLAN configurations to utilize tags on the physical network of a zone
@fermosan
Copy link
Copy Markdown
Contributor Author

fermosan commented Aug 9, 2023

@weizhouapache Hello. Kindly pick this from here. it should be against 4.18.

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @fermosan

code lgtm

@weizhouapache
Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6720

@weizhouapache
Copy link
Copy Markdown
Member

@blueorangutan test rocky8 kvm-rocky8

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 9, 2023

Codecov Report

Merging #7836 (4f052cf) into 4.18 (a1af03f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.18    #7836   +/-   ##
=========================================
  Coverage     13.02%   13.02%           
- Complexity     9032     9034    +2     
=========================================
  Files          2720     2720           
  Lines        257071   257071           
  Branches      40089    40089           
=========================================
+ Hits          33475    33484    +9     
+ Misses       219392   219381   -11     
- Partials       4204     4206    +2     
Files Changed Coverage Δ
...ervisor/kvm/resource/LibvirtComputingResource.java 18.45% <ø> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link
Copy Markdown

[SF] Trillian test result (tid-7343)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 49335 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7836-t7343-kvm-rocky8.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@weizhouapache weizhouapache merged commit fa58f59 into apache:4.18 Aug 10, 2023
@weizhouapache weizhouapache added this to the 4.18.1.0 milestone Aug 10, 2023
DaanHoogland added a commit that referenced this pull request Aug 10, 2023
* 4.18:
  server: remove registered userdata when cleanup an account (#7777)
  server: Use max secondary storage defined on the account during upload  (#7441)
  test: upgrade kubernetes versions to 1.25.0/1.26.0 (#7685)
  kvm: Added VNI Devices as normal bridge slave devs (#7836)
  noVNC: fix JP keyboard on vmware7+ which uses websocket URL (#7694)
@fermosan fermosan deleted the AGENT_VNI_BRIDGE branch August 10, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants