Skip to content

server: remove registered userdata when cleanup an account#7777

Merged
DaanHoogland merged 1 commit intoapache:4.18from
weizhouapache:4.18-remove-userdata-when-remove-account
Aug 10, 2023
Merged

server: remove registered userdata when cleanup an account#7777
DaanHoogland merged 1 commit intoapache:4.18from
weizhouapache:4.18-remove-userdata-when-remove-account

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Jul 27, 2023

Description

This PR fixes the leftover of userdata when delete an account

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache weizhouapache added this to the 4.18.1.0 milestone Jul 27, 2023
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Jul 27, 2023

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 27, 2023

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland
DaanHoogland approved these changes Jul 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 27, 2023

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6576

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Jul 27, 2023

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 27, 2023

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 27, 2023

[SF] Trillian test result (tid-7180)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48649 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7777-t7180-kvm-centos7.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_list_vms_metrics_admin Error 3610.18 test_metrics_api.py
test_list_vms_metrics_history Error 5.45 test_metrics_api.py
test_list_volumes_metrics_history Error 5.55 test_metrics_api.py
test_01_migrate_VM_and_root_volume Error 83.86 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 54.51 test_vm_life_cycle.py

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Jul 27, 2023

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 27, 2023

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

harikrishna-patnala
harikrishna-patnala approved these changes Jul 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since account cleanup involves cleaning the templates and VMs, removing the userdata should also be fine.

Code LGTM

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 28, 2023

[SF] Trillian test result (tid-7193)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44769 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7777-t7193-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_migrate_VM_and_root_volume Error 78.82 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 52.34 test_vm_life_cycle.py

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jul 28, 2023

@blueorangutan test keepEnv

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jul 28, 2023

will test manually, but maybe we should have a cleanup marvin test (for accounts but also domains)?

yadvr
yadvr approved these changes Aug 8, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM haven't tested it

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Aug 10, 2023

tests good

@DaanHoogland DaanHoogland merged commit 1605b2f into apache:4.18 Aug 10, 2023
@DaanHoogland DaanHoogland deleted the 4.18-remove-userdata-when-remove-account branch August 10, 2023 12:34
DaanHoogland added a commit that referenced this pull request Aug 10, 2023
@DaanHoogland
Merge release branch 4.18 to main
7b64236 
* 4.18:
  server: remove registered userdata when cleanup an account (#7777)
  server: Use max secondary storage defined on the account during upload  (#7441)
  test: upgrade kubernetes versions to 1.25.0/1.26.0 (#7685)
  kvm: Added VNI Devices as normal bridge slave devs (#7836)
  noVNC: fix JP keyboard on vmware7+ which uses websocket URL (#7694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.18.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@weizhouapache @blueorangutan @DaanHoogland @yadvr @harikrishna-patnala