Skip to content

[14.2.x] fix(common): rename rawSrc -> ngSrc in NgOptimizedImage directive (#47362)#47396

Closed
AndrewKushnir wants to merge 1 commit intoangular:14.2.xfrom
AndrewKushnir:rename_raw_src_patch
Closed

[14.2.x] fix(common): rename rawSrc -> ngSrc in NgOptimizedImage directive (#47362)#47396
AndrewKushnir wants to merge 1 commit intoangular:14.2.xfrom
AndrewKushnir:rename_raw_src_patch

Conversation

@AndrewKushnir
Copy link
Contributor

As an ongoing effort to stabilize the NgOptimizedImage API before existing the Developer Preview, this commit renames the rawSrc attribute used for the NgOptimizedImage selector matching to ngSrc. The rawSrcset is also renamed to ngSrcset for consistency.

The motivation for this change is to align the attribute name better with other built-in directives, such as ngFor, ngIf, ngClass, ngStyle, etc.

Note: this is technically a breaking change, but since the NgOptimizedImage directive is in the Developer Preview mode, we land the change in a patch branch.

…angular#47362)

As an ongoing effort to stabilize the NgOptimizedImage API before existing the Developer Preview, this commit renames the `rawSrc` attribute used for the NgOptimizedImage selector matching to `ngSrc`. The `rawSrcset` is also renamed to `ngSrcset` for consistency.

The motivation for this change is to align the attribute name better with other built-in directives, such as `ngFor`, `ngIf`, `ngClass`, `ngStyle`, etc.

Note: this is technically a breaking change, but since the NgOptimizedImage directive is in the Developer Preview mode, we land the change in a patch branch.

PR Close angular#47362
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release PullApprove: disable common: image directive labels Sep 9, 2022
@ngbot ngbot bot added this to the Backlog milestone Sep 9, 2022
@AndrewKushnir AndrewKushnir added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 9, 2022
@AndrewKushnir
Copy link
Contributor Author

Merge-assistance: patch-only PR, does not require g3 presubmit.

@dylhunn
Copy link
Contributor

dylhunn commented Sep 12, 2022

This PR was merged into the repository by commit c9bdf9b.

@dylhunn dylhunn closed this Sep 12, 2022
dylhunn pushed a commit that referenced this pull request Sep 12, 2022
…#47362) (#47396)

As an ongoing effort to stabilize the NgOptimizedImage API before existing the Developer Preview, this commit renames the `rawSrc` attribute used for the NgOptimizedImage selector matching to `ngSrc`. The `rawSrcset` is also renamed to `ngSrcset` for consistency.

The motivation for this change is to align the attribute name better with other built-in directives, such as `ngFor`, `ngIf`, `ngClass`, `ngStyle`, etc.

Note: this is technically a breaking change, but since the NgOptimizedImage directive is in the Developer Preview mode, we land the change in a patch branch.

PR Close #47362

PR Close #47396
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Sep 22, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.2.1/14.2.2) |
| [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.2.1/14.2.2) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.2.1/14.2.2) |
| [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.2.1/14.2.2) |
| [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.2.1/14.2.2) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.2.1/14.2.2) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.2.1/14.2.2) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.2.1/14.2.2) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v14.2.2`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1422-2022-09-14)

[Compare Source](angular/angular@14.2.1...14.2.2)

##### animations

| Commit | Type | Description |
| -- | -- | -- |
| [937e6c5b3d](angular/angular@937e6c5) | fix | make sure that the animation function delay is applied ([#&#8203;47285](angular/angular#47285)) |

##### common

| Commit | Type | Description |
| -- | -- | -- |
| [c9bdf9bab1](angular/angular@c9bdf9b) | fix | rename `rawSrc` -> `ngSrc` in NgOptimizedImage directive ([#&#8203;47362](angular/angular#47362)) ([#&#8203;47396](angular/angular#47396)) |

##### core

| Commit | Type | Description |
| -- | -- | -- |
| [a3e1303f04](angular/angular@a3e1303) | fix | imply [@&#8203;Optional](https://github.com/Optional) flag when a default value is provided ([#&#8203;47242](angular/angular#47242)) |

##### forms

| Commit | Type | Description |
| -- | -- | -- |
| [80c66a1e57](angular/angular@80c66a1) | fix | don't prevent default behavior for forms with method="dialog" ([#&#8203;47308](angular/angular#47308)) |

#### Special Thanks

Abhishek Rawat, Andrew Kushnir, Benjamin Chanudet, Bob Watson, George Kalpakas, Ikko Ashimine, Kristiyan Kostadinov, Marc Wrobel, Mariia Subkov, Pawel Kozlowski, Sebastian, abergquist, dario-piotrowicz, onrails and vyom1611

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTUuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5NS41In0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1548
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package common: image directive merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants