fix(common): rename rawSrc -> ngSrc in NgOptimizedImage directive#47362
Closed
AndrewKushnir wants to merge 2 commits intoangular:mainfrom
Closed
fix(common): rename rawSrc -> ngSrc in NgOptimizedImage directive#47362AndrewKushnir wants to merge 2 commits intoangular:mainfrom
rawSrc -> ngSrc in NgOptimizedImage directive#47362AndrewKushnir wants to merge 2 commits intoangular:mainfrom
Conversation
As an ongoing effort to stabilize the NgOptimizedImage API before existing the Developer Preview, this commit renames the `rawSrc` attribute used for the NgOptimizedImage selector matching to `ngSrc`. The `rawSrcset` is also renamed to `ngSrcset` for consistency. The motivation for this change is to align the attribute name better with other built-in directives, such as `ngFor`, `ngIf`, `ngClass`, `ngStyle`, etc. Note: this is technically a breaking change, but since the NgOptimizedImage directive is in the Developer Preview mode, we land the change in a patch branch.
jelbourn
approved these changes
Sep 7, 2022
Contributor
Author
Contributor
|
@AndrewKushnir looked at the commit, LGTM |
jelbourn
approved these changes
Sep 7, 2022
Contributor
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: global-docs-approvers
Contributor
Author
pkozlowski-opensource
approved these changes
Sep 8, 2022
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM!
Reviewed-for: public-api
Reviewed-for: fw-core
Reviewed-for: fw-common
Contributor
|
This PR was merged into the repository by commit ca7bf65. |
Contributor
|
@AndrewKushnir This has been merged into minor, but needs a rebase to merge into patch. |
AndrewKushnir
added a commit
to AndrewKushnir/angular
that referenced
this pull request
Sep 9, 2022
…angular#47362) As an ongoing effort to stabilize the NgOptimizedImage API before existing the Developer Preview, this commit renames the `rawSrc` attribute used for the NgOptimizedImage selector matching to `ngSrc`. The `rawSrcset` is also renamed to `ngSrcset` for consistency. The motivation for this change is to align the attribute name better with other built-in directives, such as `ngFor`, `ngIf`, `ngClass`, `ngStyle`, etc. Note: this is technically a breaking change, but since the NgOptimizedImage directive is in the Developer Preview mode, we land the change in a patch branch. PR Close angular#47362
Contributor
Author
dylhunn
pushed a commit
that referenced
this pull request
Sep 12, 2022
…#47362) (#47396) As an ongoing effort to stabilize the NgOptimizedImage API before existing the Developer Preview, this commit renames the `rawSrc` attribute used for the NgOptimizedImage selector matching to `ngSrc`. The `rawSrcset` is also renamed to `ngSrcset` for consistency. The motivation for this change is to align the attribute name better with other built-in directives, such as `ngFor`, `ngIf`, `ngClass`, `ngStyle`, etc. Note: this is technically a breaking change, but since the NgOptimizedImage directive is in the Developer Preview mode, we land the change in a patch branch. PR Close #47362 PR Close #47396
vyom1611
pushed a commit
to vyom1611/angular
that referenced
this pull request
Sep 18, 2022
…angular#47362) As an ongoing effort to stabilize the NgOptimizedImage API before existing the Developer Preview, this commit renames the `rawSrc` attribute used for the NgOptimizedImage selector matching to `ngSrc`. The `rawSrcset` is also renamed to `ngSrcset` for consistency. The motivation for this change is to align the attribute name better with other built-in directives, such as `ngFor`, `ngIf`, `ngClass`, `ngStyle`, etc. Note: this is technically a breaking change, but since the NgOptimizedImage directive is in the Developer Preview mode, we land the change in a patch branch. PR Close angular#47362
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Sep 22, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.2.1/14.2.2) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.2.1/14.2.2) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.2.1/14.2.2) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.2.1/14.2.2) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.2.1/14.2.2) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.2.1/14.2.2) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.2.1/14.2.2) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.2.1/14.2.2) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.2.2`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1422-2022-09-14) [Compare Source](angular/angular@14.2.1...14.2.2) ##### animations | Commit | Type | Description | | -- | -- | -- | | [937e6c5b3d](angular/angular@937e6c5) | fix | make sure that the animation function delay is applied ([#​47285](angular/angular#47285)) | ##### common | Commit | Type | Description | | -- | -- | -- | | [c9bdf9bab1](angular/angular@c9bdf9b) | fix | rename `rawSrc` -> `ngSrc` in NgOptimizedImage directive ([#​47362](angular/angular#47362)) ([#​47396](angular/angular#47396)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [a3e1303f04](angular/angular@a3e1303) | fix | imply [@​Optional](https://github.com/Optional) flag when a default value is provided ([#​47242](angular/angular#47242)) | ##### forms | Commit | Type | Description | | -- | -- | -- | | [80c66a1e57](angular/angular@80c66a1) | fix | don't prevent default behavior for forms with method="dialog" ([#​47308](angular/angular#47308)) | #### Special Thanks Abhishek Rawat, Andrew Kushnir, Benjamin Chanudet, Bob Watson, George Kalpakas, Ikko Ashimine, Kristiyan Kostadinov, Marc Wrobel, Mariia Subkov, Pawel Kozlowski, Sebastian, abergquist, dario-piotrowicz, onrails and vyom1611 <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTUuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5NS41In0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1548 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an ongoing effort to stabilize the NgOptimizedImage API before existing the Developer Preview, this commit renames the
rawSrcattribute used for the NgOptimizedImage selector matching tongSrc. TherawSrcsetis also renamed tongSrcsetfor consistency.The motivation for this change is to align the attribute name better with other built-in directives, such as
ngFor,ngIf,ngClass,ngStyle, etc.Note: this is technically a breaking change, but since the NgOptimizedImage directive is in the Developer Preview mode, we land the change in a patch branch.
Does this PR introduce a breaking change?