Skip to content

fix(animations): make sure that the animation function delay is applied#47285

Closed
dario-piotrowicz wants to merge 1 commit intoangular:mainfrom
dario-piotrowicz:47283
Closed

fix(animations): make sure that the animation function delay is applied#47285
dario-piotrowicz wants to merge 1 commit intoangular:mainfrom
dario-piotrowicz:47283

Conversation

@dario-piotrowicz
Copy link
Contributor

make sure that when an animation is defined via the animation function
(and used via useAnimation) and a delay has been provided then that
delay gets correctly applied

resolves #47283

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #47283

As you can see from the stackblitz in the issue, the delay of animations defined using animation is not correctly applied:

before

What is the new behavior?

The delay gets correctly applied:

after

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

  • useAnimation can also take a delay option, and that is also not being applied, I haven't dealt with that in this PR, if ok I thought of looking into it in a follow up PR

make sure that when an animation is defined via the `animation` function
(and used via `useAnimation`) and a delay has been provided then that
delay gets correctly applied

resolves angular#47283
@pullapprove pullapprove bot requested a review from alxhub August 28, 2022 23:07
@ngbot ngbot bot added this to the Backlog milestone Aug 29, 2022
@jessicajaniuk jessicajaniuk requested review from jessicajaniuk and removed request for alxhub August 29, 2022 23:57
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks Dario!

@jessicajaniuk jessicajaniuk added target: patch This PR is targeted for the next patch release action: global presubmit The PR is in need of a google3 global presubmit labels Sep 8, 2022
@dylhunn dylhunn added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 12, 2022
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Sep 12, 2022
@dylhunn dylhunn self-assigned this Sep 12, 2022
@dylhunn dylhunn modified the milestones: Backlog, v15-candidates Sep 12, 2022
@dylhunn
Copy link
Contributor

dylhunn commented Sep 12, 2022

merge-assistance: I will run a TGP overnight.

@dylhunn
Copy link
Contributor

dylhunn commented Sep 13, 2022

TGP is running. Rerun.

@jessicajaniuk jessicajaniuk removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note action: global presubmit The PR is in need of a google3 global presubmit labels Sep 13, 2022
@jessicajaniuk
Copy link
Contributor

TGP is greeeeeen! 🟢

@dylhunn
Copy link
Contributor

dylhunn commented Sep 13, 2022

This PR was merged into the repository by commit 7ec196e.

dylhunn pushed a commit that referenced this pull request Sep 13, 2022
…ed (#47285)

make sure that when an animation is defined via the `animation` function
(and used via `useAnimation`) and a delay has been provided then that
delay gets correctly applied

resolves #47283

PR Close #47285
@dylhunn dylhunn closed this in 7ec196e Sep 13, 2022
@dario-piotrowicz dario-piotrowicz deleted the 47283 branch September 13, 2022 21:01
dario-piotrowicz added a commit to dario-piotrowicz/angular that referenced this pull request Sep 17, 2022
…plied

make sure that when an animation is used via the `useAnimation` function
and a delay has been provided then that delay gets correctly applied

(this PR is a follow up for angular#47285)
vyom1611 pushed a commit to vyom1611/angular that referenced this pull request Sep 18, 2022
…ed (angular#47285)

make sure that when an animation is defined via the `animation` function
(and used via `useAnimation`) and a delay has been provided then that
delay gets correctly applied

resolves angular#47283

PR Close angular#47285
pkozlowski-opensource pushed a commit that referenced this pull request Sep 20, 2022
…plied (#47468)

make sure that when an animation is used via the `useAnimation` function
and a delay has been provided then that delay gets correctly applied

(this PR is a follow up for #47285)

PR Close #47468
pkozlowski-opensource pushed a commit that referenced this pull request Sep 20, 2022
…plied (#47468)

make sure that when an animation is used via the `useAnimation` function
and a delay has been provided then that delay gets correctly applied

(this PR is a follow up for #47285)

PR Close #47468
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Sep 22, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.2.1/14.2.2) |
| [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.2.1/14.2.2) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.2.1/14.2.2) |
| [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.2.1/14.2.2) |
| [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.2.1/14.2.2) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.2.1/14.2.2) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.2.1/14.2.2) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.2.1` -> `14.2.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.2.1/14.2.2) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v14.2.2`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1422-2022-09-14)

[Compare Source](angular/angular@14.2.1...14.2.2)

##### animations

| Commit | Type | Description |
| -- | -- | -- |
| [937e6c5b3d](angular/angular@937e6c5) | fix | make sure that the animation function delay is applied ([#&#8203;47285](angular/angular#47285)) |

##### common

| Commit | Type | Description |
| -- | -- | -- |
| [c9bdf9bab1](angular/angular@c9bdf9b) | fix | rename `rawSrc` -> `ngSrc` in NgOptimizedImage directive ([#&#8203;47362](angular/angular#47362)) ([#&#8203;47396](angular/angular#47396)) |

##### core

| Commit | Type | Description |
| -- | -- | -- |
| [a3e1303f04](angular/angular@a3e1303) | fix | imply [@&#8203;Optional](https://github.com/Optional) flag when a default value is provided ([#&#8203;47242](angular/angular#47242)) |

##### forms

| Commit | Type | Description |
| -- | -- | -- |
| [80c66a1e57](angular/angular@80c66a1) | fix | don't prevent default behavior for forms with method="dialog" ([#&#8203;47308](angular/angular#47308)) |

#### Special Thanks

Abhishek Rawat, Andrew Kushnir, Benjamin Chanudet, Bob Watson, George Kalpakas, Ikko Ashimine, Kristiyan Kostadinov, Marc Wrobel, Mariia Subkov, Pawel Kozlowski, Sebastian, abergquist, dario-piotrowicz, onrails and vyom1611

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTUuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5NS41In0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1548
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: animations target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delay option ignored in animation function

3 participants