build(docs-infra): upgrade @angular/cli to 8.0.0-beta.15, @angular/* to 8.0.0-beta.12, @angular/material to 8.0.0-beta.2 by gkalpak · Pull Request #29926 · angular/angular

gkalpak · 2019-04-16T14:10:36Z

This PR upgrades @angular/{*, material, cli} to current @next versions, enables differential loading, enables some more strict TypeScript checks for angular.io and aligns the config files closer to what the cli would generate today.
See individual commits for more details.

Blocked on #29976.

filipesilva

Can you also re-enable these tests please? 4d37a06

I know we have already talked about it but wanted to leave a comment here so I don't forget to check :D

In angular#29926, the size of the build artifacts has increased due to turning on differential loading (which generates an es2015/es5 pair for each JS resource). To avoid the preview server's rejecting the build artifacts (as in [288181][1]), this commit increases the max allowed artifact size from 20MB to 25MB (current artifact size after angular#29926 is ~22MB). [1]: https://circleci.com/gh/angular/angular/288181

gkalpak · 2019-04-18T15:05:13Z

AFAICT, these tests are not related to the aio app's cli version (which is independent of the version used in docs examples).
I have added a TODO on my list to enable those tests in a subsequent PR, while upgrading the dependencies used in docs examples (including the cli).

mary-poppins · 2019-04-18T16:25:10Z

You can preview bf28bcf at https://pr29926-bf28bcf.ngbuilds.io/.

mary-poppins · 2019-04-18T16:26:22Z

You can preview e83ef61 at https://pr29926-e83ef61.ngbuilds.io/.

mary-poppins · 2019-04-18T20:14:23Z

You can preview af27758 at https://pr29926-af27758.ngbuilds.io/.

mary-poppins · 2019-04-25T16:01:59Z

You can preview a55f573 at https://pr29926-a55f573.ngbuilds.io/.

mary-poppins · 2019-04-25T16:09:18Z

You can preview e62ebc8 at https://pr29926-e62ebc8.ngbuilds.io/.

This commit also changes the config files and their layout to (reasonably closely) match what the cli would generate for a new app. Related Jira issue: [TOOL-815](https://angular-team.atlassian.net/browse/TOOL-815)

Now that defferential loading it supported by the cli, remove the obsolete `ie-polyfills.js` (and associated dependencies). All polyfills in `ie-polyfills.js` are now included in the [polyfills-es5][1] bundle, except for `classlist.js`, that is only needed in order to support `NgClass` on SVG elements, which we don't use. [1]: https://github.com/angular/angular-cli/blob/b95933a57/packages/angular_devkit/build_angular/src/angular-cli-files/models/es5-polyfills.js

…tAny`

This commit also changes the `tslint.json` config file to (reasonably closely) match what the cli would generate for a new app.

…o `ban` The `no-jasmine-focus` rule has been removed from `vrsource-tslint-rules` [since version 5.8.0][1] (theoretically; practically it remained [until version 5.8.2][2]). This commit removes the non-existent rule (and the obsolete dependency) and uses tslint's `ban` rule instead (as recommended). [1]: vrsource/vrsource-tslint-rules@477f622#diff-04c6e90faac2675aa89e2176d2eec7d8R162 [2]: vrsource/vrsource-tslint-rules#13 (comment)

gkalpak · 2019-04-25T17:12:46Z

Thx to @clydin's help, I was able to overcome the error by upgrading browserslist to 4.5.5 (for ^4.0.0 and ^4.5.4 ranges).
So, I have upgraded @angular/cli to 8.0.0-beta.18.

For reference, here are the browserslist versions before the manual update to 4.5.5:

=> Found "browserslist@4.5.4"
info Has been hoisted to "browserslist"
info Reasons this module exists
   - Hoisted from "@angular-devkit#build-angular#caniuse-api#browserslist"
   - Hoisted from "@angular-devkit#build-angular#autoprefixer#browserslist"
=> Found "@angular-devkit/build-angular#browserslist@4.5.5"
info This module exists because "@angular-devkit#build-angular" depends on it.

mary-poppins · 2019-04-25T17:13:07Z

You can preview 488e950 at https://pr29926-488e950.ngbuilds.io/.

AndrewKushnir · 2019-04-25T19:09:47Z

Removing "cleanup" label from this PR after a chat with @gkalpak, so this PR is ready to merge.

…#29926) PR Close angular#29926

This commit also changes the config files and their layout to (reasonably closely) match what the cli would generate for a new app. Related Jira issue: [TOOL-815](https://angular-team.atlassian.net/browse/TOOL-815) PR Close angular#29926

Now that defferential loading it supported by the cli, remove the obsolete `ie-polyfills.js` (and associated dependencies). All polyfills in `ie-polyfills.js` are now included in the [polyfills-es5][1] bundle, except for `classlist.js`, that is only needed in order to support `NgClass` on SVG elements, which we don't use. [1]: https://github.com/angular/angular-cli/blob/b95933a57/packages/angular_devkit/build_angular/src/angular-cli-files/models/es5-polyfills.js PR Close angular#29926

…tAny` (angular#29926) PR Close angular#29926

…ngular#29926) This commit also changes the `tslint.json` config file to (reasonably closely) match what the cli would generate for a new app. PR Close angular#29926

…o `ban` (angular#29926) The `no-jasmine-focus` rule has been removed from `vrsource-tslint-rules` [since version 5.8.0][1] (theoretically; practically it remained [until version 5.8.2][2]). This commit removes the non-existent rule (and the obsolete dependency) and uses tslint's `ban` rule instead (as recommended). [1]: vrsource/vrsource-tslint-rules@477f622#diff-04c6e90faac2675aa89e2176d2eec7d8R162 [2]: vrsource/vrsource-tslint-rules#13 (comment) PR Close angular#29926

…re robust (angular#29989) In light of angular#29926, that will change the path of `tsconfig.app.json`, this commit switches from a hard-coded `tsconfig.app.json` path to looking it up in `angular.json` (to be more future-proof). PR Close angular#29989

…ver (angular#29976) In angular#29926, the size of the build artifacts has increased due to turning on differential loading (which generates an es2015/es5 pair for each JS resource). To avoid the preview server's rejecting the build artifacts (as in [288181][1]), this commit increases the max allowed artifact size from 20MB to 25MB (current artifact size after angular#29926 is ~22MB). [1]: https://circleci.com/gh/angular/angular/288181 PR Close angular#29976

PR Close angular#29926

…#29926) PR Close angular#29926

This commit also changes the config files and their layout to (reasonably closely) match what the cli would generate for a new app. Related Jira issue: [TOOL-815](https://angular-team.atlassian.net/browse/TOOL-815) PR Close angular#29926

angular-automatic-lock-bot · 2019-09-15T00:23:12Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Apr 16, 2019

gkalpak force-pushed the build-aio-upgrade-cli branch from 3924734 to 8c47edb Compare April 16, 2019 14:14

gkalpak changed the title ~~build(docs-infra): upgrade @angular/cli to 8.0.0-beta.14~~ build(docs-infra): upgrade @angular/cli to 8.0.0-beta.15, @angular/* to 8.0.0-beta.12, @angular/material to 8.0.0-beta.2 Apr 16, 2019

gkalpak force-pushed the build-aio-upgrade-cli branch 2 times, most recently from 097ecd5 to efd0289 Compare April 17, 2019 13:42

benlesh added the area: build & ci Related the build and CI infrastructure of the project label Apr 17, 2019

ngbot bot added this to the needsTriage milestone Apr 17, 2019

gkalpak force-pushed the build-aio-upgrade-cli branch 3 times, most recently from 346f8a6 to 5d0af5e Compare April 17, 2019 23:33

filipesilva reviewed Apr 18, 2019

View reviewed changes

gkalpak mentioned this pull request Apr 18, 2019

build(docs-infra): increase build artifact size limit (and upgrade preview server to Debian 9) #29976

Closed

gkalpak added comp: docs-infra effort2: days state: WIP target: major This PR is targeted for the next major release risk: low labels Apr 18, 2019

gkalpak modified the milestones: needsTriage, docs-infra-aio-app Apr 18, 2019

gkalpak added state: blocked and removed state: WIP labels Apr 18, 2019

gkalpak mentioned this pull request Apr 18, 2019

ci(docs-infra): run with Ivy #28530

Closed

16 tasks

gkalpak force-pushed the build-aio-upgrade-cli branch 2 times, most recently from bf28bcf to e83ef61 Compare April 18, 2019 16:20

gkalpak force-pushed the build-aio-upgrade-cli branch from e83ef61 to af27758 Compare April 18, 2019 20:08

gkalpak force-pushed the build-aio-upgrade-cli branch from a55f573 to e62ebc8 Compare April 25, 2019 16:02

alan-agius4 approved these changes Apr 25, 2019

View reviewed changes

gkalpak added 6 commits April 25, 2019 20:05

build(docs-infra): upgrade @angular/cli to 8.0.0-beta.18

b08c88a

This commit also changes the config files and their layout to (reasonably closely) match what the cli would generate for a new app. Related Jira issue: [TOOL-815](https://angular-team.atlassian.net/browse/TOOL-815)

fixup! build(docs-infra): upgrade @angular/cli to 8.0.0-beta.18

afc6e7c

build(docs-infra): make type-checking stricter by enabling `noImplici…

a04a3cf

…tAny`

build(docs-infra): upgrade tslint to 5.15.0 and codelyzer to 5.0.0

6550bed

This commit also changes the `tslint.json` config file to (reasonably closely) match what the cli would generate for a new app.

gkalpak force-pushed the build-aio-upgrade-cli branch from e62ebc8 to 488e950 Compare April 25, 2019 17:06

AndrewKushnir removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 25, 2019

brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Apr 25, 2019

build(docs-infra): upgrade @angular/material to 8.0.0-beta.2 (angular…

b8298f1

…#29926) PR Close angular#29926

brandonroberts pushed a commit to brandonroberts/angular that referenced this pull request Apr 25, 2019

build(docs-infra): make type-checking stricter by enabling `noImplici…

eb85c8a

…tAny` (angular#29926) PR Close angular#29926

AndrewKushnir closed this in 3def652 Apr 25, 2019

gkalpak deleted the build-aio-upgrade-cli branch April 25, 2019 19:35

BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019

build(docs-infra): upgrade @angular/* to 8.0.0-beta.14 (angular#29926)

5202808

PR Close angular#29926

BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019

build(docs-infra): upgrade @angular/material to 8.0.0-beta.2 (angular…

91628c9

…#29926) PR Close angular#29926

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(docs-infra): upgrade @angular/cli to 8.0.0-beta.15, @angular/* to 8.0.0-beta.12, @angular/material to 8.0.0-beta.2#29926

build(docs-infra): upgrade @angular/cli to 8.0.0-beta.15, @angular/* to 8.0.0-beta.12, @angular/material to 8.0.0-beta.2#29926
gkalpak wants to merge 10 commits intoangular:masterfrom
gkalpak:build-aio-upgrade-cli

gkalpak commented Apr 16, 2019 •

edited

Loading

Uh oh!

filipesilva left a comment

Uh oh!

gkalpak commented Apr 18, 2019 •

edited

Loading

Uh oh!

mary-poppins commented Apr 18, 2019

Uh oh!

mary-poppins commented Apr 18, 2019

Uh oh!

mary-poppins commented Apr 18, 2019

Uh oh!

mary-poppins commented Apr 25, 2019

Uh oh!

mary-poppins commented Apr 25, 2019

Uh oh!

gkalpak commented Apr 25, 2019

Uh oh!

mary-poppins commented Apr 25, 2019

Uh oh!

AndrewKushnir commented Apr 25, 2019

Uh oh!

angular-automatic-lock-bot bot commented Sep 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Conversation

gkalpak commented Apr 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

filipesilva left a comment

Choose a reason for hiding this comment

Uh oh!

gkalpak commented Apr 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mary-poppins commented Apr 18, 2019

Uh oh!

mary-poppins commented Apr 18, 2019

Uh oh!

mary-poppins commented Apr 18, 2019

Uh oh!

mary-poppins commented Apr 25, 2019

Uh oh!

mary-poppins commented Apr 25, 2019

Uh oh!

gkalpak commented Apr 25, 2019

Uh oh!

mary-poppins commented Apr 25, 2019

Uh oh!

AndrewKushnir commented Apr 25, 2019

Uh oh!

angular-automatic-lock-bot bot commented Sep 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

gkalpak commented Apr 16, 2019 •

edited

Loading

gkalpak commented Apr 18, 2019 •

edited

Loading