Skip to content

build(docs-infra): increase build artifact size limit (and upgrade preview server to Debian 9)#29976

Closed
gkalpak wants to merge 3 commits intoangular:masterfrom
gkalpak:build-aio-increase-preview-size-limit
Closed

build(docs-infra): increase build artifact size limit (and upgrade preview server to Debian 9)#29976
gkalpak wants to merge 3 commits intoangular:masterfrom
gkalpak:build-aio-increase-preview-size-limit

Conversation

@gkalpak
Copy link
Member

@gkalpak gkalpak commented Apr 18, 2019

This PR basically does 3 things (see individual commit messages for more details):

gkalpak added 3 commits April 18, 2019 12:45
In angular#29926, the size of the build artifacts has increased due to turning
on differential loading (which generates an es2015/es5 pair for each JS
resource).

To avoid the preview server's rejecting the build artifacts (as in
[288181][1]), this commit increases the max allowed artifact size from
20MB to 25MB (current artifact size after angular#29926 is ~22MB).

[1]: https://circleci.com/gh/angular/angular/288181
Previously, the preview server docker image was based on Debian 8
(jessie). Recently, `jessie-updates` and `jessie-backborts` were removed
from the Debian mirrors ([more info][1]), thus breaking new builds of
the image.

Instead of updating `/etc/apt/sources.list` to remove the obsolete
sources, this commit upgrades to Debian 9 (stretch).

(The GCE VM running the preview server docker container was also
upgraded from Debian 8 to 9 this morning.)

---
Other changes:
- Removed dependency on `chkconfig`, which is not supported on Debian 9.
- Installing `nginx` from the regular repositories (instead of
  `*-backports).
- Upgraded to `pm2` v3, which can handle hooking itself up to system
  startup better (without `chkconfig` - see above).
- Updated tests to reflect the fact that `nginx` has dropped the reason
  phrase in response status lines for HTTP/2 (in compliance with
  [the spec][2]). (HTTP/1.1: `HTTP/1.1 200 OK` | HTTP/2: `HTTP/2 200`)

[1]: https://www.lucas-nussbaum.net/blog/?p=947
[2]: https://http2.github.io/http2-spec/#rfc.section.8.1.2.4
…er docker image

This minimises the risk of unexpected failures due to breaking changes,
when building a new image (e.g. as a result of an unrelated config
change in Dockerfile).
@gkalpak gkalpak requested a review from a team April 18, 2019 14:50
@gkalpak gkalpak added area: build & ci Related the build and CI infrastructure of the project comp: docs-infra effort1: hours action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release risk: low and removed cla: yes labels Apr 18, 2019
@ngbot ngbot bot added this to the needsTriage milestone Apr 18, 2019
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@mary-poppins
Copy link

You can preview a0fdb8b at https://pr29976-a0fdb8b.ngbuilds.io/.

@benlesh benlesh added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 18, 2019
@gkalpak gkalpak removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 23, 2019
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust that you have tested this :-)

@gkalpak
Copy link
Member Author

gkalpak commented Apr 23, 2019

It works on my machine 😁

@benlesh benlesh closed this in 24c0609 Apr 23, 2019
benlesh pushed a commit that referenced this pull request Apr 23, 2019
…29976)

Previously, the preview server docker image was based on Debian 8
(jessie). Recently, `jessie-updates` and `jessie-backborts` were removed
from the Debian mirrors ([more info][1]), thus breaking new builds of
the image.

Instead of updating `/etc/apt/sources.list` to remove the obsolete
sources, this commit upgrades to Debian 9 (stretch).

(The GCE VM running the preview server docker container was also
upgraded from Debian 8 to 9 this morning.)

---
Other changes:
- Removed dependency on `chkconfig`, which is not supported on Debian 9.
- Installing `nginx` from the regular repositories (instead of
  `*-backports).
- Upgraded to `pm2` v3, which can handle hooking itself up to system
  startup better (without `chkconfig` - see above).
- Updated tests to reflect the fact that `nginx` has dropped the reason
  phrase in response status lines for HTTP/2 (in compliance with
  [the spec][2]). (HTTP/1.1: `HTTP/1.1 200 OK` | HTTP/2: `HTTP/2 200`)

[1]: https://www.lucas-nussbaum.net/blog/?p=947
[2]: https://http2.github.io/http2-spec/#rfc.section.8.1.2.4

PR Close #29976
benlesh pushed a commit that referenced this pull request Apr 23, 2019
…er docker image (#29976)

This minimises the risk of unexpected failures due to breaking changes,
when building a new image (e.g. as a result of an unrelated config
change in Dockerfile).

PR Close #29976
benlesh pushed a commit that referenced this pull request Apr 23, 2019
…ver (#29976)

In #29926, the size of the build artifacts has increased due to turning
on differential loading (which generates an es2015/es5 pair for each JS
resource).

To avoid the preview server's rejecting the build artifacts (as in
[288181][1]), this commit increases the max allowed artifact size from
20MB to 25MB (current artifact size after #29926 is ~22MB).

[1]: https://circleci.com/gh/angular/angular/288181

PR Close #29976
benlesh pushed a commit that referenced this pull request Apr 23, 2019
…29976)

Previously, the preview server docker image was based on Debian 8
(jessie). Recently, `jessie-updates` and `jessie-backborts` were removed
from the Debian mirrors ([more info][1]), thus breaking new builds of
the image.

Instead of updating `/etc/apt/sources.list` to remove the obsolete
sources, this commit upgrades to Debian 9 (stretch).

(The GCE VM running the preview server docker container was also
upgraded from Debian 8 to 9 this morning.)

---
Other changes:
- Removed dependency on `chkconfig`, which is not supported on Debian 9.
- Installing `nginx` from the regular repositories (instead of
  `*-backports).
- Upgraded to `pm2` v3, which can handle hooking itself up to system
  startup better (without `chkconfig` - see above).
- Updated tests to reflect the fact that `nginx` has dropped the reason
  phrase in response status lines for HTTP/2 (in compliance with
  [the spec][2]). (HTTP/1.1: `HTTP/1.1 200 OK` | HTTP/2: `HTTP/2 200`)

[1]: https://www.lucas-nussbaum.net/blog/?p=947
[2]: https://http2.github.io/http2-spec/#rfc.section.8.1.2.4

PR Close #29976
benlesh pushed a commit that referenced this pull request Apr 23, 2019
…er docker image (#29976)

This minimises the risk of unexpected failures due to breaking changes,
when building a new image (e.g. as a result of an unrelated config
change in Dockerfile).

PR Close #29976
@gkalpak gkalpak deleted the build-aio-increase-preview-size-limit branch April 23, 2019 19:26
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
…ver (angular#29976)

In angular#29926, the size of the build artifacts has increased due to turning
on differential loading (which generates an es2015/es5 pair for each JS
resource).

To avoid the preview server's rejecting the build artifacts (as in
[288181][1]), this commit increases the max allowed artifact size from
20MB to 25MB (current artifact size after angular#29926 is ~22MB).

[1]: https://circleci.com/gh/angular/angular/288181

PR Close angular#29976
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
…ngular#29976)

Previously, the preview server docker image was based on Debian 8
(jessie). Recently, `jessie-updates` and `jessie-backborts` were removed
from the Debian mirrors ([more info][1]), thus breaking new builds of
the image.

Instead of updating `/etc/apt/sources.list` to remove the obsolete
sources, this commit upgrades to Debian 9 (stretch).

(The GCE VM running the preview server docker container was also
upgraded from Debian 8 to 9 this morning.)

---
Other changes:
- Removed dependency on `chkconfig`, which is not supported on Debian 9.
- Installing `nginx` from the regular repositories (instead of
  `*-backports).
- Upgraded to `pm2` v3, which can handle hooking itself up to system
  startup better (without `chkconfig` - see above).
- Updated tests to reflect the fact that `nginx` has dropped the reason
  phrase in response status lines for HTTP/2 (in compliance with
  [the spec][2]). (HTTP/1.1: `HTTP/1.1 200 OK` | HTTP/2: `HTTP/2 200`)

[1]: https://www.lucas-nussbaum.net/blog/?p=947
[2]: https://http2.github.io/http2-spec/#rfc.section.8.1.2.4

PR Close angular#29976
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
…er docker image (angular#29976)

This minimises the risk of unexpected failures due to breaking changes,
when building a new image (e.g. as a result of an unrelated config
change in Dockerfile).

PR Close angular#29976
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants