docs-infra: several random fixes/improvements#29989
Closed
gkalpak wants to merge 4 commits intoangular:masterfrom
Closed
docs-infra: several random fixes/improvements#29989gkalpak wants to merge 4 commits intoangular:masterfrom
gkalpak wants to merge 4 commits intoangular:masterfrom
Conversation
…ngcc To better test ngcc (in addition to Ivy) on angular.io, change the `test_aio_local_ivy` CircleCI job to use the pre-ivy Angular packages (and have ngcc transform them to Ivy ones).
Previously, the `build-with-ivy` script could be used to build the `aio` project with Ivy (once it had been prepared with `ivy-ngcc`, etc.) and then restored the configuration (e.g. `tsconfig.json`) to non-ivy mode. As a result, it was not useful for running other commands (e.g. unit/e2e tests) in Ivy mode. This commit renames the script to `switch-to-ivy` and employs a different model (similar to `ng-packages-installer`), where the project is setup to run in Ivy mode and then all subsequent commands are executed in that mode (until restored). Since this is currently only used on CI, there is no automatic way to switch back to non-ivy mode (but it could be implemented in the future if needed). Finally, the script now modifies `src/tsconfig.app/json` instead of `tsconfig.json` to ensure that the `angularCompilerOptions` are not ignored/overwritten. This is also closer to what the cli generates with the `--enable-ivy` option.
…re robust In light of angular#29926, that will change the path of `tsconfig.app.json`, this commit switches from a hard-coded `tsconfig.app.json` path to looking it up in `angular.json` (to be more future-proof).
|
You can preview 3bd3e6f at https://pr29989-3bd3e6f.ngbuilds.io/. |
16 tasks
devversion
approved these changes
Apr 19, 2019
Member
devversion
left a comment
There was a problem hiding this comment.
LGTM on the dev-infra part.
benlesh
pushed a commit
to benlesh/angular
that referenced
this pull request
Apr 19, 2019
…ngcc (angular#29989) To better test ngcc (in addition to Ivy) on angular.io, change the `test_aio_local_ivy` CircleCI job to use the pre-ivy Angular packages (and have ngcc transform them to Ivy ones). PR Close angular#29989
benlesh
pushed a commit
to benlesh/angular
that referenced
this pull request
Apr 19, 2019
…ngular#29989) Previously, the `build-with-ivy` script could be used to build the `aio` project with Ivy (once it had been prepared with `ivy-ngcc`, etc.) and then restored the configuration (e.g. `tsconfig.json`) to non-ivy mode. As a result, it was not useful for running other commands (e.g. unit/e2e tests) in Ivy mode. This commit renames the script to `switch-to-ivy` and employs a different model (similar to `ng-packages-installer`), where the project is setup to run in Ivy mode and then all subsequent commands are executed in that mode (until restored). Since this is currently only used on CI, there is no automatic way to switch back to non-ivy mode (but it could be implemented in the future if needed). Finally, the script now modifies `src/tsconfig.app/json` instead of `tsconfig.json` to ensure that the `angularCompilerOptions` are not ignored/overwritten. This is also closer to what the cli generates with the `--enable-ivy` option. PR Close angular#29989
benlesh
pushed a commit
to benlesh/angular
that referenced
this pull request
Apr 19, 2019
…re robust (angular#29989) In light of angular#29926, that will change the path of `tsconfig.app.json`, this commit switches from a hard-coded `tsconfig.app.json` path to looking it up in `angular.json` (to be more future-proof). PR Close angular#29989
benlesh
pushed a commit
that referenced
this pull request
Apr 19, 2019
benlesh
pushed a commit
that referenced
this pull request
Apr 19, 2019
…29989) Previously, the `build-with-ivy` script could be used to build the `aio` project with Ivy (once it had been prepared with `ivy-ngcc`, etc.) and then restored the configuration (e.g. `tsconfig.json`) to non-ivy mode. As a result, it was not useful for running other commands (e.g. unit/e2e tests) in Ivy mode. This commit renames the script to `switch-to-ivy` and employs a different model (similar to `ng-packages-installer`), where the project is setup to run in Ivy mode and then all subsequent commands are executed in that mode (until restored). Since this is currently only used on CI, there is no automatic way to switch back to non-ivy mode (but it could be implemented in the future if needed). Finally, the script now modifies `src/tsconfig.app/json` instead of `tsconfig.json` to ensure that the `angularCompilerOptions` are not ignored/overwritten. This is also closer to what the cli generates with the `--enable-ivy` option. PR Close #29989
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…ngcc (angular#29989) To better test ngcc (in addition to Ivy) on angular.io, change the `test_aio_local_ivy` CircleCI job to use the pre-ivy Angular packages (and have ngcc transform them to Ivy ones). PR Close angular#29989
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…ngular#29989) Previously, the `build-with-ivy` script could be used to build the `aio` project with Ivy (once it had been prepared with `ivy-ngcc`, etc.) and then restored the configuration (e.g. `tsconfig.json`) to non-ivy mode. As a result, it was not useful for running other commands (e.g. unit/e2e tests) in Ivy mode. This commit renames the script to `switch-to-ivy` and employs a different model (similar to `ng-packages-installer`), where the project is setup to run in Ivy mode and then all subsequent commands are executed in that mode (until restored). Since this is currently only used on CI, there is no automatic way to switch back to non-ivy mode (but it could be implemented in the future if needed). Finally, the script now modifies `src/tsconfig.app/json` instead of `tsconfig.json` to ensure that the `angularCompilerOptions` are not ignored/overwritten. This is also closer to what the cli generates with the `--enable-ivy` option. PR Close angular#29989
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…re robust (angular#29989) In light of angular#29926, that will change the path of `tsconfig.app.json`, this commit switches from a hard-coded `tsconfig.app.json` path to looking it up in `angular.json` (to be more future-proof). PR Close angular#29989
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly extracted from #28530, because they are independent of Ivy (and that one is taking too long to get in).