Merged
Conversation
dvoytenko
suggested changes
Jan 12, 2017
| * @return {Promise<*>|undefined} | ||
| */ | ||
| handleUnload(messaging) { | ||
| return messaging.sendRequest(RequestNames.UNLOADED, {}, true); |
Contributor
There was a problem hiding this comment.
Should be @private with _ suffix.
| /** | ||
| * Notifies the viewer when this document is unloaded. | ||
| * @return {Promise<*>|undefined} | ||
| */ |
| dev().assertString(this.unconfirmedViewerOrigin_)); | ||
|
|
||
| listenOnce( | ||
| this.win, 'unload', this.handleUnload.bind(this, messaging)); |
Contributor
There was a problem hiding this comment.
Tests needed. Might be of help - we expose window.eventListeners for testing purposes in realWin and fakeWin fixtures. E.g. you should be able to do something like:
win.eventListeners.fire({type: 'unload'});
dvoytenko
approved these changes
Jan 12, 2017
rpominov
pushed a commit
to yandex-pcode/amphtml
that referenced
this pull request
Jan 20, 2017
* master: (310 commits) Update csa.md to remove non-required parameters (ampproject#6902) Add notes about requesting ads ATF and link to demo (ampproject#7037) Remove whitelist for lightbox scrollable validator (ampproject#7034) Delegate submit events until amp-form is loaded (ampproject#6929) Moves closure sha384 into a new extension amp-crypto-polyfill for lazy load (ampproject#7006) Refactor observables in viewer-impl into a map object (ampproject#7004) resizing of margins (ampproject#6824) Use URL replacer from embed for pixel (ampproject#7029) adds support for Gemius analytics (ampproject#6558) Avoid duplicating server-layout (ampproject#7021) Laterpay validator config (ampproject#6974) Validator rollup (ampproject#7023) skeleton for amp-tabs (ampproject#7003) Upgrade post-css and related packages to latest (ampproject#7020) handle unload (ampproject#7001) viewer-integr.js -> amp-viewer-integration (ampproject#6989) dev().info()->dev().fine() (ampproject#7017) Turned on experiment flag (ampproject#6774) Unlaunch ios-embed-wrapper for iOS8 to avoid scroll freezing issues (ampproject#7018) Add some A4A ad request parameters (ampproject#6643) ...
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Jan 31, 2017
* handle unload * fix+test
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
* handle unload * fix+test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #6995