Delegate submit events until amp-form is loaded #6929
Merged
mkhatib merged 8 commits intoampproject:masterfrom Jan 13, 2017
Merged
Delegate submit events until amp-form is loaded #6929mkhatib merged 8 commits intoampproject:masterfrom
mkhatib merged 8 commits intoampproject:masterfrom
Conversation
cramforce
reviewed
Jan 7, 2017
| }); | ||
|
|
||
| /** | ||
| * Append ?sleep=5 to any included JS file in examples to emulate delay in loading that |
src/document-submit.js
Outdated
| // the actual submission. For non-XHR GET we let the submission go through | ||
| // to allow _blank target to work. | ||
| if (actionXhr) { | ||
| actionServiceForDoc(form).execute(form, 'submit', null, form, e); |
Contributor
There was a problem hiding this comment.
i think this should be the last line in this block
dvoytenko
suggested changes
Jan 10, 2017
extensions/amp-form/0.1/amp-form.js
Outdated
| this.urlReplacement_.expandInputValueSync(varSubsFields[i]); | ||
| } | ||
|
|
||
| // If this wasn't a submission event, trigger form submit. |
Contributor
There was a problem hiding this comment.
I don't really understand this. Could you explain? Can we split this into two methods?
Contributor
Author
There was a problem hiding this comment.
Yeah this confusion comes from reusing this method once for actual submit event handling and the other for doing an actual submission flow (triggered by on=form.submit for example).
I couldn't figure out how to refactor the function to reuse the functionality in either cases, but I can think a bit more about it and see if I can simplify it.
Contributor
Author
There was a problem hiding this comment.
Ok, I split this method to multiple ones for clarity and handling a submission event is now separate from handling a submission action. PTAL 👀
src/document-submit.js
Outdated
| // the actual submission. For non-XHR GET we let the submission go through | ||
| // to allow _blank target to work. | ||
| if (actionXhr) { | ||
| actionServiceForDoc(form).execute(form, 'submit', null, form, e); |
Contributor
Author
|
@dvoytenko PTAL 👀 |
dvoytenko
suggested changes
Jan 12, 2017
extensions/amp-form/0.1/amp-form.js
Outdated
| installEventHandlers_() { | ||
| this.form_.addEventListener('submit', e => this.handleSubmit_(e), true); | ||
| this.form_.addEventListener( | ||
| 'submit', e => this.handleSubmitEvent_(e), true); |
Contributor
There was a problem hiding this comment.
this.handleSubmitEvent_.bind(this)
| * invalid. stopImmediatePropagation allows us to make sure we don't trigger it. | ||
| * | ||
| * | ||
| * @param {?Event=} opt_event |
| event.preventDefault(); | ||
| return; | ||
| } | ||
| if (this.xhrAction_ || this.method_ == 'POST') { |
Contributor
There was a problem hiding this comment.
Please document why preventDefault is not needed in other situations.
Contributor
|
@mkhatib Looks good. Just a couple of minor requests. |
Contributor
Author
|
PTAL 👀 |
9d94522 to
6ca6119
Compare
dvoytenko
approved these changes
Jan 13, 2017
rpominov
pushed a commit
to yandex-pcode/amphtml
that referenced
this pull request
Jan 20, 2017
* master: (310 commits) Update csa.md to remove non-required parameters (ampproject#6902) Add notes about requesting ads ATF and link to demo (ampproject#7037) Remove whitelist for lightbox scrollable validator (ampproject#7034) Delegate submit events until amp-form is loaded (ampproject#6929) Moves closure sha384 into a new extension amp-crypto-polyfill for lazy load (ampproject#7006) Refactor observables in viewer-impl into a map object (ampproject#7004) resizing of margins (ampproject#6824) Use URL replacer from embed for pixel (ampproject#7029) adds support for Gemius analytics (ampproject#6558) Avoid duplicating server-layout (ampproject#7021) Laterpay validator config (ampproject#6974) Validator rollup (ampproject#7023) skeleton for amp-tabs (ampproject#7003) Upgrade post-css and related packages to latest (ampproject#7020) handle unload (ampproject#7001) viewer-integr.js -> amp-viewer-integration (ampproject#6989) dev().info()->dev().fine() (ampproject#7017) Turned on experiment flag (ampproject#6774) Unlaunch ios-embed-wrapper for iOS8 to avoid scroll freezing issues (ampproject#7018) Add some A4A ad request parameters (ampproject#6643) ...
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Jan 31, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6928
Fixes #6916
This also fixes non-xhr submit throguh the
on=action:form.submitsyntax.