Turned on 3p-frame-context-in-name experiment flag in prod#6774
Merged
lannka merged 2 commits intoampproject:masterfrom Jan 12, 2017
google:frizz-exp-flag
Merged
Turned on 3p-frame-context-in-name experiment flag in prod#6774lannka merged 2 commits intoampproject:masterfrom google:frizz-exp-flag
lannka merged 2 commits intoampproject:masterfrom
google:frizz-exp-flag
Conversation
Contributor
|
This needs to be tested in canary first. |
Contributor
|
Oh right, we need also change |
lannka
approved these changes
Jan 9, 2017
Contributor
Contributor
|
According to @erwinmombay, when we are doing release, we always pick up master HEAD for configs. |
Contributor
|
The last canary release was Dec 21 and I'm about to do the new canary release. The config flag should be online tomorrow. |
Contributor
|
OK, let's merge this PR later after we verified in canary. |
Contributor
Author
|
sounds good |
Contributor
|
Verified in canary, no new suspicious errors. |
Contributor
|
@lannka @bradfrizzell Okay for this to be in this week's Canary? (cutting a new one) |
Contributor
|
yes please. :-) |
Contributor
Author
|
thanks! |
rpominov
pushed a commit
to yandex-pcode/amphtml
that referenced
this pull request
Jan 20, 2017
* master: (310 commits) Update csa.md to remove non-required parameters (ampproject#6902) Add notes about requesting ads ATF and link to demo (ampproject#7037) Remove whitelist for lightbox scrollable validator (ampproject#7034) Delegate submit events until amp-form is loaded (ampproject#6929) Moves closure sha384 into a new extension amp-crypto-polyfill for lazy load (ampproject#7006) Refactor observables in viewer-impl into a map object (ampproject#7004) resizing of margins (ampproject#6824) Use URL replacer from embed for pixel (ampproject#7029) adds support for Gemius analytics (ampproject#6558) Avoid duplicating server-layout (ampproject#7021) Laterpay validator config (ampproject#6974) Validator rollup (ampproject#7023) skeleton for amp-tabs (ampproject#7003) Upgrade post-css and related packages to latest (ampproject#7020) handle unload (ampproject#7001) viewer-integr.js -> amp-viewer-integration (ampproject#6989) dev().info()->dev().fine() (ampproject#7017) Turned on experiment flag (ampproject#6774) Unlaunch ios-embed-wrapper for iOS8 to avoid scroll freezing issues (ampproject#7018) Add some A4A ad request parameters (ampproject#6643) ...
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Jan 31, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the flag as in #6498