Skip to content

🏗 Move Edge testing from GH Actions to CircleCI#35630

Merged
rsimha merged 2 commits intoampproject:mainfrom
rsimha:2021-08-10-EdgeTests
Aug 12, 2021
Merged

🏗 Move Edge testing from GH Actions to CircleCI#35630
rsimha merged 2 commits intoampproject:mainfrom
rsimha:2021-08-10-EdgeTests

Conversation

@rsimha
Copy link
Copy Markdown
Contributor

@rsimha rsimha commented Aug 11, 2021

Picking up from where #35455 and #35594 left off.

PR Highlights:

  • Move all Edge testing to CircleCI
  • Reuse build output from the previous stage
  • Run tests on a Linux Docker VM
  • Move IE testing to ie-tests.yml (will be turned off after Aug 26)
  • Move cross-platform building to cross-platform-builds.yml (only push builds, non-blocking for PRs)
  • Bonus cleanup:
    • Consolidate all browser test scripts into browser-tests.js (minimize repetition)
    • Consolidate all custom browser launcher configs into custom-launchers.js (previously all over the place)

References:

@rsimha rsimha self-assigned this Aug 11, 2021
@rsimha rsimha requested a review from rileyajones August 12, 2021 14:54
@rsimha rsimha marked this pull request as ready for review August 12, 2021 14:54
@rsimha rsimha requested a review from estherkim August 12, 2021 14:59
@rsimha rsimha merged commit a59d776 into ampproject:main Aug 12, 2021
@rsimha rsimha deleted the 2021-08-10-EdgeTests branch August 12, 2021 18:32
zoharnyego added a commit to apester-dev/amphtml that referenced this pull request Aug 12, 2021
commit b9e41a2
Author: Ryan Cebulko <ryan@cebulko.com>
Date:   Thu Aug 12 16:47:01 2021 -0400

    ♻️ Define helper for hash params and drop barely-used `getMode().log` (ampproject#35628)

    * Add getHashParams helper

    * Add win param

    * Update mode.js to use helper

    * Add tests

    * Update callsites

    * Remove getMode().log uses

    * Remove log from ModeDef type

    * Lint fixes

    * Fix tests

    * Split up isModeDevelopment

commit 0e66e28
Author: Alan Orozco <alanorozco@users.noreply.github.com>
Date:   Thu Aug 12 13:25:34 2021 -0700

    🚮 Remove `<amp-story>` check for `<amp-audio>` actions (ampproject#35643)

    Removes check from `<amp-audio>` that prevents actions when descending from an `<amp-story>` element.

    `<amp-story>` now has an action allowlist, so the check was redundant. The action is still prevented, triggering the message '[Action] "AMP-AUDIO.play" is not allowlisted []'.

commit 6b46842
Author: honeybadgerdontcare <honeybadgerdontcare@users.noreply.github.com>
Date:   Thu Aug 12 13:19:24 2021 -0700

    Update link to modifications best practices (ampproject#35647)

    * Update link to modifications best practices

    * Update dead links

commit a59d776
Author: Raghu Simha <rsimha@amp.dev>
Date:   Thu Aug 12 14:31:55 2021 -0400

    🏗 Move Edge testing from GH Actions to CircleCI (ampproject#35630)

commit b6476c3
Author: Khoi Doan <khoid@google.com>
Date:   Thu Aug 12 13:47:16 2021 -0400

    ✨ Add bitness to User Agent Client Hint Params in ad requests (ampproject#35612)

    * Add User Agent Client Hint Params to Google Ads.

    * Update the param names.

    * Add timeout for UACH promise (1 second).

    * Use fake timers for timeout test.

    * Lint

    * Add exception for dependency on promise.js.

    * Add bitness field to User Agent Client Hints params

    * Fix merge

    * Fix merge again

    * Lint

commit 87d5d14
Author: Ryan Cebulko <ryan@cebulko.com>
Date:   Thu Aug 12 13:43:51 2021 -0400

    ♻️  Remove `version` from legacy mode object (ampproject#35624)

    * Remove `version` from legacy mode object

    * Restore version to mode-object for now

    * Remove version entirely

    * Lint fixes

    * Fix transformer test fixtures

    * Fix test

commit 00b8e7e
Author: Brandon Suen <brandonbsuen@google.com>
Date:   Thu Aug 12 10:31:56 2021 -0700

    📖 [Story interactive] Add Documentation for Image Quizzes and Polls (ampproject#35618)

    * Documentation text added

    * Add images and source code

    * Reorganize in alphabetical order

    * Reordering

    * Add additional attributes

    * Fix typo

    * Fix typo

    * Fix typo

    * Update screenshots

    * Add note about image sizes

    * Revise note about image size

commit 9813cea
Author: Ryan Cebulko <ryan@cebulko.com>
Date:   Thu Aug 12 13:27:55 2021 -0400

    ♻️ #core form, modal, amp-element-helpers ("real" diff in desc) (ampproject#35608)

    * Update src/form code

    * Update src/modal code

    * Update src/video-interface code

    * Move src/{form,modal,amp-element-helpers} -> #core/dom

    * Fix types

    * update dep-check config

    * Remove bad assert

    * Update imports of form,modal,amp-element-helpers

    * Fix rebase error

commit 4ed4b92
Author: Philip Bell <philip.hunter.bell@gmail.com>
Date:   Thu Aug 12 12:38:05 2021 -0400

    Null check on orientation lock. (ampproject#35639)

commit 5ff32ad
Author: Chris Antaki <ChrisAntaki@gmail.com>
Date:   Wed Aug 11 15:12:58 2021 -0700

    SwG Release 0.1.22.179 (ampproject#35629)

commit 2106624
Author: Matias Szylkowski <mszylkowski@google.com>
Date:   Wed Aug 11 17:13:54 2021 -0400

    📖 [Story sidebar] Removed sidebar from docs (ampproject#35616)

    * removed sidebar and bookend docs

    * removed unused import

    * revert test removals

    * Add newline on visual test html

commit d21ecc0
Author: Ryan Cebulko <ryan@cebulko.com>
Date:   Wed Aug 11 17:01:02 2021 -0400

    ♻️ #core: error helpers (ampproject#35621)

    * Define core/error helpers

    * Drop createErrorVargs

    * Restore name assignment in Log#error

    * Typechecking/extern

    * Remove unused error_ helper

    * Typo

    * Add @ returns

commit 6404407
Author: Brandon Suen <brandonbsuen@google.com>
Date:   Wed Aug 11 13:33:02 2021 -0700

    ✅ [Story interactive] Rename Example Image Quiz and Poll Stories to Use .amp.html Extension (ampproject#35511)

    * Rename examples to use .amp.html extension

    * Remove confetti from results
@samouri
Copy link
Copy Markdown
Member

samouri commented Aug 17, 2021

@rsimha FYI: I believe that this PR has introduced a new error for CI on every commit to main. I can help investigate tomorrow.

Example error (link)

[18:38:17] ERROR: Error: Build failed with 1 error:
extensions/amp-animation/0.1/parsers/css-expr.js:16:36: error: Could not resolve "../../../../build/parsers/css-expr-impl" 

[18:38:17] 'build' errored after 2m 14s
[18:38:17] Error: Could not compile amp-animation-0.1.max.js

@rsimha
Copy link
Copy Markdown
Contributor Author

rsimha commented Aug 17, 2021

@samouri That's a known problem that I too was going to look into at some point. Here's more context:

  • Until a couple weeks ago, we were only doing minified build + testing on GH actions (win + macos + linux)
  • Once testing moved to CircleCI, I added a step to verify builds on all OSs (post-commit only, non-blocking for PRs)
  • It was then that I realized we weren't doing unminified builds on win / macos, so I added it to the mix

function pushBuildWorkflow() {
timedExecOrDie('amp build');
timedExecOrDie('amp dist');
}

The failure you're seeing is from running 31 on Windows. I suspect the bug has to do with hard-coded paths in css-expr* that aren't resolving on Windows.

@rsimha
Copy link
Copy Markdown
Contributor Author

rsimha commented Aug 18, 2021

Windows unminified build has been fixed (see #35713 (comment)), and the workflow has been matrixified for easy error detection (see #35731).

@samouri
Copy link
Copy Markdown
Member

samouri commented Aug 18, 2021

Thank you Raghu! You're on 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants