Skip to content

♻️ #core form, modal, amp-element-helpers ("real" diff in desc)#35608

Merged
rcebulko merged 9 commits intoampproject:mainfrom
rcebulko:core-etc
Aug 12, 2021
Merged

♻️ #core form, modal, amp-element-helpers ("real" diff in desc)#35608
rcebulko merged 9 commits intoampproject:mainfrom
rcebulko:core-etc

Conversation

@rcebulko
Copy link
Copy Markdown
Contributor

@rcebulko rcebulko commented Aug 10, 2021

part of #32693
Real diff: 5aafd57...b82ed04

@rcebulko rcebulko force-pushed the core-etc branch 3 times, most recently from d312486 to 9b95e51 Compare August 11, 2021 16:43
@rcebulko rcebulko requested review from jridgewell and samouri August 11, 2021 17:07
@rcebulko rcebulko changed the title ♻️ #core form, modal, amp-element-helpers ♻️ #core form, modal, amp-element-helpers ("real" diff in desc) Aug 11, 2021
@rcebulko rcebulko marked this pull request as ready for review August 11, 2021 17:07
@amp-owners-bot
Copy link
Copy Markdown

Hey @gmajoulet! These files were changed:

extensions/amp-story-360/0.1/amp-story-360.js
extensions/amp-story-education/0.1/amp-story-education.js
extensions/amp-story-panning-media/0.1/amp-story-panning-media.js
extensions/amp-story/1.0/amp-story-draggable-drawer.js
extensions/amp-story/1.0/amp-story-page.js
extensions/amp-story/1.0/amp-story-render-service.js
extensions/amp-story/1.0/amp-story.js
extensions/amp-story/1.0/background-blur.js

Hey @processprocess! These files were changed:

extensions/amp-story-360/0.1/amp-story-360.js
extensions/amp-story-panning-media/0.1/amp-story-panning-media.js

Hey @t0mg! These files were changed:

extensions/amp-story-360/0.1/amp-story-360.js

Hey @newmuis! These files were changed:

extensions/amp-story-panning-media/0.1/amp-story-panning-media.js
extensions/amp-story/1.0/amp-story-draggable-drawer.js
extensions/amp-story/1.0/amp-story-page.js
extensions/amp-story/1.0/amp-story-render-service.js
extensions/amp-story/1.0/amp-story.js
extensions/amp-story/1.0/background-blur.js

Hey @jridgewell! These files were changed:

src/core/dom/amp-element-helpers.js
src/core/dom/form.js
src/core/dom/modal.js

@rcebulko rcebulko requested a review from caroqliu August 11, 2021 20:33
@rcebulko rcebulko enabled auto-merge (squash) August 12, 2021 16:24
Copy link
Copy Markdown
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for ads files.

Copy link
Copy Markdown
Contributor Author

@rcebulko rcebulko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumping owners

Copy link
Copy Markdown
Contributor Author

@rcebulko rcebulko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

owners bump

@rcebulko rcebulko merged commit 9813cea into ampproject:main Aug 12, 2021
@rcebulko rcebulko deleted the core-etc branch August 12, 2021 17:28
zoharnyego added a commit to apester-dev/amphtml that referenced this pull request Aug 12, 2021
commit b9e41a2
Author: Ryan Cebulko <ryan@cebulko.com>
Date:   Thu Aug 12 16:47:01 2021 -0400

    ♻️ Define helper for hash params and drop barely-used `getMode().log` (ampproject#35628)

    * Add getHashParams helper

    * Add win param

    * Update mode.js to use helper

    * Add tests

    * Update callsites

    * Remove getMode().log uses

    * Remove log from ModeDef type

    * Lint fixes

    * Fix tests

    * Split up isModeDevelopment

commit 0e66e28
Author: Alan Orozco <alanorozco@users.noreply.github.com>
Date:   Thu Aug 12 13:25:34 2021 -0700

    🚮 Remove `<amp-story>` check for `<amp-audio>` actions (ampproject#35643)

    Removes check from `<amp-audio>` that prevents actions when descending from an `<amp-story>` element.

    `<amp-story>` now has an action allowlist, so the check was redundant. The action is still prevented, triggering the message '[Action] "AMP-AUDIO.play" is not allowlisted []'.

commit 6b46842
Author: honeybadgerdontcare <honeybadgerdontcare@users.noreply.github.com>
Date:   Thu Aug 12 13:19:24 2021 -0700

    Update link to modifications best practices (ampproject#35647)

    * Update link to modifications best practices

    * Update dead links

commit a59d776
Author: Raghu Simha <rsimha@amp.dev>
Date:   Thu Aug 12 14:31:55 2021 -0400

    🏗 Move Edge testing from GH Actions to CircleCI (ampproject#35630)

commit b6476c3
Author: Khoi Doan <khoid@google.com>
Date:   Thu Aug 12 13:47:16 2021 -0400

    ✨ Add bitness to User Agent Client Hint Params in ad requests (ampproject#35612)

    * Add User Agent Client Hint Params to Google Ads.

    * Update the param names.

    * Add timeout for UACH promise (1 second).

    * Use fake timers for timeout test.

    * Lint

    * Add exception for dependency on promise.js.

    * Add bitness field to User Agent Client Hints params

    * Fix merge

    * Fix merge again

    * Lint

commit 87d5d14
Author: Ryan Cebulko <ryan@cebulko.com>
Date:   Thu Aug 12 13:43:51 2021 -0400

    ♻️  Remove `version` from legacy mode object (ampproject#35624)

    * Remove `version` from legacy mode object

    * Restore version to mode-object for now

    * Remove version entirely

    * Lint fixes

    * Fix transformer test fixtures

    * Fix test

commit 00b8e7e
Author: Brandon Suen <brandonbsuen@google.com>
Date:   Thu Aug 12 10:31:56 2021 -0700

    📖 [Story interactive] Add Documentation for Image Quizzes and Polls (ampproject#35618)

    * Documentation text added

    * Add images and source code

    * Reorganize in alphabetical order

    * Reordering

    * Add additional attributes

    * Fix typo

    * Fix typo

    * Fix typo

    * Update screenshots

    * Add note about image sizes

    * Revise note about image size

commit 9813cea
Author: Ryan Cebulko <ryan@cebulko.com>
Date:   Thu Aug 12 13:27:55 2021 -0400

    ♻️ #core form, modal, amp-element-helpers ("real" diff in desc) (ampproject#35608)

    * Update src/form code

    * Update src/modal code

    * Update src/video-interface code

    * Move src/{form,modal,amp-element-helpers} -> #core/dom

    * Fix types

    * update dep-check config

    * Remove bad assert

    * Update imports of form,modal,amp-element-helpers

    * Fix rebase error

commit 4ed4b92
Author: Philip Bell <philip.hunter.bell@gmail.com>
Date:   Thu Aug 12 12:38:05 2021 -0400

    Null check on orientation lock. (ampproject#35639)

commit 5ff32ad
Author: Chris Antaki <ChrisAntaki@gmail.com>
Date:   Wed Aug 11 15:12:58 2021 -0700

    SwG Release 0.1.22.179 (ampproject#35629)

commit 2106624
Author: Matias Szylkowski <mszylkowski@google.com>
Date:   Wed Aug 11 17:13:54 2021 -0400

    📖 [Story sidebar] Removed sidebar from docs (ampproject#35616)

    * removed sidebar and bookend docs

    * removed unused import

    * revert test removals

    * Add newline on visual test html

commit d21ecc0
Author: Ryan Cebulko <ryan@cebulko.com>
Date:   Wed Aug 11 17:01:02 2021 -0400

    ♻️ #core: error helpers (ampproject#35621)

    * Define core/error helpers

    * Drop createErrorVargs

    * Restore name assignment in Log#error

    * Typechecking/extern

    * Remove unused error_ helper

    * Typo

    * Add @ returns

commit 6404407
Author: Brandon Suen <brandonbsuen@google.com>
Date:   Wed Aug 11 13:33:02 2021 -0700

    ✅ [Story interactive] Rename Example Image Quiz and Poll Stories to Use .amp.html Extension (ampproject#35511)

    * Rename examples to use .amp.html extension

    * Remove confetti from results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants