Skip to content

🏗 Move macOS testing from GH Actions to CircleCI#35455

Merged
rsimha merged 2 commits intoampproject:mainfrom
rsimha:2021-07-29-CrossBrowserTests
Aug 9, 2021
Merged

🏗 Move macOS testing from GH Actions to CircleCI#35455
rsimha merged 2 commits intoampproject:mainfrom
rsimha:2021-07-29-CrossBrowserTests

Conversation

@rsimha
Copy link
Copy Markdown
Contributor

@rsimha rsimha commented Jul 29, 2021 •
edited
Loading

With all the recent work done to speed up CI, the coast is clear to start moving our cross browser tests from GH Actions to CircleCI.

PR Highlights:

  • Move all macOS testing to CircleCI
  • Reuse build output from the previous stage
  • Bonus:
    • Clean up / standardize executor names
    • Consolidate some setup steps
    • Surround the main step of each job with ⭐ to make it easy to spot

There's no need for parallelization since only a subset of tests are run on macOS.

References:

@rsimha rsimha self-assigned this Jul 29, 2021
@rsimha rsimha requested a review from danielrozenberg August 6, 2021 21:42
@rsimha rsimha marked this pull request as ready for review August 6, 2021 21:42
@rsimha rsimha changed the title 🏗 Move macOS testing from GH Actions to CircleCI 🏗 Move macOS building + testing from GH Actions to CircleCI Aug 9, 2021
@rsimha rsimha changed the title 🏗 Move macOS building + testing from GH Actions to CircleCI 🏗 Move macOS testing from GH Actions to CircleCI Aug 9, 2021
rsimha
rsimha commented Aug 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@rsimha rsimha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielrozenberg A couple comments below to kick off the code review discussion. Ideally, I'd like to land this with a close to zero increase in overall CI running time.

danielrozenberg
danielrozenberg reviewed Aug 9, 2021
View reviewed changes
@rsimha rsimha merged commit ca28bdc into ampproject:main Aug 9, 2021
@rsimha rsimha deleted the 2021-07-29-CrossBrowserTests branch August 9, 2021 20:51
This was referenced Aug 9, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielrozenberg danielrozenberg danielrozenberg approved these changes

Assignees

@rsimha rsimha

Labels

PR use: In Beta / Experimental PR use: In LTS PR use: In Stable WG: infra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rsimha @danielrozenberg @ampprojectbot