Merged
Conversation
|
Hey @gmajoulet, @newmuis, @Enriqe! These files were changed: Hey @ampproject/wg-caching! These files were changed: |
honeybadgerdontcare
approved these changes
Aug 5, 2020
Contributor
|
@GeorgeLuo FYI some validator changes: (1) AMP Email has a new document size byte limit, currently 100k and (2) AMP Actions is deprecated and removed from the Validator. |
Enriqe
approved these changes
Aug 5, 2020
Contributor
Enriqe
left a comment
There was a problem hiding this comment.
Approval for amp-story.protoascii
This should have been part of e498e1e.
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* cl/323700659 Revision bump for ampproject#29329 * cl/323797874 Revision bump for ampproject#29542 * cl/323858009 Revision bump for ampproject#29409 * cl/323889989 n/a * cl/324641097 Implements document level byte count limitation. * cl/324911894 Remove AMP Actions from Validator * cl/324915915 Revision bump for ampproject#29642 Co-authored-by: Greg Grothaus <greggrothaus@google.com> Co-authored-by: Amaltas Bohra <amaltas@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
selectanduseas descendants of mega-menu and nested-menu #29409